Hi! I'm trying debcraft on some packages. There seems to be something wrong with the spell checker fix. It seems to add a 'Section: golang' field to golang-*-dev packages. Why is this? I have seen similar commits to a couple of packages, it seems (although I'm not entirely certain) to happen when the source package do not have a 'Section: golang' field. This is arguable a bug, which debcraft could fix, but the log message used here seems wrong. https://salsa.debian.org/go-team/packages/golang-github-kr-binarydist/-/commit/b3792bc03d8ad5cf5655c3d2fb9dd5de13ca29b2 /Simon
Hi, Thanks for testing! This is indeed a bug, that changes is certainly not a typofix. I will look into it.
Otto Kekäläinen <otto@debian.org> writes: I think the right thing to do here is for all 'Source: golang-*' packages make sure there is a 'Section: golang' in the source stanza. And remove any (then) unnecessary 'Section: golang' from the golang-*-dev binary package. The patch installed by debcraft now ADDS a 'Section: golang' to the golang-*-dev which isn't incorrect, but also doesn't seem optimal. At least if the source package only contains one binary golang-*-dev package. It becomes a bit more subtle if there are any other binary packages built. Often I think it is still incorrect, but sometimes intentional, and hard to tell apart automatically. /Simon
I was able to reproduce this now:
golang-github-kr-binarydist debian/master ± git reset --hard e3f90a2
golang-github-kr-binarydist debian/master(-21) ± debcraft improve
...
Improving source package at
/home/otto/debian/go-team/golang-github-kr-binarydist
Running copyright-review.sh:
++ lrc
C: Versions: licenserecon '17.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
No significant differences found
Running copyright-years.sh:
No recent contributors found for debian/, no copyright update needed
Running formatting.sh:
++ debputy reformat --style black
--- ./debian/control
+++ ./debian/control
@@ -2,11 +2,13 @@
Section: devel
Priority: optional
Maintainer: Debian Go Packaging Team
<pkg-go-maintainers@lists.alioth.debian.org>
-Uploaders: Nicolas Braud-Santoni <nicoo@debian.org>
-Build-Depends: bsdiff,
- debhelper-compat (= 12),
- dh-golang,
- golang-go
+Uploaders:
+ Nicolas Braud-Santoni <nicoo@debian.org>,
+Build-Depends:
+ debhelper-compat (= 12),
+ dh-golang,
+ bsdiff,
+ golang-go,
Standards-Version: 4.5.0
Homepage: https://github.com/kr/binarydist
Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-github-kr-binarydist
@@ -15,9 +17,10 @@
Package: golang-github-kr-binarydist-dev
Architecture: all
-Depends: ${shlibs:Depends},
- ${misc:Depends},
- golang-go
+Depends:
+ golang-go,
+ ${misc:Depends},
+ ${shlibs:Depends},
Description: Go implementation of the bspatch algorithm
This Go library implements binary diff and patch as
described on http://www.daemonology.net/bsdiff/. It reads and writes
Reformatted ./debian/control.
DEBCRAFT WARNING: Command exited with code 2.
++ wrap-and-sort -ast
[debian/master e3d9243] Apply consistent formatting to packaging files
1 file changed, 11 insertions(+), 8 deletions(-)
Running policy-4.7.3-priority-optional.sh:
++ sed -i -E /^\s*Priority:\s*optional\s*$/d debian/control
[debian/master 33f30f0] Drop redundant `Priority: optional`
1 file changed, 1 deletion(-)
Running policy-4.7.3-rules-requires-root.sh:
No 'Rules-Requires-Root: no' found
Running policy-version.sh:
++ sed -i -E s/^\s*Standards-Version:\s*.*\s*$/Standards-Version:
4.7.4/ debian/control
[debian/master 9023335] Bump Debian Policy version to 4.7.4
1 file changed, 1 insertion(+), 1 deletion(-)
Running shellcheck.sh:
Running spelling.sh:
++ codespell --write-changes --check-filenames --check-hidden
--skip=debian/changelog,debian/patches,debian/vendor,debian/source/lintian-overrides,*.lintian-overrides,*.po,*.pot
debian/
++ debputy lint --spellcheck --auto-fix
spelling: File: ./debian/changelog:7:29:7:39: Spelling "upstream's" [debputy]
7: * debian/gbp.conf: Support upstream's release tags, use pristine-tar
spelling: File: ./debian/changelog:10:13:10:21: Spelling "Uploader" [debputy]
10: + Update Uploader email address
None of the issues in ./debian/changelog could be fixed automatically. Sorry!
auto-fixing: File: ./debian/control:17:0:18:0: The Section should be
"golang" based on the package name [debputy]
spelling: File: ./debian/control:24:38:24:45: Spelling "bspatch" [debputy]
24: Description: Go implementation of the bspatch algorithm
Fixes applied to ./debian/control: 1. Number of issues went from 2 to 1
No issues detected in ./debian/copyright
No issues detected in ./debian/rules
No issues detected in ./debian/upstream/metadata
No issues detected in ./debian/watch
DEBCRAFT WARNING: Failed with exit code 2.
[debian/master 0fb6163] Fix spelling
1 file changed, 1 insertion(+)
Improving package complete
The result happened because the command `debputy lint --spellcheck
--auto-fix` does more than fixing typos, yet the commit message only
mentions spelling fixes. I think I will refactor this to run `debputy
linit --auto-fix` first and commit that, and only after that with
--spellcheck ensuring the latter run only does spell fixes.
This is the explanation from Debputy: auto-fixing: File: ./debian/control:16:0:17:0: The Section should be "golang" based on the package name [debputy] If you think this is incorrect, we should file a bug against Debputy to handle it differently.
We believe that the bug you reported is fixed in the latest version of debcraft, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1142619@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Otto Kekäläinen <otto@debian.org> (supplier of updated debcraft package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) Format: 1.8 Date: Mon, 27 Jul 2026 10:10:10 +0000 Source: debcraft Architecture: source Version: 0.9.3 Distribution: unstable Urgency: medium Maintainer: Otto Kekäläinen <otto@debian.org> Changed-By: Otto Kekäläinen <otto@debian.org> Closes: 1142619 Changes: debcraft (0.9.3) unstable; urgency=medium . * Run `debputy lint` as a separate improvement (Closes: #1142619) Checksums-Sha1: 74cc1e2d39fbd4f337647cc55fb29027983bae70 1698 debcraft_0.9.3.dsc f2d21ee59cf9ef1a062b4ce6888a33e4600c7f48 71024 debcraft_0.9.3.tar.xz ab400e8f6228f2e2e9f8dd341427780953c8d6f5 9305 debcraft_0.9.3_source.buildinfo Checksums-Sha256: d3283127b6eabc69ee36644b6e8da985f03a3de629d55042a1b090d59f0f07df 1698 debcraft_0.9.3.dsc c2c1ea7a9919e12acc8d9dedfa8140d6c4e5a879b49a890e0549e2a1434c8ff6 71024 debcraft_0.9.3.tar.xz da9708ced14130a73d550f63a2da335b2295f70775af066ecad07d7e2387ec45 9305 debcraft_0.9.3_source.buildinfo Files: 542b1ae17808d4cd7decf5fcc95ffb85 1698 misc optional debcraft_0.9.3.dsc 9e9331ece69c60f4e33e2c5bd607022c 71024 misc optional debcraft_0.9.3.tar.xz 301a7daa350c29ae673ea1dd0ff641b8 9305 misc optional debcraft_0.9.3_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmbRSsR88dMO0U+RvvthEn87o2ogFAmpnLvkACgkQvthEn87o 2ohcIA/9HKoxT2C+Wln/JikoXNkpiqIdPkW3igA7FbIqzp/cWZmDDNLllFKCxPFi IwaqSXSJrCIMse7kWXW/iZrjjaN/fWXcPaGbtonCShrxvKla+DWmNkBKZWDNDPuk JC75EGMfXVcmFdIMEp1sHlXmbKWlgwZj3dRd8wa3HMe3Upja6EqWT20Vzc+C3FVM XP4WLhD/XOB6WPWCDwsrc/0c87Vk/hihqrzxveunCepvsVOX0YyFZqgpu4NmnhYa +IOaQwGszeq9A0Fy44GLKo59JgOPnognWbVvrF8jymojPackv5rXJOruAYcHMxst zuLeinrSVlVgs0f4iDM8NawCFgjsoOvj3yy/C7bWfSpJLv4RzkJ8MoKs7+Ng5e2p xLFgWOoUxsm6nZ+aFyMNum9Q/NYTgBw/W+EEblKIgZunZs7ZAWNAgsNSZPLdrLA3 FC85MeuYKCMQR/ndU4GjbSHGSMFx1Cll4Vrguc9tYW552583KB04GgZq5+chvtOr AEweH75X5jMOiL3LYHHfR8WOCtZk5HgXLNYDwzRDsTg8oQN4x+h+IzFWbXUC4NVs unYZXcsKkTO2W2CzNfbI4N44rfvgMez2UBhWTIEaEO6W1LGvg50X0bENC6JtyiRx jEgG3pbH1AvIeG7RuukaEJ1Bcb4k4hyoZ2EfM7GF5tTyaQl5PIg= =eh/E -----END PGP SIGNATURE-----