I noticed that git-debpush doesn't push the upstream branch to salsa
(for a typical gbp-style package) which can (and, in retrospect, has)
lead to troubles for teams using this laylout.

Last example:

#v+
% git debpush --gbp --upstream=upstream/0.44
git-debpush: checking state at git@salsa.debian.org:perl-team/modules/packages/libpdf-reuse-perl.git
git-debpush: check failed: unneeded --gbp on command line, would have autodetected it ('superfluous-quilt-mode' check)
git-debpush: proceed anyway? (y/N) y
git-debpush: making signed tag debian/0.44-1
git-debpush: pushing to git remote origin
Enumerating objects: 158, done.
Counting objects: 100% (141/141), done.
Delta compression using up to 4 threads
Compressing objects: 100% (77/77), done.
Writing objects: 100% (117/117), 42.27 KiB | 10.57 MiB/s, done.
Total 117 (delta 52), reused 74 (delta 27), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (52/52), completed with 11 local objects.
remote:
remote: To create a merge request for pristine-tar, visit:
remote:   https://salsa.debian.org/perl-team/modules/packages/libpdf-reuse-perl/-/merge_requests/new?merge_request%5Bsource_branch%5D=pristine-tar
remote:
To salsa.debian.org:perl-team/modules/packages/libpdf-reuse-perl.git
   682fbec..94af040  master -> master
   a4c25ad..1e6b483  pristine-tar -> pristine-tar
 * [new tag]         upstream/0.44 -> upstream/0.44
 * [new tag]         debian/0.44-1 -> debian/0.44-1
#v-

The master and pristine-tar branches are pushed, as well as the
upstream/ and the new debian/ tag but that's it.

/*
As a side note: _Asking_ if I want to proceed because my "--gbp" is
the same as what git-debpush detected itself is a bit annoying. An
info is fine.
*/


Cheers,
gregor
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmps4bZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgZbwA//QWyjlhPioGCjYWVPH+SqoMxeggEEVWSqHyxbEoD3BH97E6GUyJayk8TE
f/n1X0kzmGnRvv/+PyitWhDPEwSD3qHqXYN00C41xXVuqBCGiIqMs+qP/3gilMri
KXF+tt5Uicn7s0mQ8j3d7YYRv9mKkUd3c8XU0heIOa77DaKEtkOIcurJiPqJKWVV
HOK9Q9nq2EwB5Nb0NFkxr6YcE6x6zqpVyglnVvwTbnfsjk4DH/rilcvg0AZdVbWk
CFkcIAL8WXKq53yOq14+WJ3LDoF7twBGlvufPOg8KAZ9at2vcmUR81YZhfvHVcBB
AK8c3koKwP3qJAsx5/rBdW7fa2pBMr7kKZTp2EYzgRRoqYYD6QuhfDtoTmzcDdF7
sjmFsFy3eVMNdkebLWkhOdP4aPouPzJWhWWyXbLnN0eLCt4tggRuMtpDSwGrYGPv
67Weh/Z7gzO/Uu4qxeOpk0pW7OC3ecSbXYgWj5P09hkDqOWYC2n8vWps3JwBIqXA
mTF28CjXIz528B+YTOTAiDeDrqkkZSn17/3KBubiupDgwuAFCM4cSjHH49QD6Uyu
H8+4XhNr5RGhFEgcQzFkZfImEPkBC2KGHRyz9h6S0W3Ss6Veq5YA+BRdciLRk49O
i8H79jgl7nA05d7ZhJhrDy/Kx9+M8q5TFJhnVFVYHcUDWXZp/t4=
=Fhvl
-----END PGP SIGNATURE-----

gregor herrmann writes ("Bug#1143205: git-debpush: should push upstream branch (for gpb repos)"):
...

Hrm.  I see your point.  I thin we need to think, though, about when
this should happen.

How about this for the conditions:

 * upstream tag that we used for the upload is named upstream/...
   (indicating use of a separate Debian upstream branch)

 * upstream tag points to a commit that's on the local upstream
   branch which is fast forward from the remote upstream branch
   (or remote upstream branch is absent).
   Ie, pushing the upstream branch would make the tagged commit
   reachable from the upstream branch.

I will clone the bug for this and then reply in the clone,
for reasons that will become clear...

Ian.

gregor herrmann writes ("Bug#1143205: git-debpush: should push upstream branch (for gpb repos)"):
from our users about they find most convenient.

You're not the first to write sceptically about this.[1]  I agree
with you, quite strongly, that this shouldn't be an interactive
prompt.  But Sean feels, also quite strongly, that it should remain.

The discussion so far has been in this gitlab MR discussion:
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/497
I'm filing this bug to assist with discovery, and to allow users to
comment via the BTS rather than requiring use of salsa.

I don't think we should turn this bug report, or the MR discussion,
into a "me too" fest but (i) if you have something new to say that
hasn't been covered by the discussion already, please go ahead - here
or there - and (ii) I guess you could "thumbs up" at the top of the
MR.

Ian.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1140941#5