Severity: normal




Dear mentors,




I am looking for a sponsor for the new version 2.0.0-1 of my package

"formiko".




 * Package name    : formiko

   Version         : 2.0.0-1

   Upstream Author : Ondřej Tůma <mcbig@zeropage.cz>

 * URL             : https://formiko.zeropage.cz

 * License         : BSD-3-Clause and MIT

   Vcs             : https://github.com/ondratu/formiko-debian.git

   Section         : editors




It builds those binary packages:




  formiko    - reStructuredText and MarkDown editor and live previewer




To access further information about this package, please visit the

following URL:




  https://mentors.debian.net/package/formiko/




Alternatively, you can download the package with dget using this

command:




  dget -x https://mentors.debian.net/debian/pool/main/f/formiko/formiko_2.0.
0-1.dsc




Changes since the last upload:




  * New upstream release (2.0.0), a major rewrite ported to GTK4,

    libadwaita and GtkSourceView 5 (Closes: #1079410):

    - Replace WebKit2GTK 4.1 with WebKit 6.0 (GTK4)

    - Replace gtkspell3 spell checking with libspelling

    - Drop recommonmark in favour of built-in Markdown handling

    - Add jsonpath-ng runtime dependency

    - Add optional neovim (vte), spelling and extra-writers integration

  * debian/control:

    - Bump debhelper-compat to 14, Standards-Version to 4.7.4

    - Add Rules-Requires-Root: no

    - Add dh-sequence-python3, dh-sequence-single-binary and

      python3-pytest to Build-Depends, required with compat 14

    - Add python3-gi, gir1.2-adw-1, gir1.2-gtksource-5 and

      gir1.2-webkit-6.0 to Build-Depends: the upstream pytest suite

      imports them at collection time, which a clean sbuild chroot

      caught but an already-populated dev machine did not

    - Refresh Build-Depends/Depends/Recommends/Suggests for the GTK4

      rewrite (gir1.2-gtk-4.0, gir1.2-adw-1, gir1.2-gtksource-5,

      gir1.2-webkit-6.0, python3-jsonpath-ng, gir1.2-spelling-1,

      gir1.2-vte-3.91, python3-m2r2, python3-pygments, python3-pynvim)

    - Drop the X-Python3-Version field (lintian

      drop-python-version-declaration)

  * debian/rules: simplify to compat 14 style (execute_after_dh_install),

    run the upstream pytest suite during build (dh_auto_test)

  * debian/copyright: refresh copyright years, add Upstream-Contact

  * debian/patches:

    - Drop webkit4.1.patch, obsoleted by the upstream rewrite of

      formiko/renderer.py

    - Add appstream-id-consistency.patch to align the desktop entry

      and metainfo file basenames with the AppStream component id

      (cz.zeropage.Formiko), fixing appstream-metadata-validation-failed




Build and test status:

  Verified with a clean sbuild chroot (mmdebstrap + sbuild

  --chroot-mode=unshare, dist=unstable): build succeeds, upstream

  pytest suite passes (224 passed, 1 skipped), lintian clean (worst

  tag: warn, only expected missing-upstream-signature notices).




Regards,

 Ondřej Tůma

Hello,

Please address this Lintian output on your next upload:

Running lintian...
N:
W: formiko source: debian-watch-could-verify-download debian/upstream/signing-key.asc [debian/watch]
N:
N:   One or more upstream signing keys are present in the Debian package but
N:   are not being used.
N:
N:   Please enable the cryptographic verification of downloads with the
N:   "pgpsigurlmangle" option in your watch file or remove the key.
N:
N:   Please refer to the uscan(1) manual page for details.
N:
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/watch
N:
N:
W: formiko source: orig-tarball-missing-upstream-signature formiko_2.0.0.orig.tar.gz
N:
N:   The packaging includes an upstream signing key but the corresponding .asc
N:   signature for one or more source tarballs are not included in your
N:   .changes file.
N:
N:   Please ensure a <package>_<version>.orig.tar.<ext>.asc file exists in the
N:   same directory as your <package>_<version>.orig.tar.<ext> tarball prior to
N:   dpkg-source --build being called.
N:
N:   If you are repackaging your source tarballs for Debian Free Software
N:   Guidelines compliance reasons, ensure that your package version includes
N:   dfsg or similar.
N:
N:   Sometimes, an upstream signature must be added for an orig.tar.gz that is
N:   already present in the archive. Please include the upstream sources again
N:   with dpkg-genchanges -sa while the signature is also present. Your upload
N:   will be accepted as long as the new orig.tar.gz file is identical to the
N:   old one.
N:
N:   Please refer to Bug#954743 and Bug#872864 for details.
N:
N:   Visibility: warning
N:   Show-Always: no
N:   Check: upstream-signature
N:
N:
I: formiko source: missing-prerequisite-for-pyproject-backend setuptools.build_meta (does not satisfy python3-setuptools:any, pybuild-plugin-pyproject:any) [pyproject.toml:3]
N:
N:   pybuild now supports building with PEP-517 standard interfaces natively.
N:   These sources could be built using pybuild's generic pyproject plugin and
N:   the named build backend.
N:
N:   Please declare both named prerequisites in Build-Depends. You will need
N:   both the generic pybuild-plugin-pyproject as well as the specific one to
N:   the named backend. It is usually python3-${backend}.
N:
N:   No changes are required if you are using pybuild's dedicated flit plugin,
N:   although that plugin will eventually be deprecated in favor of the generic
N:   pyproject plugin mentioned above.
N:
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python
N:
N:
I: formiko source: older-debian-watch-file-standard 4 [debian/watch]
N:
N:   The version= line in the debian/watch file in this package declares an
N:   older version. Please upgrade when you have a chance.
N:
N:   Please refer to the uscan(1) manual page for details.
N:
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/watch/standard
N:
N:
I: formiko: package-installs-legacy-python-egg-info [usr/lib/python3/dist-packages/formiko-2.0.0.egg-info/PKG-INFO]
N:
N:   The package installs .egg-info directory. The modern replacement for
N:   .egg-info is .dist-info. That means the package was possibly built using
N:   the deprecated setup.py install mechanism. This should be usually
N:   converted to pybuild-plugin-pyproject.
N:
N:   Please refer to Bug#1121735,
N:   https://wiki.debian.org/Python/PybuildPluginPyproject, and
N:   https://setuptools.pypa.io/en/stable/history.html#setup-install-deprecation-note
N:   for details.
N:
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python
N:
N:
I: formiko: package-installs-legacy-python-egg-info [usr/lib/python3/dist-packages/formiko-2.0.0.egg-info/]
N:
I: formiko: package-installs-legacy-python-egg-info [usr/lib/python3/dist-packages/formiko-2.0.0.egg-info/dependency_links.txt]
N:
I: formiko: package-installs-legacy-python-egg-info [usr/lib/python3/dist-packages/formiko-2.0.0.egg-info/entry_points.txt]
N:
I: formiko: package-installs-legacy-python-egg-info [usr/lib/python3/dist-packages/formiko-2.0.0.egg-info/requires.txt]
N:
I: formiko: package-installs-legacy-python-egg-info [usr/lib/python3/dist-packages/formiko-2.0.0.egg-info/top_level.txt]
N:
P: formiko source: redundant-priority-optional-field [debian/control:3]
N:
N:   This package currently sets the Priority field in the debian/control file
N:   to "optional".
N:
N:   As of dpkg version 1.22.13, this field is set to "optional" by default. As
N:   such, in this case the Priority field is redundant and should be removed.
N:
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/control/field/priority
N:
N:
P: formiko source: redundant-rules-requires-root-no-field [debian/control:22]
N:
N:   This package currently sets the Rules-Requires-Root field in the
N:   debian/control file to "no".
N:
N:   As of dpkg version 1.22.13, this field is set to "no" by default. As such,
N:   in this case the Rules-Requires-Root field is redundant and should be
N:   removed.
N:
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/control/field/rules-requires-root
N:
N:
X: formiko source: debian-watch-does-not-check-openpgp-signature [debian/watch]
N:
N:   This watch file does not specify a means to verify the upstream tarball
N:   using a cryptographic signature.
N:
N:   If upstream distributions provides such signatures, please use the
N:   pgpsigurlmangle options in this watch file's opts= to generate the URL of
N:   an upstream OpenPGP signature. This signature is automatically downloaded
N:   and verified against a keyring stored in debian/upstream/signing-key.asc
N:
N:   Of course, not all upstreams provide such signatures but you could request
N:   them as a way of verifying that no third party has modified the code after
N:   its release (projects such as phpmyadmin, unrealircd, and proftpd have
N:   suffered from this kind of attack).
N:
N:   Please refer to the uscan(1) manual page for details.
N:
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/watch
N:   Renamed from: debian-watch-does-not-check-gpg-signature
N:   debian-watch-may-check-gpg-signature
N:   This tag is experimental.
N:

I: Lintian run successful (worst tag: warn)

Otherwise, enjoy:

$ dput ftp-master ../formiko_2.0.0-1_source.changes
Uploading formiko using ftp to ftp-master (host: ftp.upload.debian.org; directory: /pub/UploadQueue/)
running allowed-distribution: check whether a local profile permits uploads to the target distribution
running protected-distribution: warn before uploading to distributions where a special policy applies
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running gpg: check GnuPG signatures before the upload
Uploading formiko_2.0.0-1.dsc
Uploading formiko_2.0.0.orig.tar.gz
Uploading formiko_2.0.0-1.debian.tar.xz
Uploading formiko_2.0.0-1_source.buildinfo
Uploading formiko_2.0.0-1_source.changes

Best regards,
Simon Quigley
tsimonq2@debian.org