Dear mentors,

I am looking for a sponsor for my package "python-tpm":

  * Package name     : python-tpm
    Version          : 5.0.1-1
    Upstream contact : Andreas Hubert <peshay@me.com>
  * URL              : https://github.com/peshay/tpm
  * License          : Expat
  * Vcs              :
https://salsa.debian.org/python-team/packages/python-tpm
    Section          : python

The source builds the following binary packages:

   python3-tpm - Python Module for TeamPasswordManager API

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/python-tpm/

Alternatively, you can download the package with 'dget' using this command:

   dget -x
https://mentors.debian.net/debian/pool/main/p/python-tpm/python-tpm_5.0.1-1.dsc

Changes for the initial release:

  python-tpm (5.0.1-1) UNRELEASED; urgency=medium
  .
    * Initial release. (Closes: #1143817: ITP: python-tpm -- Python module
      for TeamPasswordManager API)

The project is in Salsa under the Python Team (of which I am a member),
and the pipeline was successful:
- https://salsa.debian.org/python-team/packages/python-tpm
-
https://salsa.debian.org/python-team/packages/python-tpm/-/pipelines/1149766

This is my third upload, and I appreciate any feedback if there is
anything to improve on. The others are also under the Python team
umbrella and have pending RFS:
- python-petl: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1144194
- deepl: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1144220

Thanks in advance!

I'm happy to sponsor, quick review:

- Shorten d/changelog to just say '(Closes: #1143817)' IMHO

- LICENSE file says 'Copyright (c) 2015 peshay' but not d/copyright

- tpm.py file says 'copyright: (c) 2022 by Andreas Hubert' but
  d/copyright has more years and doesn't list that file separately.

- Drop 'Priority: optional' from d/control

- Drop 'Depends: ${misc:Depends}' from d/control due to compat 14;
  I'm not sure ${python3:Depends} is still needed too, anyone else?

- I would drop the # lines in d/rules

/Simon

Lester Guerzon <lester@guerzon.net> writes:

No foo:Depends is needed (and many other similar substvars too, the v14
entry in debhelper-compat-upgrade-checklist(7) has the full list, though
some may be still needed due to quirks, one known problem is
${sphinxdoc:Built-Using}, see #1140736).

Andrey Rakhmatullin <wrar@debian.org> writes:

But misc:Depends is okay to remove, right?

           -       The   dh_gencontrol   tool   now    automatically    applies
                   relationship  substvars  to relevant fields. That means that
                   many substvars such as ${misc:Depends} and ${shlibs:Depends}
                   no longer need to be explicitly mentioned in debian/control.

/Simon

There is no comma in "No foo:Depends is needed" ":)

Thanks both for the inputs.

Hi Simon,

 > - Shorten d/changelog to just say '(Closes: #1143817)' IMHO

Done.

 > - LICENSE file says 'Copyright (c) 2015 peshay' but not d/copyright
 >
 > - tpm.py file says 'copyright: (c) 2022 by Andreas Hubert' but
   d/copyright has more years and doesn't list that file separately.

I have adjusted d/copyright to match these strings. I hope this is the
right approach.

 > - Drop 'Priority: optional' from d/control

 > - Drop 'Depends: ${misc:Depends}' from d/control due to compat 14;
 >   I'm not sure ${python3:Depends} is still needed too, anyone else?
 >
 > - I would drop the # lines in d/rules

Done, and thanks for the sponsorship! I have uploded the changes to mentors.

Thanks.

I made the NEW upload, and pushed the final release git commit with tag
to Salsa.

/Simon

Lester Guerzon <lester@guerzon.net> writes: