Dear maintainer,

I suggest removing fbb from Debian for the following reasons:
 * It accumulated one RC-bug:
   + #1091298: fbb: FTBFS on armhf: satupdat.c:664:38: error: passing argument 1 of ‘time’ from incompatible pointer type [-Wincompatible-pointer-types]
     Last modified: 1 year, 26 days

 * It is not part of trixie or forky and is not a key package.

This bug serves as a pre-removal warning. After one month, the bug will be
reassigned to ftp.debian.org to actually request removal of the package.

In case the package should be kept in unstable, please evaluate each of the
RC-bugs listed above.
 * If the bug is meant to permanently prevent the package from entering testing
   or a stable release, but this package should stay part of unstable, please
   add a usertag:

       user helmutg@debian.org
       usertags NNN + sidremove-ignore

 * If the bug no longer applies, please close it. If it is closed, check
   whether the fixed version is correct and adjust if necessary.

 * Is the bug really release-critical? If not, please downgrade.

 * If the bug still applies, please send a status update at least once a year.

Once all of the mentioned RC bugs have been acted upon in one way or another,
please close this bug.

In case the package should be removed from unstable, you may reassign this
bug report:

    Control: severity -1 normal
    Control: retitle -1 RM: fbb -- RoM; rc-buggy
    Control: reassign -1 ftp.debian.org
    Control: affects -1 + src:fbb

Alternatively, you may wait a month and have it reassigned.

In case you disagree with the above, please add a wontfix tag to this bug.

    Control: tags -1 + wontfix

Doing so will also prevent automatic reassignment.

Kind regards

A tool for automatically removing packages from unstable

This bug report has been automatically filed with little human intervention.
If the filing is unclear or in error, don't hesitate to contact
Helmut Grohne <helmut@subdivi.de> for assistance.

Re: Helmut Grohne

+1 from me.

Christoph

Dear Debian Hamradio maintainers,

I am writing about the pre-removal warning for src:fbb (bug #1147109),
and about the release-critical bug that triggered it, #1091298 (FTBFS on
armhf: satupdat.c, "passing argument 1 of 'time' from incompatible
pointer type").

First, a disclosure: I am not the current maintainer of LinFBB. The
maintainer of record, as listed in the AUTHORS file and in configure.ac
of the sources, is Dave van der Locht.
However, the code affected by #1091298 (satupdat and ajoursat) is code I
wrote, and I did not want to see the package removed from Debian because
of it.
I therefore felt obliged to fix it, and to publish a new upstream
release containing the recent corrections. I hope this is welcome.

LinFBB 7.0.12 is now published:

  - Source tarballs fbb-7.0.12.tar.gz and fbb-7.0.12.tar.bz2 are in the
root of the Files area of the linfbb project on SourceForge, next to
fbb-7.0.11.tar.gz.
  Their names match the existing debian/watch pattern; with the current
uversionmangle rule, uscan should report the version as 7.012.
  - The SVN tag is tags/7.0.12 (revision 259, copied from trunk revision
258).

SHA-256 checksums:

  43c8189000d617d7618608db362466b37053da373e1c89d3f10ecb31f7d1a410
fbb-7.0.12.tar.gz
  23050ae7537c58876641c6bdcaa24cd522a98354db5970d9a9b9d04d73e02d77
fbb-7.0.12.tar.bz2

About #1091298: the variables passed to time() in satupdat.c and
ajoursat.c are now declared as time_t instead of long (the fix has been
in trunk since revision 241, well before this release).
The armhf failure came from time_t being 64-bit while the variable was a
32-bit long. I could test the patch on RaspBerry Pi armhf with OS 32 bit
myself.
The tarball builds cleanly from a fresh configure && make on amd64 with
GCC 15.2.

Other changes since 7.0.11, for the changelog: satel.dat is no longer
created with mode 0700 by satupdat/ajoursat; support for the Alpha-5
satellite catalogue numbers (NORAD numbers of 100000 and above); a fix
for an undefined-behaviour call in crcdix(); xfbbC documentation fixes;
and the build time added to the xfbbd/xfbbC banners. The full list is in
the ChangeLog of the tarball.

The existing Debian patches (for example 02-remove-SVNREV and
08-statedir) may need to be refreshed against 7.0.12.

Would it be possible to update the package to 7.0.12? If so, this should
close #1091298, and the removal request in #1147109 would no longer apply.
In the meantime, could the removal be put on hold? I am happy to help
with testing or with any change needed on the upstream side.

Thank you for your time and for maintaining fbb in Debian.

Best regards,

Bernard Pidoux, F6BVP / AI7BG
bernard.f6bvp@gmail.com

Re: Bernard F6BVP / AI7BG

Hi Bernard,

thanks for the new version, I just uploaded it.

IMHO the immediate reason for removal is moot now.

Whether this also means fbb will be viable long-term is a different
question, though. The The last upstream release before this (7.011)
was from 2022. Let's see...

Thanks,
Christoph DF7CB

Re: To Bernard F6BVP / AI7BG

Well, it's unfortunately still broken in the same way:

arm-linux-gnueabihf-gcc -DHAVE_CONFIG_H -I. -I..  -I../include -Wstrict-prototypes -funsigned-char -DPROTOTYPES -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/fbb-7.012=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -c -o autobin.o autobin.c
xfbbd.c: In function ‘fbb_list’:
xfbbd.c:603:44: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Wincompatible-pointer-types]
  603 |                         sdate = localtime (&(svoie[i]->debut));
      |                                            ^~~~~~~~~~~~~~~~~~
      |                                            |
      |                                            long int *
In file included from /usr/include/features.h:539,
                 from /usr/include/dirent.h:25,
                 from ../include/serv.h:32,
                 from xfbbd.c:26:
/usr/include/time.h:150:19: note: expected ‘const time_t *’ {aka ‘const long long int *’} but argument is of type ‘long int *’
  150 | extern struct tm *__REDIRECT_NTH (localtime, (const time_t *__timer),
      |                   ^~~~~~~~~~~~~~
make[5]: *** [Makefile:892: xfbbd-xfbbd.o] Error 1

https://buildd.debian.org/status/fetch.php?pkg=fbb&arch=armhf&ver=7.012-1&stamp=1790020300&raw=0

Christoph

  Hi Christoph,

  Sorry about that -- you were right, 7.0.12 only fixed the long/time_t
  mismatch in the two files the original ticket pointed at
  (satupdat.c/ajoursat.c). I hadn't checked the rest of the tree.

  I've now gone through every call to time()/localtime()/gmtime()/
  ctime()/mktime()/difftime() in the whole source (63 call sites) and
  fixed the 27 more that had the same bug across 22 files: local
  variables, several date/time helper functions taking a "long"
  parameter instead of "time_t" (strdate, strdt, jour, heure, minute
  and others in variable.c, plus file-local duplicates in
  epurmess.c/epurwp.c), and two fields (debut, messdate) in the
  connection-state structure that xfbbd.c itself reads. Nothing that
  gets written to or read from disk was touched, only in-memory state.

  This is now released as 7.0.13, SVN tag tags/7.0.13 (revision 262).

  Before writing this, I reproduced your failure and then the fix: a
  full autoreconf/configure/make from a clean checkout on a real
  Debian 13 (Trixie) armv7l Raspberry Pi -- glibc 2.41, 64-bit time_t
  on armhf, the same ABI as your buildd. Clean build, zero errors, zero
  warnings, xfbbd included. I also rebuilt it on amd64/x86_64 to make
  sure nothing regressed there: same set of pre-existing
  -Wformat-overflow warnings as 7.0.12 (unrelated to this bug), no new
  ones.

  Source tarballs fbb-7.0.13.tar.gz and fbb-7.0.13.tar.bz2 are in the
  root of the Files area of the linfbb project on SourceForge, same
  place as 7.0.12:
https://sourceforge.net/projects/linfbb/files/

  SHA-256 checksums:

   78f745a43120842433e9ea3ac32a61da77c999206e07107ffa1d38c9ab1cd522
  fbb-7.0.13.tar.gz
   f6b92c71fb26b85b4e5a9cfcdf3d62f3be349b9916189544a8a474e2a190dc6c
  fbb-7.0.13.tar.bz2

  Thanks for catching the incomplete fix rather than just reverting to
  removal, and sorry for the extra round trip.

  place as 7.0.12:
https://sourceforge.net/projects/linfbb/files/

  SHA-256 checksums:

   78f745a43120842433e9ea3ac32a61da77c999206e07107ffa1d38c9ab1cd522
fbb-7.0.13.tar.gz
   f6b92c71fb26b85b4e5a9cfcdf3d62f3be349b9916189544a8a474e2a190dc6c
fbb-7.0.13.tar.bz2
  SHA-256 checksums:

   78f745a43120842433e9ea3ac32a61da77c999206e07107ffa1d38c9ab1cd522
fbb-7.0.13.tar.gz
   f6b92c71fb26b85b4e5a9cfcdf3d62f3be349b9916189544a8a474e2a190dc6c
fbb-7.0.13.tar.bz2

  Thanks for catching the incomplete fix rather than just reverting to
  removal, and sorry for the extra round trip.

  73,
  Bernard, F6BVP


Le lun. 21 sept. 2026 à 22:16, Christoph Berg <myon@debian.org> a écrit :