* Package name    : python-locationsharinglib
  Version         : 5.0.3
  Upstream Author : Costas Tyfoxylos <costas.tyf@gmail.com>
* URL             : https://github.com/costastf/locationsharinglib
* License         : MIT
  Programming Lang: Python
  Description     : library for retrieving shared locations from Google Maps

  This library uses exported Google account cookies to access locations shared
  with that account through Google Maps. It provides coordinates, timestamps,
  addresses and location accuracy, along with battery level and charging status
  when available. People and their coordinates can be retrieved by full name or
  nickname.

This library is a dependancy of Home Assistant, the Python smart home platform.
I plan to maintain it as part of the Home Assistant team.

The Debian NEW review of python-locationsharinglib 5.0.3-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

Some pedantica packaging issues you might want to review...

Packaging quality

1. pybuild-plugin-pyproject declared but no pyproject.toml exists.

debian/control:11 depends on pybuild-plugin-pyproject, yet the tarball has only legacy setup.py/setup.cfg (no pyproject.toml anywhere). The plugin is unused/inconsistent with the actual build system.

2. override_dh_auto_test is empty (debian/rules:10-11)

it contains only a comment and never calls dh_auto_test, so the test suite is silently skipped. The rationale comment ("only an empty test scaffold") is only roughly accurate: tests/test_locationsharinglib.py does define a BetamaxTestCase class, just with no test methods. Combined with the <!nocheck> test-only Build-Depends (betamax, pytest, cachetools, coloredlogs, pytz) that are then never exercised, this means autopkgtest-pkg-python runs nothing meaningful.

3. Docs build isn't gated on nodoc.

debian/rules:8 unconditionally runs sphinx-build, while the sphinx/rtd-theme Build-Depends are marked <!nodoc> (debian/control:21-22). Building with dpkg-buildpackage -Pnodoc would still attempt the docs build and fail.

4. _version.py fallback is incomplete (minor).

The Debian patch (debian/patches/dgit-changes) adds from importlib.metadata import version and catches only FileNotFoundError before it. When no .VERSION is present and the package isn't installed as a distribution, version('locationsharinglib') raises PackageNotFoundError (uncaught). Fine in the Debian-installed case, but fragile.


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/python-locationsharinglib

We believe that the bug you reported is fixed in the latest version of
python-locationsharinglib, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1149358@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Edward Betts <edward@4angle.com> (supplier of updated python-locationsharinglib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 29 Sep 2026 16:45:48 +0100
Binary: python3-locationsharinglib
Source: python-locationsharinglib
Architecture: all source
Version: 5.0.3-1
Distribution: unstable
Urgency: medium
Maintainer: Home Assistant Team <team+homeassistant@tracker.debian.org>
Changed-By: Edward Betts <edward@4angle.com>
Closes: 1149358
Description:
 python3-locationsharinglib - library for retrieving shared locations from Google Maps
Changes:
 python-locationsharinglib (5.0.3-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1149358)
Checksums-Sha1:
 4ff3e383fa3272baadadcb4ca7171d106b7b2fab 2681 python-locationsharinglib_5.0.3-1.dsc
 f35f040a152c997baba8b69ad41d8b0ea520cedd 55904 python-locationsharinglib_5.0.3.orig.tar.xz
 5c751ef9d3a4f571713192a9c8da19f587807a56 3436 python-locationsharinglib_5.0.3-1.debian.tar.xz
 d30d7f6f09c0128e06c43b18d75a84947d96980e 7662 python-locationsharinglib_5.0.3-1_amd64.buildinfo
 7f39bc4b1e0f300cdfbb036e7954fd88b4ab1905 34776 python3-locationsharinglib_5.0.3-1_all.deb
Checksums-Sha256:
 c31dcd41198f4284d79ce0e7b5ad39da1a2e1d15f991837a5cb5008481a8f23a 2681 python-locationsharinglib_5.0.3-1.dsc
 f86bab6541fa60a2b7d3c85311afd0936189b3b396a143f8e5df77fce35652f3 55904 python-locationsharinglib_5.0.3.orig.tar.xz
 5f0ef078771a5afdf9fca13a9f0b9f1da7e6377260cad8d778d12e1459409cfd 3436 python-locationsharinglib_5.0.3-1.debian.tar.xz
 d85035112d1b89e2e6ebc3054d15ed98611b78899a42eefc8a83f24f42794b03 7662 python-locationsharinglib_5.0.3-1_amd64.buildinfo
 6089af53e0f24fcbc462008e373b70f180929b811a7d66eb92996dceb480b827 34776 python3-locationsharinglib_5.0.3-1_all.deb
Files:
 6ccba1e7c48b7ca19213a46a2642b7ac 2681 python optional python-locationsharinglib_5.0.3-1.dsc
 35b875fd6b052e434fcbf071369bdd39 55904 python optional python-locationsharinglib_5.0.3.orig.tar.xz
 5f0ee409762bda7bd87945f1b00020f7 3436 python optional python-locationsharinglib_5.0.3-1.debian.tar.xz
 177404edbaf37211f9ca8587f867ff33 7662 python optional python-locationsharinglib_5.0.3-1_amd64.buildinfo
 19c9a33a89fc905991b23b4b1b444582 34776 python optional python3-locationsharinglib_5.0.3-1_all.deb
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+4rPp4xyYInDitAmlgWhCYxjuSoFAmq786AACgkQlgWhCYxj
uSrAAA//QPLuMPdxC/NY/e/URCSpy8sDNPHfj0t4iJZ2p9h9qE+ysiW9mcaXaDbw
CVa7Bmq2EYGxQWOYmjJZvfxrQsv2nrOZuxqFB/GukvLA1vMFkuVP9ziiAHdRZYii
9uJOUaEnnxvep/oeNUPxLWAf0xvYj3iQuE3e/zmJGpT8jSqJRg0yJOYR6CyWbewo
djUlPZI9bTT+vJBXYWcNnjQ12KXKawijo7w+h7zjP/75OH+4gcAOegK63T7fXvrn
ZZRZpjvqrS886Oj+iOU+jQqEjGKH18OlWL0eQ1mtK9XnMHNk4dzbMz8Fvy2wtiAC
sO8QE3COi2OtcvqdVr9WsKLwMCRiuf/y/Lv9ySBpfMsrvyBVh2wEqVkkN3KHFIfm
5y2o532ov+heGhvZFAabkZQrax0ncHDSq3A3LYxfPL+JtvoBUob5YGYFML7mUTgz
vIBMTjOgSGcNepocHNM1XMs7kt4GrLdRITPF5hbvzL4NjnzthZuZXLI6uYKK+zJ9
kCI1asgS+PGfMsS2hKnGIjMfw2V8JMx9GbhAj+bHItW8alrUomxPj788ZOvwjRy3
GrKJn4iAzOXAAqUCw9kiXJwto/s/wsBBRPrzvAgOWtPax71a99paoFlDMLWRJ+Ps
DjH3AynhjEmrhz4o/tDhMe5yRU0vmQqGVK8CotkMeRm4o/iepwA=
=+jid
-----END PGP SIGNATURE-----

Hi Andrew,

I think that using pybuild-plugin-pyproject even where there is no
pyproject.toml
is exactly what the Python team aims for.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027864

Thank you for the detailed review

Greetings

Alexandre