Package: badger
Version: 4.8.0-2
Severity: serious
Tags: ftbfs patch
User: debian-powerpc@lists.debian.org
Usertags: ppc64el
X-Debbugs-Cc: debian-powerpc@lists.debian.org,
glaubitz@physik.fu-berlin.de,
pkg-go-maintainers@lists.alioth.debian.org, ah@debian.org

Dear Maintainer,

Your package badger 4.8.0-2 failed to build on ppc64el on the buildd
with below build log:

https://buildd.debian.org/status/fetch.php?pkg=badger&arch=ppc64el&ver=4.8.0-2&stamp=1787222603&raw=0

With below error:

--- PASS: TestAllocatorReuse (3.00s)
PASS
ok  	github.com/dgraph-io/badger/y	3.046s
    debian/rules execute_after_dh_auto_test
make[1]: Entering directory '/build/reproducible-path/badger-4.8.0'
# intermittent test failure? Failing explicitly. See #1078496
echo "Test failure on ppc64el, see https://bugs.debian.org/1078496"
Test failure on ppc64el, see https://bugs.debian.org/1078496
exit 1
make[1]: *** [debian/rules:20: execute_after_dh_auto_test] Error 1
make[1]: Leaving directory '/build/reproducible-path/badger-4.8.0'
make: *** [debian/rules:8: binary-arch] Error 2
dpkg-buildpackage: error: debian/rules binary-arch subprocess failed
with exit status 2



The build fails only because exit 1 fires unconditionally after all the
tests pass.
It's because of workaround added for bug #1078496. See


debian/rules contains a workaround added for #1078496:

   ifneq (,$(filter $(DEB_TARGET_ARCH), ppc64el))
   ifeq (,$(filter $(DEB_BUILD_OPTIONS), nocheck))
   execute_after_dh_auto_test:
           # intermittent test failure? Failing explicitly. See #1078496
           echo "Test failure on ppc64el, see
https://bugs.debian.org/1078496"
           exit 1
   endif
   endif

The underlying bug (#1078496) is fixed in Go >= 1.26.6.
Debian sid ships Go 1.26.8. All tests pass on ppc64el LPAR.

cd skl
go test -v -count=10 -run TestConcurrentBasicBigValues
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.15s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.15s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.18s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.15s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.14s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.17s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.17s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.14s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.16s)
=== RUN   TestConcurrentBasicBigValues
--- PASS: TestConcurrentBasicBigValues (0.17s)
PASS
ok  	github.com/dgraph-io/badger/v4/skl	1.608s


cd ../table
go test -v -count=10 -run TestTableBigValues
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.68s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.67s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.55s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.70s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.74s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.68s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.57s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.56s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.58s)
=== RUN   TestTableBigValues
--- PASS: TestTableBigValues (0.59s)
PASS
ok  	github.com/dgraph-io/badger/v4/table	6.434s


Fix: remove the workaround block from debian/rules (patch is attached).
After this I will create MR for same on salsa for easy review.

I have tested it on ppc64el system badger package builds successfully
with generating files badger_4.8.0-2_ppc64el.deb,
badger-dbgsym_4.8.0-2_ppc64el.deb and
golang-github-dgraph-io-badger-dev_4.8.0-2_all.deb


Regards,
-- 
   Trupti Shirsat
   trupti@linux.ibm.com