* Package name    : ocaml-checkseum
  Version         : 0.5.4
  Upstream Contact: Romain Calascibetta
* URL             : https://github.com/mirage/checkseum
* License         : MIT, Zlib
  Programming Lang: C, OCaml
  Description     : Adler-32, CRC32 and CRC32-C implementation in C and OCaml

 Checkseum is a library to provide implementation of Adler-32, CRC32
 and CRC32-C in C and OCaml.
 .
 This library use the linking trick to choose between the C
 implementation (checkseum.c) or the OCaml implementation
 (checkseum.ocaml). This library is on top of optint to get the best
 representation of an int32.

This package is a new (transitive) dependency of opam. It will be
maintained in the OCaml team.

This is an automated message from the Debian DFSG, Licensing & New
Packages Team.

The Debian NEW review of ocaml-checkseum 0.5.4-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

One important issue you should please fix in your next upload, the other at your option...

1. [important] [licensing] `Files:` glob uses brace expansion, so the zlib stanza matches no file

 - Files: `debian/copyright:7`
 - Evidence: `Files: src-c/native/{adler32,crc32}.c`; the copyright-format 1.0 spec (§6.9) admits only `*`, `?` and the `\` escape as pattern syntax (`[]` are explicitly *not* recognized), so `{}` has no special meaning and the pattern is literal.
 - Problem: The pattern matches no path in the tree, so `adler32.c` and `crc32.c` -- whose in-file headers say `Copyright (C) 1995-2016 Mark Adler` / zlib (`for conditions of distribution and use, see copyright notice in zlib.h`) -- are instead matched by the earlier `Files: *` stanza and recorded under `Copyright: 2014, Romain Calascibetta` and `License: MIT`. debian/copyright therefore states the wrong holder and the wrong licence for the only zlib files. It is not a DFSG violation (the files remain under a free, compatible licence and the full zlib text is already reproduced), but the record is inaccurate and an automated per-file comparison (e.g. licensecheck) would flag the mismatch.
 - Fix: List the two files without braces, e.g. `Files: src-c/native/adler32.c src-c/native/crc32.c` (or one stanza per file), so the Mark Adler / Zlib stanza actually applies.

2. [minor] [packaging] -dev package installs the upstream debug CLI via a bare `usr/bin` line; no man page

 - Files: `debian/libcheckseum-ocaml-dev.install`
 - Evidence: The file is exactly `usr/bin`; `bin/dune` has `(executable (name main) (public_name checkseum.checkseum))`; CHANGES.md (v0.2.0) calls the tool "used only for debugging".
 - Problem: A single-item install line makes dh_install guess its destination, copying the whole `usr/bin` directory (the dune-built `checkseum` CLI) into `libcheckseum-ocaml-dev`; a /usr/bin program in a library -dev package is an unusual placement and, per Policy 12.1, it should come with a man page, which is not shipped anywhere in the package. The line only resolves if dh-ocaml's dune install stages `bin/` under `debian/tmp`; a build should confirm the resulting binary name and path.
 - Fix: Confirm at build time that the binary is found and what it is named; if the CLI is kept, add a man page or relocate/ship it more appropriately -- or drop the line entirely since the tool is debug-only.

Full review details: https://dfsg-new-queue.debian.org/reviews/ocaml-checkseum

We believe that the bug you reported is fixed in the latest version of
ocaml-checkseum, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1150428@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stéphane Glondu <glondu@debian.org> (supplier of updated ocaml-checkseum package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Fri, 09 Oct 2026 16:32:23 +0200
Source: ocaml-checkseum
Binary: libcheckseum-ocaml libcheckseum-ocaml-dbgsym libcheckseum-ocaml-dev libcheckseum-ocaml-dev-dbgsym
Architecture: source amd64
Version: 0.5.4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Stéphane Glondu <glondu@debian.org>
Description:
 libcheckseum-ocaml - Adler-32, CRC32 and CRC32-C implementation in C and OCaml (runtim
 libcheckseum-ocaml-dev - Adler-32, CRC32 and CRC32-C implementation in C and OCaml (dev)
Closes: 1150428
Changes:
 ocaml-checkseum (0.5.4-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1150428)
Checksums-Sha1:
 1b9d3e49781eb5a41ccc4f17c08892b75cfc6d48 2053 ocaml-checkseum_0.5.4-1.dsc
 06b310d74cb0b948299fa379c2abc3276d8dba46 60790 ocaml-checkseum_0.5.4.orig.tar.bz2
 bdf889d2ffe4fe624fdd257b1150ccf14912294e 2828 ocaml-checkseum_0.5.4-1.debian.tar.xz
 a8ffc23c520e7e626bfaf07be20a5c9092d72c7f 23188 libcheckseum-ocaml-dbgsym_0.5.4-1_amd64.deb
 1f4b1285be05daadd8258bb3e7fbad96ddc44633 132568 libcheckseum-ocaml-dev-dbgsym_0.5.4-1_amd64.deb
 1e7f5efc1f032ba08d880f6161a6faf465a71202 491992 libcheckseum-ocaml-dev_0.5.4-1_amd64.deb
 74b2647fd348b442066d6279ee994d5b3c335a88 63636 libcheckseum-ocaml_0.5.4-1_amd64.deb
 c3d7fbf300ac65914fb269ee4a8fecc2fd5c9dbd 9541 ocaml-checkseum_0.5.4-1_amd64.buildinfo
Checksums-Sha256:
 2f342793ba871a4c094c6c55b431871e8c91003fa3c68baa3c05ef2fdf5e57c1 2053 ocaml-checkseum_0.5.4-1.dsc
 09f96d50dbd74e87ca46a0be5efbe53f5f88dab0054f3d0ff9040f80e916a7f0 60790 ocaml-checkseum_0.5.4.orig.tar.bz2
 aa2bfe96ff08e584aeb553331e08b26a4c5864e898d64e8abbb35c1925232469 2828 ocaml-checkseum_0.5.4-1.debian.tar.xz
 98e99ba0dba5a4fdb15ae23f6782e17e368177de9db0e198fb0e54ca95444e9a 23188 libcheckseum-ocaml-dbgsym_0.5.4-1_amd64.deb
 be109b853cdc8f40b18610ff45cd629c81e1c4110161984986f2a4b12ff72315 132568 libcheckseum-ocaml-dev-dbgsym_0.5.4-1_amd64.deb
 04810a7a83a16b197d9425b35e5230f6d12959c84cb17649720b600caf23ffa2 491992 libcheckseum-ocaml-dev_0.5.4-1_amd64.deb
 ac961e8f6c0bd000d275c4ff8ea5d0449a05264b3c10089c0f32eddd159f25d6 63636 libcheckseum-ocaml_0.5.4-1_amd64.deb
 72bcd2219cf327ea257bad7c061387e634c929b87cbffb2d694c46eadc080f99 9541 ocaml-checkseum_0.5.4-1_amd64.buildinfo
Files:
 6188cddcbc9661bb54deb992596ebc0a 2053 ocaml optional ocaml-checkseum_0.5.4-1.dsc
 7759bc5b0a465d4836ed299c79639c41 60790 ocaml optional ocaml-checkseum_0.5.4.orig.tar.bz2
 d062ac80f9d0e343dfd9cf23932a78fe 2828 ocaml optional ocaml-checkseum_0.5.4-1.debian.tar.xz
 3514f406758b691577a405bc37231c9f 23188 debug optional libcheckseum-ocaml-dbgsym_0.5.4-1_amd64.deb
 866eabc1d349186a51991c96eb2fd1b5 132568 debug optional libcheckseum-ocaml-dev-dbgsym_0.5.4-1_amd64.deb
 c39e6d6958df1dbde4e547e729e57815 491992 ocaml optional libcheckseum-ocaml-dev_0.5.4-1_amd64.deb
 8f2a60c40348ed67696016d53ed7c04f 63636 ocaml optional libcheckseum-ocaml_0.5.4-1_amd64.deb
 af6b47e7c341c44be2e4846e526cf4fd 9541 ocaml optional ocaml-checkseum_0.5.4-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQFGBAEBCgAwFiEEbeJOl+yohsxW5iUOIbju8bGJMIEFAmrI+6ESHGdsb25kdUBk
ZWJpYW4ub3JnAAoJECG47vGxiTCB3EIH/iKX8g5gu98ZOYrWsIN/LK/smJvbNPDk
lU+p5U32VWLZUJBvSugO6PWOU38aw/405yfKvX+oMnD53Uh/8o6NWzrAuuKAJ9eg
q7upohdMfwbpMKyGz5MP0AAqvuhHLoXLIgmOrUL687BcE9WfJa1DXhgz8sFlOoXI
FYifUKrRPVcnw4WQ4lVOpwYx3U5bDaY+nq6yr/ewfKfL5NNaqrD+17E5Mo3896iO
jDg1cL2xUXSYN5nrg3kNlO+qmGwr7urNesaeEIxwQqgWFaMsqyRKBIh3hoOti17v
w/CV+9rjGG9fn+Up+k89+oajp56Y+e+Rx4RQ8RLhkiko4EBEaPqtSYs=
=3/im
-----END PGP SIGNATURE-----