package: diffoscope
severity: serious
version: 335

ends with

dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.15 3.14" --parallel=6 returned exit code 13
make: *** [debian/rules:35: binary-indep] Error 25
dpkg-buildpackage: error: debian/rules binary-indep subprocess failed with exit status 2

Holger Levsen wrote:

[..]

Actual error bit is:

=================================== FAILURES ===================================

E         - package/services/metadata/core-properties/b44ebb537bbf4983b9527f9e3820fda6.psmdcp
E         + lib/net8.0/ClassLibrary.dll

nupkg_differences = [<Difference zipinfo {} -- zipinfo {} []>,
 <Difference zipnote «TEMP»/diffoscope_iv7cei5b_/tmpzy42hiej_.zip -- zipnote «TEMP»/diffoscope_iv7cei5b_/tmpzy42hiej_.zip []>,
 <Difference zipdetails --redact --walk --utc {} -- zipdetails --redact --walk --utc {} []>,
 <Difference _rels/.rels -- _rels/.rels [<Difference _rels/.rels -- _rels/.rels []>]>,
 <Difference ClassLibrary.nuspec -- ClassLibrary.nuspec [<Difference ClassLibrary.nuspec -- ClassLibrary.nuspec []>]>,
 <Difference lib/net8.0/ClassLibrary.dll -- lib/net8.0/ClassLibrary.dll [<Difference pedump {} -- pedump {} []>]>]

tests/comparators/test_zip.py:163: AssertionError
=================================== XPASSES ====================================

Chris Lamb wrote:

Just spent a little while on this and the cause is evading me. Could a change to
Python or some XML parser caused this? It fails regardless of whether I run it in
sid, forky and trixie, and it also fails even if I go back in time and run a Git
tag from 5 or 6 months ago — none of the code around this has changed.

FWIW, diffoscope 335 does build fine on recent guix, including that
specific test passing.

Obviously, guix contains a whole different set of toolchain versions,
but the code is not *fundamentally* broken, at least...

live well,
  vagrant

Vagrant Cascadian wrote:

Could you quickly run/apply this diff? :)  Would be useful to know what
"should" be there…

--- tests/comparators/test_zip.py
+++ tests/comparators/test_zip.py
@@ -160,6 +160,13 @@ def test_nupkg_metadata(nupkg_differences, nupkg1, nupkg2):

 @skip_unless_tools_exist("zipinfo")
 def test_nupkg_compressed_files(nupkg_differences):
+    for idx, x in enumerate(nupkg_differences):
+        with open(f"nupkg_differences_{idx}.diff", "w") as f:
+            print(f"source1={x.source1!r}", file=f)
+            print(f"source2={x.source2!r}", file=f)
+            print(f"comments={x.comments!r}", file=f)
+            print(f"\n{x.unified_diff}", file=f)
+
     assert (
         nupkg_differences[-1].source1

It should spit out a bunch of small (eg.) nupkg_differences_2.diff files.


Best wishes,