Source: golang-golang-x-tools
Version: 1:0.52.0+ds-1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: sramacher@debian.org

Dear maintainer,

golang-golang-x-tools FTBFS on irscv64:

=== RUN   TestTestFiles
    endtoend_test.go:236: TestTestFiles in: /tmp/TestTestFiles3056085152/001
    endtoend_test.go:246: stringer: starting GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go list -e -f {{context.ReleaseTags}} -- unsafe
        stringer: starting GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go list -tags= -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
        stringer: 92.657025ms for GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go list -e -f {{context.ReleaseTags}} -- unsafe
        stringer: starting GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go list -tags= -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,DepOnly,Imports,ImportMap,TestImports,XTestImports,Export,Module -compiled=true -test=true -export=true -deps=true -find=false -buildvcs=false -pgo=off -tags= -- /tmp/TestTestFiles3056085152/001
        stringer: 129.899035ms for GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go list -tags= -f "{{context.GOARCH}} {{context.Compiler}}" -- unsafe
        stringer: 78.169021ms for GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go list -tags= -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,DepOnly,Imports,ImportMap,TestImports,XTestImports,Export,Module -compiled=true -test=true -export=true -deps=true -find=false -buildvcs=false -pgo=off -tags= -- /tmp/TestTestFiles3056085152/001
        stringer: starting GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go env -json GOMOD GOPATH
        stringer: 70.796019ms for GOROOT= GOPATH=/build/reproducible-path/golang-golang-x-tools-0.52.0+ds/_build GO111MODULE=off GOPROXY=off PWD=/tmp/TestTestFiles3056085152/001 go env -json GOMOD GOPATH
        stringer: no values defined for types: Foo,Bar,Baz
    endtoend_test.go:248: run stringer: /tmp/go-build2526832346/b392/stringer.test -type=Foo,Bar,Baz /tmp/TestTestFiles3056085152/001: exit status 1
--- FAIL: TestTestFiles (2.89s)

See
https://buildd.debian.org/status/fetch.php?pkg=golang-golang-x-tools&arch=riscv64&ver=1%3A0.52.0%2Bds-1&stamp=1792523722&raw=0
for details.

Cheers

control: retitle -1 golang-golang-x-tools: FTBFS on risv64: --- FAIL: TestCancel_ProcessGroup

Hi,

upon investigation, I noticed that the failing test mentioned in this bug
report (TestTestFiles) is expected to fail, the build continues afterwards
without any issue. In fact, that test fails on all architectures, not just
riscv64.

There is another test, however, introduced with the latest upload, which
checks that a process group is killed on cancel.

=== RUN   TestCancel_ProcessGroup
    invoke_unix_test.go:81: child test process did not write PID
--- FAIL: TestCancel_ProcessGroup (16.41s)

See https://go-review.googlesource.com/c/tools/+/830824 for more details and
a rationale.

This test takes quite some time on riscv64 (for compilation and linking),
therefore exceeding the given timeout. I've run this test in a porterbox, it
takes about 90 seconds to complete successfully. I'm now increasing the
timeout on riscv64 to make this test pass.

Regards,
Tobias

Hello,

Bug #1152025 in golang-golang-x-tools reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/go-team/packages/golang-golang-x-tools/-/commit/6f9d2bc2240801372c1b3dac4666ec0d29ef8fa8
------------------------------------------------------------------------
Add patch to fix FTBFS on riscv64.

Closes: #1152025
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1152025

We believe that the bug you reported is fixed in the latest version of
golang-golang-x-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1152025@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dr. Tobias Quathamer <toddy@debian.org> (supplier of updated golang-golang-x-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 28 Oct 2026 17:09:08 +0100
Source: golang-golang-x-tools
Architecture: source
Version: 1:0.52.0+ds-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed-By: Dr. Tobias Quathamer <toddy@debian.org>
Closes: 1152025
Changes:
 golang-golang-x-tools (1:0.52.0+ds-2) unstable; urgency=medium
 .
   * Team upload.
   * Refresh patches
   * Add patch to fix FTBFS on riscv64. (Closes: #1152025)
Checksums-Sha1:
 4412ec552a91b23d283798cb313c28363076a59e 2852 golang-golang-x-tools_0.52.0+ds-2.dsc
 c069ad3e2207276b8df3c88f12a6a069dbb1ddb2 100764 golang-golang-x-tools_0.52.0+ds-2.debian.tar.xz
 b24500257bc5bcc99284355df461a88725ec4418 12480364 golang-golang-x-tools_0.52.0+ds-2.git.tar.xz
 a5d87ba55d3dc2cb7bc420b89d4fe00fe6f254ff 17806 golang-golang-x-tools_0.52.0+ds-2_source.buildinfo
Checksums-Sha256:
 7bec23028ec07a42922fd081d2ac7726271b143c9cf95e2987c1765f65167505 2852 golang-golang-x-tools_0.52.0+ds-2.dsc
 1bfee10945de7d04a1aefb027f79166082878dd9d86bbd35639c3bc528c7b975 100764 golang-golang-x-tools_0.52.0+ds-2.debian.tar.xz
 588c540ddf01474bd5c308e9050678deb18bf07ba3cf54bb5918505843b55576 12480364 golang-golang-x-tools_0.52.0+ds-2.git.tar.xz
 04564070fc4cce8032206b50b92f7b208f3e86a102f21bba3c25f10ad47816b3 17806 golang-golang-x-tools_0.52.0+ds-2_source.buildinfo
Files:
 90f788d21e1e9fb64e7101b5a9b82ba8 2852 golang optional golang-golang-x-tools_0.52.0+ds-2.dsc
 4efe77afa6122d7f662f11134e3ed694 100764 golang optional golang-golang-x-tools_0.52.0+ds-2.debian.tar.xz
 19c59639c9402cee56edbaf109f30495 12480364 golang None golang-golang-x-tools_0.52.0+ds-2.git.tar.xz
 d08f36e1579bb11e604bea1f26d09380 17806 golang optional golang-golang-x-tools_0.52.0+ds-2_source.buildinfo
Git-Tag-Info: tag=65f9c449803037908b4904a55a1906d2cc6bfe33 fp=d1cb8f39bc5ded24c5d2c78c1302f1f036ebeb19
Git-Tag-Tagger: Dr. Tobias Quathamer <toddy@debian.org>
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEN02M5NuW6cvUwJcqYG0ITkaDwHkFAmriH/0ACgkQYG0ITkaD
wHmw1A//ahGv/3ORzQA5+VVvtH9ozeoWqSmw3z6BQ4iS/MuEYtD0bHzUN4krw3qp
YjeKFxEqwXZ9Py/IpmvPBYv7gSxiuhAEb5XwP13L1K9AWcMu0UWUO180UhuV6SZS
1fvnhkJuDROgCdNyEyNk6suzm7g2DfC8UeSmYJEGAPqJL5z4dh4qXjU5PXIDbHsU
zHz6SJ0/XEyzO4453PQmpDHH1Kjr+MhEwsDI9S9yCVImtzVQwU5KoiT21Zl3bnRd
ZTlwhMNp1DgwUh8BUS4ZRHkuglLvZ+WlQ0sKrZ58s2oY2qd2bbWxHcXoVzGTF6Ot
ugvg6dsjZ9/XVoU//OGRnSV70ky5t9r0x9lP2nAit179avEUbfLWXTIsX8Tf3WdK
h3jYN5VY2yYaLSrGt7RiFWbWphjrncuvg3c6QLyLtW35Uha8Hh0VNY6+uvdjpfit
u7J3J5hPJ/eyx0BKRP085gSlK9e3t0hf4+c9B/80Sj4G1tbrT9Mxqo08rIRFHA61
4Btiynofr9L1oyXaTLImF1KpuMExW9n4KkRmvKRW+ayZaU+dwIv53/YzH0ta+Y0y
WLX9z4zRfUsFa3GA/w8/IsHBHaUvHRD7szBxePYvw85U0VnvZrceFXj2PGeFiluI
AgZNmynpmGNgeK6o1sAvjTJ4LxbpPBBJN2q3C5aBy5PGhejOkYo=
=BKBk
-----END PGP SIGNATURE-----