At the moment this hook cannot be used for much. It would be good if the called command would get the path to the .changes file. Passing other data (e.g. upload host) as parameters is even better. Finally, interpreting the exit status would be good, i.e. a status of 1 could mean to stop the upload. This way custom pre-upload checks are possible. Much of this also applies to the post_upload_command. TIA,
tags 140602 + patch thanks The attached patch implements what is described above.
Hi. Thanks for the patch. I can only speak for myself, not Christian, but I'd have a slightly different solution in mind (where there is some substitution mechanism in the command string). IMO this is better in terms of backward compatibility / not breaking existing configurations and extensibility. Kind regards Thomas
Hi, Since I'm not very familiar anymore with the code of dput, I'm relying on Thomas judgement in this case. So I'm going to wait for the patch from Thomas. Christian
also sprach Christian Kurz <shorty@debian.org> [2004.12.20.2142 +0100]: Is this ever going to happen?
Hi Martin, martin f krafft wrote: Shortly after people resume usage of salutations and valedictions in correspondence. Kind regards T.
Control: tags -1 - patch Lets take this as a no, then.
I think this change is appropriate, because the application code has changed so much in the meantime. This bug report can remain open, I think it's a valid request. We will look at how some kind of custom local “hooks” can make it easier to invoke custom commands in the workflow. At that point, this report can be folded into the new proposal; until then, it records IMO a valid request.