The upstream tarball contains a couple of *.orig files.  If you don't
stop it, dh_clean as run by cdbs will delete these.  The diff below
fixes this problem.

Thanks,
Ian.

diff -u libgd-graph-perl-1.43.08/debian/changelog libgd-graph-perl-1.43.08/debian/changelog
--- libgd-graph-perl-1.43.08/debian/changelog
+++ libgd-graph-perl-1.43.08/debian/changelog
@@ -1,3 +1,12 @@
+libgd-graph-perl (1.43.08-2.1ubuntu1) gutsy; urgency=low
+
+  * Set DEB_CLEAN_EXCLUDE='*.orig' since the foolish upstream ships
+    some files *.orig, which dh_clean (as called by cdbs) otherwise
+    removes at inopportune moments.  (!)
+    Fixes autopkgtest FTBFS, LP: #144495.
+
+ -- Ian Jackson <iwj@ubuntu.com>  Thu, 11 Oct 2007 19:45:06 +0100
+
 libgd-graph-perl (1.43.08-2.1) unstable; urgency=low

   * Non-maintainer upload.
diff -u libgd-graph-perl-1.43.08/debian/rules libgd-graph-perl-1.43.08/debian/rules
--- libgd-graph-perl-1.43.08/debian/rules
+++ libgd-graph-perl-1.43.08/debian/rules
@@ -2,6 +2,8 @@
 # -*- mode: makefile; coding: utf-8 -*-
 # Copyright © 2003-2006 Jonas Smedegaard <dr@jones.dk>

+DEB_CLEAN_EXCLUDE='*.orig'
+
 # Put perlmodule.mk last to dh_clean temporary files not in MANIFEST
 include debian/cdbs/1/rules/auto-update.mk
 include /usr/share/cdbs/1/rules/debhelper.mk

Ian Jackson skrev:

I am a little puzzled, however...

You file this bugreport against the version in stable Debian, the latest
version in unstable does not have the reported problem. If I am not
confusing you with someone else, you very well know that for stable
software the only allowed changes are security-related bugfixes.

Collecting bugreports is nice, also for non-critical bugs that won't
ever be solved in Debian - it is to the benefit of our users who might
want the bugs fixed for their own systems.

But in this case, the 2 *.orig files seems to be simple left-overs of
earlier versions of files. Yes, they are mentioned in MANIFEST but seems
to do no harm at all if missing. I suspect noone will ever benefit from
keeping this bugreport open in the system.


In other words: Please elaborate on what problems you feel this bug
might cause, and what you suggest we do about it?

I suggest simply marking it as fixed in 1.44-1 and leave it at that.


Kind regards,

 - Jonas

Jonas Smedegaard writes ("Re: [pkg-GD-devel] Bug#446290: *.orig files from upstream interact  badly with dh_clean"):

Indeed so.

As it happens this source package will have been copied out of sid by
Ubuntu into Ubuntu's current development release about 5 months ago.
Ubuntu is nearing the end of its release cycle and will merge changes
from sid again in about another month.  In the case of this particular
package there were no changes made by Ubuntu.

If I find, as part of my paid work on Ubuntu, a bug in the Ubuntu
package which I consider is very likely to affect the Debian package
as well, and where the same fix should be made to both branches, I
typically report the bug to Debian.  This seems no different to the
situation where I discover a bug in Debian stable on one of my
personal systems.

I found that the change in the patch was necessary to stop the build
failing, complaining about a missing file.  See the build log in this
(automatically filed) bug report against Ubuntu:
https://launchpad.net/bugs/144495

Note the line at the bottom where make looks for
Graph/axestype.pm.orig.  I didn't inspect the Makefiles in detail but
I assumed that the error was because the .pm is generated somehow from
the .pm.orig (upstream having chosen a poor naming scheme).

It is of course possible that upstream have (sensibly) changed the
name so that the bug doesn't appear in sid any more, in which case
it would be right to mark the bug as fixed in the relevant version.

Or perhaps I am mistaken, of course :-).

Regards,
Ian.

Version: 1.44-1

Closing it at this version, a couple of years later :)

Cheers,
gregor