Hi,

just found wnpp-alert today and I think it's one of those great and
nifty tools.  I think it would be nice if the fields were aligned.
Currently, this is not the case.  Orphaned packages are off by two
spaces.  I'm not sure, but I think the patch below probably fixes that
(fwiw, it works fine here, locally).

=== Schnipp ===
--- /usr/bin/wnpp-alert	2008-06-27 19:46:52.000000000 +0900
+++ /tmp/wnpp-alert	2009-02-06 13:43:47.645340010 +0900
@@ -125,4 +125,4 @@
 fi

 comm -12 $WNPP_PACKAGES $INSTALLED | sed -e 's/+/\\+/g' | \
-xargs -i egrep '^[A-Z]+ [0-9]+ {} ' $WNPP
+xargs -i egrep '^[A-Z]+ [0-9]+ {} ' $WNPP | sed s/^O/O\ \ /

=== Schnapp ===

While we are at it, why not include the URL for the bug numbers so that
in many shells it becomes clickable?

=== Schnipp ===

--- /usr/bin/wnpp-alert	2008-06-27 19:46:52.000000000 +0900
+++ /tmp/wnpp-alert	2009-02-06 13:43:47.645340010 +0900
@@ -125,4 +125,4 @@
 fi

 comm -12 $WNPP_PACKAGES $INSTALLED | sed -e 's/+/\\+/g' | \
-xargs -i egrep '^[A-Z]+ [0-9]+ {} ' $WNPP
+xargs -i egrep '^[A-Z]+ [0-9]+ {} ' $WNPP | sed s/^O/O\ \ /sed 's!\ !\ http://bugs.debian.org/!'

=== Schnapp ===

I am not a shell guru, so this may not be 100% correct.  Please be
careful.

Regards

Rolf

Rolf Leggewie wrote:

This line should of course be

+xargs -i egrep '^[A-Z]+ [0-9]+ {} ' $WNPP |sed 's!\ !\
http://bugs.debian.org/!' | sed s/^O/O\ \ /

Hi,

Thanks :-)

It would give the effect you were after, yes; there's no need to escape
spaces, though. :-)

Unfortunately, it will break --diff support, as the generated lists
won't match even if the bugs they contain haven't changed. Fixing that
shouldn't be a problem, I'm just recording it here so we don't forget
about it.

[...]

No objections, although I'd be inclined to make the behaviour optional,
as I know it would potentially annoy me at least. It would also have the
same issue with --diff mode if the previously generated diff didn't
contain URLs.

Regards,

Adam

Hello,

hoping that this could land after lingering for about 5 years I've
pushed the relevant patch to alioth git in a branch called
pull-request1.  The branch is based off the tip of the current master.
Thank you for your kind consideration.

Regards

Rolf

Hi,

Thanks for the patch.

I'm not particularly involved with devscripts maintenance these days;
I'm afraid it's unlikely I'll look at this myself in the near future.

Regards,

Adam

The changes weren't applied to the "--diff" handling.  Was that
intentional?

I'm not sure that sorting primarily on the type of WNPP bug is
necessarily useful.  The most relevant piece of information is the
package name, so I think that should continue to be the primary key for
sorting.  This would also keep the sort stable if the answer to my
earlier question is “no”.

Also, now that the bug reference is larger, I think it looks a bit
cleaner to have "bugUrl wnppType package -- desc".

Cheers,

I'm posting it here so I can delete that branch.

commit dd2a2ceb81979f37017797c3ad3b5998e77b6b04 (HEAD, origin/pull-request1)
Author:     Rolf Leggewie <foss@rolf.leggewie.biz>
AuthorDate: Mon Mar 3 06:47:02 2014 +0100
Commit:     Rolf Leggewie <foss@rolf.leggewie.biz>
CommitDate: Mon Mar 3 06:47:02 2014 +0100

    wnpp-alert: linkify bug numbers and align fields. Closes: #514307

diff --git a/scripts/wnpp-alert.sh b/scripts/wnpp-alert.sh
index da3be4b4..b633650e 100755
--- a/scripts/wnpp-alert.sh
+++ b/scripts/wnpp-alert.sh
@@ -128,5 +128,22 @@ if [ -f "$WNPP_DIFF" ]; then
     fi
 fi

Hello,

Good morning,

We have gone through your samples from a partner and Here is our  Order
List. Please do bear in mind that we are very much in  need of this
order, quote your competitive prices.

Kindly send the Order confirmation.

Your early reply will be much appreciated.

Best Regards,

Maryanah Erwin.

PT FINDORA INTERNUSA

Jln Pahlawan 66 Kec. Arjawinangun

45162 CIREBON West-Java INDONESIA

tel : +62 231 357334

fax: +62 231 357260

email: marketing@findora.com