*** Please type your report below this line ***

The 1.6.3-3.2 version of tinyproxy does not properly handle IP mask
rules:
  1) They are ignored for upstream rules entirely
  2) The hostname is not translated to an IP address before matching.

Therefore, a rule like:
  upstream test-proxy:8088 "127.0.0.0/8"

will never take effect.

Also, the documentation says the last rule applies, while in the code,
the first rule applies.  The attached patch fixes all of these issues.
The installed version (1.6.3-4) is the version with the patch applied.
        -Eric

The previous patch incorrectly claimed that the first rule applied, it
is actually the last rule, it just didn't look like it in the code.
The attached patch fixes that, and adds debugging of upstream proxy
determination.  It is cumulative with the previous patch.
	-Eric

On Wed, Mar 25, 2009 at 11:58:48AM -0700, Eric Anderson wrote:
Content-Description: message body text

A single patch is a lot better than two cummulative patches.

Have you tried contacting upstream about these fixes?

Jordi

Jordi Mallach writes:
 > On Wed, Mar 25, 2009 at 11:58:48AM -0700, Eric Anderson wrote:
 > Content-Description: message body text
 > > The previous patch incorrectly claimed that the first rule applied, it
 > > is actually the last rule, it just didn't look like it in the code.
 > > The attached patch fixes that, and adds debugging of upstream proxy
 > > determination.  It is cumulative with the previous patch.
 > > 	-Eric
 >
 > A single patch is a lot better than two cummulative patches.

Attached.

 > Have you tried contacting upstream about these fixes?

No, my understanding was that the Debian maintainer did that.  If
that's wrong, I can contact upstream.
	-Eric