#540576 "Toggle useless messages" and similar links don't work unless Javascript is enabled

#540576#5
Date:
2009-08-08 21:27:24 UTC
From:
To:
The web page for each bug report includes a link labelled "Toggle
useless messages" that points to "javascript:toggle_infmessages();".
This link doesn't do anything on a browser with Javascript disabled.

Either this link should be hidden (with the "useless messages" always
displayed) when JS is disabled, or it should have a proper URL that
triggers a server-side action (in addition to an onclick handler for
JS-enabled browsers).

pkgreport.cgi has a "Toggle all extra information" link with the same
problem.

- Michael

#540576#10
Date:
2009-08-26 16:16:34 UTC
From:
To:
severity 540576 minor
tag 540576 wontfix
thanks

The reasonable default is to not display the useless messages at all.
If for some reason you actually want to see them, you can either
enable javascript, munge the CSS yourself, or view the source.

The default for people without javascript is to show all of the extra
information... did you actually test this?


Don Armstrong

#540576#19
Date:
2009-08-27 03:16:43 UTC
From:
To:
style / No style).

I agree that hiding the messages is a reasonable default, but I think
it's a bad idea to show a link that won't actually work.  Would you be
willing to accept a patch that improves this behaviour?

Sorry for being unclear.  What I meant was that the link has no effect
when JS is disabled; I didn't test with JS enabled to see what
information would be shown or hidden.

#540576#22
Date:
2009-08-27 06:49:26 UTC
From:
To:
I'd consider it, but it certainly sounds like a lot of extra work and
code for what is at most a cosmetic issue, and pretty typical one if
you wander around without javascript enabled. [After all, if you're
using iceweasel, you can pretty trivially enable javascript for bdo
and only bdo using noscript or similar.]

That's fine, but there are lots of things which aren't going to work
when you disable javascript. [And honestly, the set of things is going
to get larger and larger.]

I'm always willing to adjust defaults to make the page useable for
browsers and people without javascript and or CSS support, but not at
the expense of cripiling functionality or excessive bits of code.


Don Armstrong

#540576#27
Date:
2023-03-07 00:26:49 UTC
From:
To:
I have an urgent project to discuss with you, please message me at my private email address below


drcc7072@gmail.com



For more information