While check checking license with licensecheck, It could not find license in nfoview/tools/*

Here are some test outputs:

kartik@olive:~/development/debian/packages/sponsored/nfoview/nfoview-1.6$licensecheck -r *
(removed debian/* output for making it short but it doesn't make any difference in bug report)
nfoview/paths.py: GPL (v3 or later)
nfoview/errors.py: GPL (v3 or later)
nfoview/open.py: GPL (v3 or later)
nfoview/main.py: GPL (v3 or later)
nfoview/test/test_preferences.py: GPL (v3 or later)
nfoview/test/test_view.py: GPL (v3 or later)
nfoview/test/test_open.py: GPL (v3 or later)
nfoview/test/test_actions.py: GPL (v3 or later)
nfoview/test/test___init__.py: GPL (v3 or later)
nfoview/test/test_util.py: GPL (v3 or later)
nfoview/test/test_window.py: GPL (v3 or later)
nfoview/test/test_about.py: GPL (v3 or later)
nfoview/test/test_builder.py: GPL (v3 or later)
nfoview/test/test_paths.py: GPL (v3 or later)
nfoview/test/test_i18n.py: GPL (v3 or later)
nfoview/test/test_conf.py: GPL (v3 or later)
nfoview/test/test_errors.py: GPL (v3 or later)
nfoview/test/test_schemes.py: GPL (v3 or later)
nfoview/test/test_main.py: GPL (v3 or later)
nfoview/about.py: GPL (v3 or later)
nfoview/conf.py: GPL (v3 or later)
nfoview/view.py: GPL (v3 or later)
nfoview/i18n.py: GPL (v3 or later)
nfoview/unittest.py: GPL (v3 or later)
nfoview/builder.py: GPL (v3 or later)
nfoview/window.py: GPL (v3 or later)
nfoview/actions.py: GPL (v3 or later)
nfoview/util.py: GPL (v3 or later)
nfoview/__init__.py: GPL (v3 or later)
nfoview/preferences.py: GPL (v3 or later)
nfoview/schemes.py: GPL (v3 or later)
setup.py: *No copyright* UNKNOWN

kartik@olive:~/development/debian/packages/sponsored/nfoview/nfoview-1.6$ ls -hl
total 116K
-rw-r--r-- 1 kartik kartik   34 2008-10-26 08:18 AUTHORS
drwxr-xr-x 2 kartik kartik 4.0K 2009-08-16 18:07 bin
drwxr-xr-x 5 kartik kartik 4.0K 2009-09-05 20:00 build
-rw-r--r-- 1 kartik kartik  35K 2008-10-26 08:18 COPYING
-rw-r--r-- 1 kartik kartik  366 2008-10-26 08:18 CREDITS
drwxr-xr-x 2 kartik kartik 4.0K 2009-09-05 20:00 data
drwxr-xr-x 4 kartik kartik 4.0K 2009-09-05 20:00 debian
drwxr-xr-x 2 kartik kartik 4.0K 2009-08-16 18:07 doc
-rw-r--r-- 1 kartik kartik  647 2009-04-05 22:20 INSTALL
drwxr-xr-x 8 kartik kartik 4.0K 2009-09-05 20:00 locale
-rw-r--r-- 1 kartik kartik  263 2009-02-28 05:09 MANIFEST.in
-rw-r--r-- 1 kartik kartik 2.7K 2009-08-16 18:02 NEWS
drwxr-xr-x 3 kartik kartik 4.0K 2009-08-16 18:07 nfoview
-rw-r--r-- 1 kartik kartik  263 2009-08-16 18:07 PKG-INFO
drwxr-xr-x 2 kartik kartik 4.0K 2009-09-05 20:00 po
-rw-r--r-- 1 kartik kartik 1.4K 2009-03-15 22:33 README
-rwxr-xr-x 1 kartik kartik 8.6K 2009-04-19 19:08 setup.py
-rw-r--r-- 1 kartik kartik  200 2009-08-16 18:01 TODO
drwxr-xr-x 2 kartik kartik 4.0K 2009-08-16 18:07 tools

licensecheck is clearling missing tools/ directory.

kartik@olive:~/development/debian/packages/sponsored/nfoview/nfoview-1.6$ licensecheck -r tools/*
tools/git2cl: GPL (with incorrect FSF address)

Thanks.
--- /etc/devscripts.conf ---

--- ~/.devscripts ---
Not present

[...]

What else is in tools/ ? If it's only that file, then it's not missing
anything:

      -c=regex --check=regex
           Specify a pattern against which filenames will be matched in order to
           decide which files to check the license of.

           The default includes common source files.

The name "git2cl" does not match "common source files".

Actually, I'm assuming that there /is/ only "git2cl" in tools/,
otherwise the command you quoted still wouldn't have displayed it; see
#526701 for a discussion as to whether that's a good idea.

In summary, I don't think there's a licensecheck bug here. It's not
doing what you expected, admittedly, but it is doing what it's
documented as doing. :)

Regards,

Adam

Yes. single file only.

You got it right!

Ah. Still, I expect that, licensecheck -r * should check each and
every file it encounter :)

Probably, we can down severity to `wishlist'.

Control: block -1 by 960695

Hi Kartik,

I agree that current defaults of licensecheck is not ideal.

My current plan to address this is to first introduce a new option
"--usage" which changes defaults, and then later (with bumping minor or
major version number) switch from current usage=legacy to e.g.
usage=debian.

If you have opinions/ideas/criticism for that general conceptual, then
please contribute at bug#960695.

Let's continue to track here the specifics of option "--recursive".

This is (a subset of) current "licensecheck --help":

 -c STR --check STR         regular expression of files to include
                            (default value: common source files)
 -i STR --ignore STR        regular expression of files to skip
                            (default value: some backup and VCS files)
 -r --recursive             traverse directories recursively

How do you think about this future "licensecheck --help":

 -c STR --check STR         files to include;
                            with usage=legacy a regular expression
                            replacing previous or default value
                            and default being common source files,
                            with any other usage a comma-separated list
                            adding onto previous and default values
                            except an empty value which clears the list
                            and default being all files
                            (default value: common source files)
 -i STR --ignore STR        files to skip;
                            with usage=legacy a regular expression
                            replacing previous or default value,
                            with any other usage a comma-separated list
                            adding onto previous and default values
                            except an empty value which clears the list
                            (default value: some backup and VCS files)
 -r --recursive             traverse directories recursively

I.e. change nothing for the option --recursive itself, only for the
options --include and --exclude (both listed here, even if only some of
my envisioned changes are relevant for this issue).

 - Jonas
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAl6+t8oACgkQLHwxRsGg
ASHq4g/9HR3XU6XO+Y85AnPEuOAEE2lnpH5o/NismOmR7QplzK3qAKGc+u4lDBZO
p8yMgfn66ig7zQzo0N7qYwQFSoyIm7QqDBlA9Qhp7+I4ccrqIyOukij1ByQVA9eq
PTacVe2a4s+Zw/FBecbq7fk2VN85+OCM6HLxR7cRO4CMS+1SxrYMaZup+JcloaRl
C/ucLOi6BTV9IVgocYAfqTWGjkZdxX6epRXwHdntqG/uDHWrav5FZ/MPC9hXFkbg
sxt74XwC5dygk+dEY6RIQgQa3y9PMVBl7q/f8S/HVAjp0hAK1OdcnGUu5EYmh6YP
QBc+Bd+yGBx+iRfs2XgGaQszgOHaVa6TrJgfcr/am0cnRWxvT4ctSrvzp4izQKwb
RA6OyNNZprRfUqFr7ZIchXBY9XIqDbDQUSqkoaxFHv+e4t9zj8YWW242id2soeEq
zCKmr6ybMgPKSTbdpqO/4jEPNLNqsaNm9bQ7KM5bXepy2GwUac+mlawOmplM+Ne4
BFPdJC5+zMw/L7dqN8wBXzhW5R5kqRODbwcTkjXdt9cLKDEQWrNC3gbOVMoCyrQG
zz3f3IvO6f3XNRJndtUXtADzDK01YoR+ad2coaItX2lwaJUUa1gDfvkKAVXSwjt+
J4zMk535tmTCtLK3MwNe8GkEGR0CNJff2TDkDD2IfVa372Pp300=
=fb4S
-----END PGP SIGNATURE-----

Good morning,

 Attached please find your PDF account statement and invoice as of 05/11/2023. Please notice you have a past due balance  for invoice IN0099203.

 Please provide payment as soon as possible.




 Best Regards,
 Shawneen Chisholm
 Accounts Receivable Coordinator

 UNITED RENTALS, INC.
Branch L02 BONNYVILLE
4920 56TH AVE
BONNYVILLE AB T9N 2N8 CA
780-826-7610


 CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s). This may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message, please alert the sender immediately by reply email and then delete this message and any attachments. Any disclosure, reproduction, distribution or other use of this message or any attachments by an individual or entity other than the intended recipient is prohibited