--- Please enter the report below this line. ---

Please include the attached ruby script for the collection of ADSL statistics
from a Linksys AG241 ADSL Modem.

I have had it running well on my lan here for a while, no fast upstream so
contact me for a link.

Debian Release: squeeze/sid
  500 unstable        aptproxy
  500 sid             aptproxy
--- Package information. ---
Package's Depends field is empty.

Package's Recommends field is empty.

Package's Suggests field is empty.

Hi,

Thank you for the bug report and the proposed plugin.

I'm not exactly sure what is the process of adding new plugins to
munin-plugins-extra - lets wait for the munin package maintainers to respond
to about this.

However, I think in the meantime, if you want to get the plugin out there, the
correct thing to do is publish it in http://muninexchange.projects.linpro.no/
and maybe also send an email to the munin-users mailing list, so people will
be aware of it.

In addition, there's only one issue I see with the plugin, and that its
designed for a specific hardware, and that makes it hard to test and maintain
(for example what if someone files a bug against it, how will we fix/test the
fix for it if we don't have the hardware).

You mention in the comments of the plugin that this adsl modem also has an
snmp interface - wouldn't that be a better approach to getting the data into
munin? And this may also be the way to make this plugin more generic in the
future, adding support for additional devices.

Thanks again for the plugin,
Regards,
    Tom Feiner

Right ill sort that later.
Yes I agree though surely it will be useful to someone else... :)

As far as i can tell the ADSL statistics are not available through the SNMP
interface, only network traffic stats are.

Hi,

plugins which are to be added to munin-plugins-extra should preferable be
available at muninexchange, though having them in a trac ticket for munin is
probably good enough as well :-)

and they should be off reasonable good code quality and licenced under a dfsg
free licence, plus they should be useful for a (somewhat) broader audience.

we need to rely to the upstream authors for that, thats also why they are in
munin-plugins-extra... ;-)


regards,
	Holger

Hi David,

I see that you've uploaded the plugin to muninexchange [1]. It looks great :D

I would like to keep the munin package as patch free as possible, and adding
this plugin only for the Debian package will cause us to add it as a patch on
top of the munin vanilla tar, and diverge from upstream. I think that the
correct way to get it included is by opening a ticket upstream and asking them
to include it (that way not only debian users will benefit from it, but all
munin users).

Can you please post the munin ticket once you have it, so we can link this bug
upstream?

Thanks,
Tom Feiner

http://muninexchange.projects.linpro.no/?view&phid=720

Hi David,

I see that you've uploaded the plugin to muninexchange [1]. It looks great :D

I would like to keep the munin package as patch free as possible, and adding
this plugin only for the Debian package will cause us to add it as a patch on
top of the munin vanilla tar, and diverge from upstream. I think that the
correct way to get it included is by opening a ticket upstream and asking them
to include it (that way not only debian users will benefit from it, but all
munin users).

Can you please post the munin ticket once you have it, so we can link this bug
upstream?

Thanks,
Tom Feiner

http://muninexchange.projects.linpro.no/?view&phid=720

Closing as this is included in munin exchange.

reopen 547464
thanks

Hi Tom,

Hmmm. In the past (etch iirc) we had some plugins from munin exchange... we
also had like 50 patches, which mostly you cleaned up :) Doing it the
traditional way would be to include it with a patch and add it to the
munin-plugins-extra binary package. Nowadays we only ship the plugins
included in the upstream source and nothing extra.

What do you propose for this adsl modem script?

It not to be packaged for Debian directly? Putting it into munin-plugins-extra
via a patch? Or another new package, munin-plugins-exchange, for those from
munin exchange, or a specific package, like munin-libvirt-plugins (which it
seems we didnt manage to get rid of for squeeze...)

I think the wish to have those adsl modem plugins packaged is a legitimite
one, reopening. Same for other plugins from munin exchange...


cheers,
	Holger

Well, we've already seen the results of accepting contribution
plugins, and adding them to the debian munin-plugins-extra package.
We get a huge mess of patches creating plugins which in effect do not
have any owner or maintenance upstream. This puts a burden on us as
packagers, which in addition to packaging and solving bugs in munin
core and munin core plugins, we effectively become somewhat fork of
munin which maintains extra plugins beyond the core "official"
plugins. This causes people to loose focus from upstream and from
munin-exchange, which are the proper places to  add plugins, AFAICS.
for a plugin to get packaged, is to be good enough, and popular
enough, as to get included in the official upstream core, or upstream
contrib plugins, and the way to do that is through munin exchange,
which offer the author a great way to publish a plugin , along with
screenshots, descriptions, version control, comments on the plugin,
download statistics - all things that we cannot provide by placing a
plugin as a patch.

When munin-exchange was recently redesigned, there was talk about a
sort of "apt-get" like tool to search/download plugins directly from
munin-exchange. As far as I know this was not written yet, but the
infrastructure for it is already there. The rewritten munin-exchange
has an official API [1], so the tool will eventually get written, and
people using munin, which  have this specific ADSL modem and want to
monitor it will be able to query munin exchange for it and download
the plugin. But for now they can do it manually. :)

[1] http://exchange.munin-monitoring.org/docs/api/

Basically, what I'm saying here, is : why should we include one
specific plugin, and not any of the other 500+ plugins already in
munin-exchange? It does make sense to include patches to plugins that
are debian specific, but even for those, I would still try to include
them upstream first, and only add them as a patch only if upstream
refuses to do so.

That's just my 2cents,
Tom Feiner

tags 547464 + wontfix
retitle 547464 please include $plugin from munin-exchange
thanks

Hi,

Good.

Makes sense to me. Thanks for explaining that.


cheers,
	Holger

Hello,

upstream just added such a tool ("munin-get") in its release 2.0.52.
It should ease the installation of external munin plugins. Specifically munin's
"contrib" repository is pre-configured out of the box.

Thus the following should be sufficient for installing and enabling a module
from the contrib repository:

  munin-get update
  munin-get install traffic
  munin-get enable traffic
  service munin-node restart

Cheers,
Lars