#583379 edac-utils: init script might be "too chatty"

Package:
edac-utils
Source:
edac-utils
Description:
report kernel-detected PCI and ECC RAM errors
Submitter:
Christoph Anton Mitterer
Date:
2010-05-27 17:33:03 UTC
Severity:
wishlist
#583379#5
Date:
2010-05-27 13:38:06 UTC
From:
To:
Hi.

This is really a very minor wishlisht bug only.

I'm currently looking through some of Debians init-scripts, as
some of them are really too chatty and nearly output documentation.

For /etc/init.d/edac one could think whether this also applies
for the following:
log_daemon_msg "Not enabling ${DESC} since EDAC_DRIVER is not set"

It might be enough to simply say something like
"Not enabling EDAC as it has been disabled."
Ok that text is not so good, but what I mean is, the EDAC_DRIVER
thingy might be too descriptive.

But as said,.. this is rather perfectionism than really a problem.

Cheers,
Chris.

#583379#10
Date:
2010-05-27 13:49:39 UTC
From:
To:
Hi Christoph,

Thanks for the feedback, but are you really suggested to replace
an informative message (which points to what exactly needs to be changed)
with a generic 'enabled/disabled' action (whenever there is no ENABLED
variable at all) suggestion?

#583379#15
Date:
2010-05-27 16:32:00 UTC
From:
To:
Well,... it's a difficult question... I've seen most packages t only
give status messages like "started", "disabled" and so on in their init
scripts.
And I've seen "bug"-reports from other users regarding too chatty init
scripts...

Perhaps one should discuss this at debian-devel, whether there's a best
practise for init-script messages.

Cheers,
Chris.

#583379#20
Date:
2010-05-27 17:31:23 UTC
From:
To:
yeap -- and most of the time it is just that:
/etc/default/bluetooth:BLUETOOTH_ENABLED=1
/etc/default/bluetooth:HID2HCI_ENABLED=0
/etc/default/ipmievd:ENABLED=false
/etc/default/pyro-nsd:ENABLED=0
/etc/default/stunnel4:ENABLED=0
/etc/default/sysstat:ENABLED="false
saw those too, and often it was simply non-conformance to use
/lib/lsb/init-functions as the way to ease the conformance with
Debian policy 9.4 Console messages from init.d scripts
Sure -- please feel free to raise a discussion and use edac-utils as an
example ;)