#590648 git-buildpackage calls debuild incorrectly

Package:
git-buildpackage
Source:
git-buildpackage
Submitter:
Brian May
Date:
2010-08-01 23:33:03 UTC
Severity:
normal
#590648#5
Date:
2010-07-28 03:42:18 UTC
From:
To:
According the man page, debuild is suppose to accept --username value
as a valid option:
#590648#10
Date:
2010-07-28 12:06:45 UTC
From:
To:
That's not correct.  All debuild options must come first, as mentioned
in the man page:

  Note the order of options here: the debuild options come first, then
  the dpkg-buildpackage ones, then finally the checker options.

This happens because as soon as we see a non-debuild option, we break
out of our option parsing and treat the rest as options for the other
tools that get invoked.
#590648#15
Date:
2010-07-28 23:02:40 UTC
From:
To:
Errr... Not so fast at closing the bug - it isn't resolved yet...

The problem is that this command line is generated automatically by
git-buildpackage, and git-buildpackage puts the "-i -I" options first,
before any other options on given on the git-buildpackage command
line.

i.e.

git-buildpackage --username value

becomes

debuild -i -I --username value

Are you saying git-buildpackage needs to sort the options and put
debuild options first? That sounds like debuild needs to have a
hardcoded list of what options debuild takes, which sounds very error
prone and likely to break with new versions of debuild.
#590648#20
Date:
2010-07-29 00:15:21 UTC
From:
To:
It is from our end.  It can be reopened and reassigned to
git-buildpackage if you like.

Or it could rely on the user to specify all the args they want instead.
                    ^-- I assume you meant git-bp

debuild isn't really a moving target, but if your suggested approach is
what git-buildpackage people decide to do, then yes they may need to do
that.
#590648#25
Date:
2010-07-29 00:50:30 UTC
From:
To:
Yes, please.

Oops. Yes.
#590648#30
Date:
2010-07-29 14:49:43 UTC
From:
To:
reopen 590648
retitle 590648 git-buildpackage calls debuild incorrectly
reassign 590648 git-buildpackage 0.3.3
thanks

As per the below discussion, git-buildpackage's builder command defaults
to "debuild -i\.git -I.git"[0] and any non "--git-..." options are
appended to the default command.  This doesn't work because
debuild-specific options must come first, followed by dpkg-buildpackage
options and then lintian options, if any.

[0]: Actually, that's an inconsistency between the man page and the real
     default of "debuild -i -I".

On Wed, Jul 28, 2010 at 7:02 PM, Brian May <brian@microcomaustralia.com.au> wrote: