umount is totally different from safe removal, sometimes A disk is still intended to be used while umounted, please revert the patch 14_dont_show_umount.patch
Le jeudi 23 septembre 2010 à 08:12 +0800, Darren Hoo a écrit : Yeah, I thought of that too. That’s especially true of disks which have several partitions. However, even in such cases, I’m not sure there’s much added value in that additional menu entry, and you should not forget that it also makes things very confusing for users who don’t understand what mounting means. Cheers,
It is important when several partition are on a USB storage. So I agree with the reporter that this regression must be fixed.
Le mercredi 13 octobre 2010 à 17:29 +0200, rpnpif a écrit : Please explain how to do so without reintroducing the bug. I have already explained that I have no solution to propose, so I’m eager to listen to yours.
Le 13 octobre 2010, Josselin Mouette a écrit : Sorry, I did not see your previous message. If ejectable devices as CD or DVD can be distinguished of only removable devices as USB stick, I suggest for USB stick to display unmount or detach instead of eject. Detach is a word more comprehensive for users. But I think also that it is not a good thing to mimic MS Windows vocabulary : unmount has a sense. For CD or DVD, I think that there is no bug. Now, I do not know how distinguish CD with DVD in Gnome code. An other alternative that I find nice, keep only unmount and safe removal, remove the eject item. Do the eject action with the safe removal for CD and DVD (and USB storage). This last alternative is simpler.
Le mercredi 13 octobre 2010 à 18:44 +0200, Alain Rpnpif a écrit : For USB sticks, eject is not displayed, unless this is a buggy device that advertises itself as a removable media drive. Instead you see the “safely remove” item. If we don’t show “unmount”, there is the problem with multiple-partition disks. If we show it, it’s confusing for users who don’t know the difference with safe removal. Which is why I don’t have a magical solution to propose. I don’t think the underlying APIs expose whether or not there are several partitions attached to the same disk. Cheers,