#599160 cron: Please document applied patches and/or use quilt

Package:
cron
Source:
cron
Description:
process scheduling daemon
Submitter:
Allard Hoeve
Date:
2010-10-06 05:54:03 UTC
Severity:
wishlist
#599160#5
Date:
2010-10-05 08:14:12 UTC
From:
To:
Dear Maintainers,


Thank you for maintaining the (probably) most used package in Debian ever. (Or
is it bash?).


Today I was trying to apply a patch to the latest Debian package in squeeze.
Unfortunately, the patch didn't immediately apply. This led me to investigate
why.


That part was hard, since the Debian patch is one big hunk of diff :)  That is
fine, but it would be better if you could split your Debian patch into quilt
patches so reviewing them is made easier.

I know you have an SCM, but for people who use the package on their systems,
trying to apply a patch, it would be much easier if you could split patches
into smaller parts.


Thanks for all the hard work,

Best,

Allard
--- usr/bin/editor:
/usr/bin/vim.nox

--- /usr/bin/crontab:
-rwxr-sr-x 1 root crontab 30248 Oct  4 17:37 /usr/bin/crontab



--- /var/spool/cron
drwxr-xr-x 5 root root 4096 Apr  8 13:38 /var/spool/cron



--- /var/spool/cron/crontabs
drwx-wx--T 2 root crontab 4096 May 13  2009 /var/spool/cron/crontabs
#599160#10
Date:
2010-10-05 17:07:30 UTC
From:
To:
Hi Allard,

What kind of patch, and from what source (BTS, third party, ...)?

I'm aware of this problem, which is why the conversion to source format
"3.0 (quilt)" has already taken place (see SVN branches/sf3).

There are many good reasons why the official package hasn't been
converted to this yet -- too many to list here. All I can say is that I
hope to have a clean 4.1 release (where I'm focusing my efforts) ready
soon now.

If you need help, you an also email me directly or file a bug in the BTS
if you patch is for a specific feature.


Christian
#599160#15
Date:
2010-10-05 23:16:11 UTC
From:
To:
tags 599160 pending
thanks

If you check out http://svn.debian.org/viewsvn/pkg-cron you will see that it has
a branch specifically created for that.

I suggest you checkout the SVN and try to use the 'sf3' branch. This branch
is the 3.0 release of cron with all the patches using quilt.

Future releases of the cron package (post-squeeze release) will use this
format. We woud appreciate if you tested out that branch (with your packages)
and provide feedback on wether this is what you need.


Thanks

Javier
#599160#20
Date:
2010-10-06 05:51:48 UTC
From:
To:
Hello Christian,

4.1: Thanks, perfectly reasonable plan, of course.

Patch: it's the first word patch that is in BTS somewhere.

Thanks for replying!

Allard

Sent from my HTC.
On Oct 5, 2010 7:07 PM, "Christian Kastner" <debian@kvr.at> wrote: