Hello,

For non-sighted users, gdm3 should beep or at least provide a way to
configure some beep when it is ready. The typical situation is a blind
user installing Debian and enabling the gnome desktop in tasksel. At
reboot, gdm3 will be presented, but the blind user doesn't have any clue
when it is ready to accept keypresses. I don't mean enabling a beep by
default, that could be something that the debian installer enables only
when accessibility was enabled for the installation.

Samuel

Le dimanche 26 septembre 2010 à 20:39 +0200, Samuel Thibault a écrit :

It shouldn’t be hard to implement with a GConf value that is read in the
greeter. Such a value could easily be set in d-i.

I would definitely accept a patch to do that.

Cheers,

Josselin Mouette, le Mon 27 Sep 2010 18:20:38 +0200, a écrit :

How is this done from d-i more precisely?

Samuel

Le dimanche 17 octobre 2010 à 05:01 +0200, Samuel Thibault a écrit :

You need to ship a file in /usr/share/gconf/defaults. Like for gksu,
this one should probably be an alternative.

Cheers,

Hello,

Josselin Mouette, le Mon 27 Sep 2010 18:20:38 +0200, a écrit :

Here is the part that adds the beep.

Samuel

tags 598132 + patch
clone 598132 -1
reassign -1 gnome-settings-daemon
tags -1 + patch
thanks

Samuel Thibault, le Sun 17 Oct 2010 16:06:45 +0200, a écrit :

Here is the part that adds the configuration checkbox in the
accessibility panel.  That's in the gnome-settings-daemon package, thus
cloning.

Samuel

Le dimanche 17 octobre 2010 à 16:58 +0200, Samuel Thibault a écrit :

Sorry but this is not going to happen. What use is there for such a
configuration checkbox? Furthermore there is nothing in the patch that
makes the beep actually happen.

Cheers,

Josselin Mouette, le Tue 19 Oct 2010 08:31:00 +0200, a écrit :

Err, well, for enabling/disabling it easily, just like other
accessibility features.
Sure there is: that code toggles
/desktop/gnome/applications/at/beep_enabled to true, which thus enables
starting beep from the greeter-autostart.

Samuel

Le mardi 19 octobre 2010 à 11:57 +0200, Samuel Thibault a écrit :

How is beeping in the *user session* an accessibility feature?

You are mixing apples (the greeter session) and oranges (the user
session). The control center cannot be used to configure the greeter
session, since it is not executed as the same user.

Cheers,

Josselin Mouette, le Tue 19 Oct 2010 13:57:59 +0200, a écrit :

This is not about the user session, but about the Debian-gdm session,
used for gdm3.

No, gdm does. It uses the Debian-gdm session for the greeter.

It is, in the gdm3 case, thanks to the Debian-gdm special user.

Samuel

Samuel Thibault, le Tue 19 Oct 2010 14:07:54 +0200, a écrit :
an "accessibility" icon, which triggers an accessibility panel that my
patch is modifying. This all happens in the Debian-gdm session.

Samuel

Le mardi 19 octobre 2010 à 14:24 +0200, Samuel Thibault a écrit :

Ah, my bad. I thought this code was in the simple-greeter itself.

In this case I don’t understand why you use 2 different GConf keys for
that effect. You should put as much as possible of the changes in g-s-d,
and just ship a different default for the greeter session - we can do so
in the configuration file.

I’d prefer if the beep was emitted by a new g-s-d plugin, but if done
this way we could do with using beep. In this case we shouldn’t forget
the correct X-GNOME-Autostart-Phase so that the beep only happens when
everything else is ready.

Cheers,

Josselin Mouette, le Tue 19 Oct 2010 16:17:45 +0200, a écrit :

Err, which 2 different GConf keys?  I'm just using the

/desktop/gnome/applications/at/beep_enabled

key everywhere.

Why doing so?  Writing a plugin seems much more involved than just
putting a .desktop file in gdm3, I wonder for which benefit.

Why is this case different from the .desktop file case, concerning using
beep?

Ah, I didn't know about that thing.  I guess we can move
gdm-simple-greeter.desktop.in to Desktop phase, and the beep task to
Application phase?

Samuel

Le mardi 19 octobre 2010 à 16:39 +0200, Samuel Thibault a écrit :

D’oh. Sorry, I misread that too.
the path downwards confusion when you create a new configuration item
that will not do anything when checked.

To sum up: either you do the changes in g-s-d and have gdm set them in
its GConf configuration, or you do the changes in gdm and set them in
gdm’s own configuration. The latter is still my favorite, and above all
I’m not for a half-baked mix of both solutions.

Also note that it is quite late to introduce a new string in the
configuration box. It wouldn’t be translated to more than a handful of
languages at the time of the release. I’d prefer if we just stuck to
making something that works - gdm2 has always beeped when ready, and I
don’t recall people complaining of that.

I guess that wouldn’t work anyway, since gdm-simple-greeter doesn’t
register itself to the session manager.

Cheers,