Hi!

As it can be seen in the attached screenshot, there is no mute icon left
to the "lower volume" button. According to the source, there should be
something like audio-volume-low or audio-volume-high, both usually
provided via the icon set in use.

With strace, I noticed minitube (or QT) scans 312 icon directories,
unfortunately none of them contained neither the PNG nor SVG version.

This might be a misconfiguration on my side (I never cared about icon
sets, so I'm just using "defaults", for whatever this means if you run
fluxbox), but maybe one could either depend on the correct icon set or
at least provide an alternative text like "Mute" as it's done with Play.
I reckon these "buttons" are also just showing the fallback text over
here.


Cheers

Hi!

It looks like this is actually a "bug" in Qt. Quoting from Qt4.7's
src/gui/image/qiconloader.cpp:

----
/* Theme to use in last resort, if the theme does not have the icon, neither
the parents  */ static QString fallbackTheme()
{
#ifdef Q_WS_X11
    if (X11->desktopEnvironment == DE_GNOME) {
        return QLatin1String("gnome");
    } else if (X11->desktopEnvironment == DE_KDE) {
        return X11->desktopVersion >= 4
            ? QString::fromLatin1("oxygen")
            : QString::fromLatin1("crystalsvg");
    } else {
        return QLatin1String("hicolor");
    }
#endif
    return QString();
}
----

Unfortunately, hicolor does not seem to have audio-volume-high nor
audio-volume-muted. It also seems to be missing other icons which get
rendered as text.

So I actually don't know how to fix this in a clean way. It would be possible
to recommend one of the other icon themes and extend the icon search path
from within minitube, but I think that's not clean.

I think I will at least prepare a patch to add fallback texts.

Cheers,
sur5r

Hi!

Thanks for looking into this despite its rather lower relevance. ;)

I guess a clean way would be to add the missing icons to the hicolor
theme, ideally upstream. Maybe we could simply reassign the bug to
hicolor-icon-theme and change severity to wishlist. Lazy but effective.
Hopefully. ;)

Another solution would be something like adding multiple search paths to
QT's icon loader for the non-{GNOME,KDE} case. Because I *do* have
"gnome", "oxygen" and "crystalsvg" all installed, QT's just not
searching for them.

From a quick look at the code, I guess it's possible to copy the
fallbackTheme function to allFallbackThemes() and return QStringList
instead of QString containing all of the icon themes in the last else
branch.

(patch attached, completely untested)


Cheers

On 04/25/11 01:08, Adrian Knoth wrote:

Hi!

This patch works, at least I now have fancy icons in minitube. ;) (see
attachment)

tag 623736 moreinfo
thanks

Hi! Is this bug still present? I have looked into the patch and it might be
considered a new feature, so I really doubt we could push it upstream.


Kinds regards, Lisandro.

-- 
Greeting,

I have access to very vital information that can be used to
move huge amounts of money.

If it was possible for me to do it alone I would not
have bothered contacting you. Ultimately I need you to play an
important role in the completion of this business transaction.

Regards,
Mr Alexander Bulyanda