#637126 git-buildpackage: git-import-orig fails if it can't cd into the extracted directory

Package:
git-buildpackage
Source:
git-buildpackage
Submitter:
Etienne Millon
Date:
2011-08-09 15:45:04 UTC
Severity:
wishlist
#637126#5
Date:
2011-08-08 16:46:40 UTC
From:
To:
Hello,

I tried to import a tarball with git-import-orig but it fails with a
uninformative error :

    $ git import-orig --pristine-tar ../rss2email_2.71.orig.tar.gz
    What is the upstream version? [2.71]
    gbp:info: Importing '../rss2email_2.71.orig.tar.gz' to branch 'upstream'...
    gbp:info: Source package is rss2email
    gbp:info: Upstream version is 2.71
    fatal: Could not switch to '../tmpdCS4lT/rss2email-2.71': Permission denied
    gbp:error: git returned 128
    gbp:error: Couldn't add files
    gbp:error: Import of ../rss2email_2.71.orig.tar.gz failed
    rm: cannot remove `../tmpdCS4lT/rss2email-2.71': Permission denied
    gbp:error: rm returned 1
    gbp:error: Couldn't remove "../tmpdCS4lT"
    gbp:error: Removal of tmptree ../tmpdCS4lT failed.

The problem is that the permissions inside the tarball do not allow to cd into
the directory.

    $ tar tzvf ../rss2email_2.71.orig.tar.gz
    d--------- lsmith/None       0 2011-03-04 18:40 rss2email-2.71/
    ---------- lsmith/None    7300 2011-03-04 18:11 rss2email-2.71/CHANGELOG
    ---------- lsmith/None    3267 2010-11-12 19:34 rss2email-2.71/config.py.example
    ---------- lsmith/None  168065 2011-02-20 23:41 rss2email-2.71/feedparser.py
    ---------- lsmith/None   14847 2011-02-17 22:42 rss2email-2.71/html2text.py
    ---------- lsmith/None      43 2006-03-17 00:43 rss2email-2.71/r2e
    ---------- lsmith/None      58 2006-03-17 00:43 rss2email-2.71/r2e.bat
    ---------- lsmith/None    7208 2009-12-21 23:04 rss2email-2.71/readme.html
    ---------- lsmith/None   31352 2011-03-04 17:51 rss2email-2.71/rss2email.py

The tarball is a bit buggy (and I noticed upstream about it) but I
suggest that git-import-orig could either accept it (chmod()ing the
files before) or reject it with a clearer error message.

Thanks for maintaining this package !
#637126#10
Date:
2011-08-08 17:08:33 UTC
From:
To:
tags 637126 +wontfix
thanks

Isn't this informative? I'm not convined we should get into the business
of fixing up buggy upstream tarballs (making the import take even
longer) but I'm open for suggestions.
Cheers,
 -- Guido
#637126#17
Date:
2011-08-09 15:42:45 UTC
From:
To:
* Guido Günther <agx@sigxcpu.org> [110808 22:29]:

You are right, that's probably fine. I assumed that the tarball could
work as is and that git-import-orig was blocking, but dpkg-source
complains (rightfully), so repacking is necessary in this case.

Sorry for the annoyance and thanks again for this package !