#645958 mk-sbuild: distro name based files not retrieved for customized sources.list

Package:
ubuntu-dev-tools
Source:
ubuntu-dev-tools
Submitter:
Laurent Declercq
Date:
2011-12-21 20:03:03 UTC
Severity:
normal
#645958#5
Date:
2011-10-19 22:39:02 UTC
From:
To:
In the mk-sbuild man (1), we can read the following:

....
       $HOME/.mk-sbuild.sources[.$DISTRO]
              Can  contain  a customized sources.list.  It will be read when
creating the schroot.  If a file with ".ubuntu" or ".debian" is found (based
              on the --distro argument) that file will use used instead.  See
sources.list(5) for more details on the format.
....

Seem that for now, the [.$DISTRO] based file for customized sources.list are
not retrieved because not implemented in the script. Should be easy to fix. I
can provide a patch if you want.

BTW: Also, look at the typo issue in the man (... that file will use used
instead...)
#645958#10
Date:
2011-10-19 22:59:29 UTC
From:
To:
Am Donnerstag, den 20.10.2011, 00:39 +0200 schrieb Laurent Declercq:

That would be nice. You could create a branch (from lp:ubuntu-dev-tools)
and request a merge if you prefer Bazaar over sending patches to bug
reports.
#645958#15
Date:
2011-10-20 05:24:39 UTC
From:
To:
Well, I'm using svn and git. I've never worked with bzr yet. I prefer provide a
patch for that thing and will see for further contribution. My patch is ok,
hopefully.

Thank for interest.
#645958#20
Date:
2011-10-20 06:18:34 UTC
From:
To:
I'm sorry but my patch is wrong. I've forgot that we also can define a
customized sources.list by using the TEMPLATE_SOURCES variable via the ~/.mk-
sbuild.rc file (btw: not documented in the man).

Well, I'm a bit annoyed here. for now, we can setup a customized sources.list
in many ways:
        - via the ~/.mk-sbuild.rc file by using the TEMPLATE_SOURCES variable
        - via the ~/.mk-sbuild.sources
        - via a specific distro based file, such as ~/.mk-sbuild.sources.debian

My question here is: In which order we must treat these possibilities when
several of them are being used?

I wait your answer to create the patch.

Thanks for interest.
#645958#25
Date:
2011-10-20 12:52:44 UTC
From:
To:
Hi Laurent (2011.10.20_08:18:34_+0200)

BTW, you don't have to use reportbug to reply to this bug, you can just
reply to the e-mail. As long as a copy goes to 645958@bugs.debian.org,
it will be added to the bug page.

Please feel free to provide patches for the manpages too :)

(which is just a default value for TEMPLATE_SOURCES)

Not yet, but with your patch, yes.
 ${TEMPLATE_SOURCES}.${DISTRO}
 $TEMPLATE_SOURCES
(and $TEMPLATE_SOURCES has a default value)

Even better, if we can find a way to use the _MIRROR variables (in
.devscripts / environment) that other ubuntu-dev-tools packages use.
See ubuntu-dev-tools(5).

SR
#645958#30
Date:
2011-10-20 18:32:44 UTC
From:
To:
Le 20/10/2011 14:52, Stefano Rivera a écrit :

Sure, It's what I've tried first but it seem that  my smtp host was
rejected for unknown reason, and that explains why I've used reportbug.
I'm sorry for that.

Ok, in this case, I'll fetch the debian package (source) to work on the
man page..

Sure :p

Ok, I'll do like this.

I'll inspect that too to see what you mean exactly.

It's always a pleasure for me to help Debian community and I'll try to
do the better.

Thanks for interest.


Laurent Declercq
#645958#35
Date:
2011-12-21 20:01:51 UTC
From:
To:
Hi Declercq (2011.10.20_20:32:44_+0200)

Ping?

SR