#652346 git-gui: preferences window looks like part of parent

Package:
git-gui
Source:
git
Submitter:
Date:
2011-12-16 13:33:16 UTC
Severity:
normal
#652346#5
Date:
2008-09-01 22:11:38 UTC
From:
To:
The UTF-8 characters are not show, instead some double garbage characters are shown
in the modification view panel.
#652346#10
Date:
2009-01-13 02:24:22 UTC
From:
To:
As in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=497469
I also see junk with e.g.,
$ git gui blame git-gui/po/zh_cn.po
#652346#15
Date:
2009-02-17 09:34:11 UTC
From:
To:
Hi, this display fine for me with
 $ git gui --version
 git-gui version 0.12.0
 $ git version
 git version 1.6.1.3
 $

Can you confirm?  Thanks, Gerrit.
#652346#18
Date:
2009-02-17 09:34:11 UTC
From:
To:
Hi, this display fine for me with
 $ git gui --version
 git-gui version 0.12.0
 $ git version
 git version 1.6.1.3
 $

Can you confirm?  Thanks, Gerrit.
#652346#23
Date:
2009-02-17 20:37:01 UTC
From:
To:
retitle 497469 button problems
thanks

GP> On Tue, Jan 13, 2009 at 10:24:22AM +0800, jidanni@jidanni.org wrote:

GP> Hi, this display fine for me with
GP>  $ git gui --version
GP>  git-gui version 0.12.0
GP>  $ git version
GP>  git version 1.6.1.3
GP>  $

GP> Can you confirm?  Thanks, Gerrit.

OK, I see the Chinese now.

However one then wishes to make the font bigger than size 10 to make
it clearer, but there is some problem with the preference buttons so I
was unable to complete any size changing...
#652346#30
Date:
2009-02-17 20:48:07 UTC
From:
To:
;).  Hi, I'm not that much in GUIs.  Can you report upstream?, that'd be
nice.

Thanks, Gerrit.
#652346#35
Date:
2009-02-17 21:20:51 UTC
From:
To:
$ git gui blame some_file
Click edit->options.
The "options" window then appears directly on top of the file viewer
window.
It is shifted vertically, but not horizontally.
It needs to be shifted horizontally too.
Or else the user will just click edit->options again, getting into
deep trouble.
GP> Hi, I'm not that much in GUIs.  Can you report upstream?, that'd
GP> be nice.
OK. Cc'ing them. They should see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=497469 .
#652346#42
Date:
2009-03-12 20:53:21 UTC
From:
To:
Gerrit Pape wrote:

$ git gui --version
git-gui version 0.12.0
$ git version
git version 1.6.2

shows the UTF-8 charakters ok.

but:

$ apt-show-versions | grep git-gui
git-gui/testing uptodate 1:1.6.2-1

it's from testing. current stable - lenny is not going to be fixed?

second notice is that the git-gui, git-svn and all the "git-* friends"
are gone now. This is a bug or a feature?

cheers,
jozef
#652346#47
Date:
2009-03-12 20:53:21 UTC
From:
To:
Gerrit Pape wrote:

$ git gui --version
git-gui version 0.12.0
$ git version
git version 1.6.2

shows the UTF-8 charakters ok.

but:

$ apt-show-versions | grep git-gui
git-gui/testing uptodate 1:1.6.2-1

it's from testing. current stable - lenny is not going to be fixed?

second notice is that the git-gui, git-svn and all the "git-* friends"
are gone now. This is a bug or a feature?

cheers,
jozef
#652346#50
Date:
2009-03-12 20:53:21 UTC
From:
To:
Gerrit Pape wrote:

$ git gui --version
git-gui version 0.12.0
$ git version
git version 1.6.2

shows the UTF-8 charakters ok.

but:

$ apt-show-versions | grep git-gui
git-gui/testing uptodate 1:1.6.2-1

it's from testing. current stable - lenny is not going to be fixed?

second notice is that the git-gui, git-svn and all the "git-* friends"
are gone now. This is a bug or a feature?

cheers,
jozef
#652346#55
Date:
2009-03-13 09:43:44 UTC
From:
To:
Yes, if the bug is in lenny, it most probably will not be fixed in
lenny.

Please see /usr/share/doc/git-core/NEWS.Debian.gz

Regards, Gerrit.
#652346#66
Date:
2011-12-16 13:31:30 UTC
From:
To:
clone 497469 -1
retitle 497469 git-gui: the UTF-8 characters are shown as garbage
submitter -1 jidanni@jidanni.org
retitle -1 git-gui: preferences window looks like part of parent
quit

Hi,

積丹尼 wrote:

Could you explain further?  I tried following your recipe, and I didn't
find myself tempted to click Edit → Options again.  For comparison,
the preferences dialog for gitk seems to always appear in the top-left
corner of the monitor.

Which is not to say that the current positioning seems particularly
sane.  The code does

	wm geometry $w "+[winfo rootx .]+[winfo rooty .]"

which based on tcl documentation should put the top-left edge of the
window at an (x, y) position on the _screen_ (whatever that means)
equal to the (x, y) position of the upper-left corner of the current
window in the _root window of the screen_ (again, whatever that
means).  In practice, that seems to put it at the left edge of my
monitor, right below the menu bar when my git-gui window is on the
left side of the screen, and in the dead center of the screen when my
git-gui window is on the right.  Don't ask me way.

I guess a link to some relevant UI guidelines document might help
decide what the right thing to do is, or if this is just UI design
101, let me know and I'll pass it upstream (that's to Pat Thoyts).

Thanks,
Jonathan