#681694 brasero: Properly watch the child process state

Package:
src:brasero
Source:
brasero
Submitter:
George Danchev
Date:
2021-05-24 00:33:04 UTC
Severity:
normal
Tags:
#681694#5
Date:
2012-07-15 17:41:37 UTC
From:
To:
Dear Maintainer,

Please consider answering these questions, where appropriate ***

In libbrasero-burn/burn-process.c:brasero_process_watch_child (gpointer data)

waitpid() could have returned positive value (child's pid) due to the
child's change of state, e.g. child being signalled for any (obscure)
reason (SIGPIPE, SIGSTOP, etc), and also child's exit status is being
blindly "examined" by flat WEXITSTATUS(status), instead of first checking
WIFEXITED(status) for returning true, i.e. that the child has actually exited.

This could lead to unnoticed problem with the child process state. For
instance, I think the log message [1] of "process finished with status
0" could be pretty much bogus in this particular case shown in the log with
a burn failure halfway around ~49-50%. (see the tail of waitpid(2) for a good
example of a diligent parent waiting for their possibly naughty child)

[1] https://launchpadlibrarian.net/71440716/brasero_log.txt

#681694#16
Date:
2014-10-04 15:46:05 UTC
From:
To:
close 681694 3.10.0-2
thanks

Hi,

This should be fixed in the version 3.10.0-2 currently in unstable/jessie.

https://git.gnome.org/browse/brasero/commit/?id=6d6ff976dca4644b19521fc42638ccc23e5e0742

Closing this bugreport,

Cheers,

Laurent Bigonville

#681694#21
Date:
2014-10-04 16:03:09 UTC
From:
To:
notfixed 681694 3.10.0-2
reopen 681694
thanks

Oups

#681694#32
Date:
2021-05-23 22:33:54 UTC
From:
To:
forwarded 681694 https://gitlab.gnome.org/GNOME/brasero/-/issues/274
tags 681694 - fixed-upstream
thanks

The bug has been migrated to GNOME's GitLab instance and was incorrectly tagged as fixed-upstream.