#694539 invalid executable path in upstart init file

Package:
lightdm
Source:
lightdm
Description:
simple display manager
Submitter:
Jelmer Vernooij
Date:
2012-11-28 12:39:05 UTC
Severity:
normal
Tags:
#694539#5
Date:
2012-11-27 13:27:04 UTC
From:
To:
lightdm's /etc/init/lightdm.conf file tries to run lightdm from
/usr/bin/lightdm while it is in fact installed as /usr/sbin/lightdm.

The attached patch fixes the path.

- -- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.6-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lightdm depends on:
ii  adduser                                3.113+nmu3
ii  consolekit                             0.4.5-3.1
ii  dbus                                   1.6.8-1
ii  debconf [debconf-2.0]                  1.5.46
ii  libc6                                  2.16-0experimental1
ii  libglib2.0-0                           2.34.2-1
ii  libpam0g                               1.1.3-7.1
ii  libxcb1                                1.8.1-2
ii  libxdmcp6                              1:1.1.1-1
ii  lightdm-gtk-greeter [lightdm-greeter]  1.3.1-1

Versions of packages lightdm recommends:
ii  xserver-xorg  1:7.7+1

Versions of packages lightdm suggests:
ii  accountsservice  0.6.24-1
ii  upower           0.9.17-1

- -- Configuration Files:
/etc/init/lightdm.conf changed [not included]
/etc/lightdm/lightdm.conf changed [not included]

- -- debconf information:
  lightdm/daemon_name: /usr/sbin/lightdm
* shared/default-x-display-manager: lightdm
iQIcBAEBAgAGBQJQtL+RAAoJEACAbyvXKaRXz7cP/RQ6qjx4eVm2DkAQ4/PG4jpj
/cPAhHwuM/MVEAFZjm2EZaWMXS50khnylKI7ET4h9JAHC4I8Y7MSF0xap66CqXZy
yHOmb8Pblra1zxBhJ95UcGYQfbg6admmXrt9MsTL2r27FvNG+0NHzCIVMsGQfQ8q
qNWYVTs50ZME3fody8RCInqwWAtnJhnekqMlfDzN/RuVrG9lVGMHHJGVAprsvbSJ
ciGH/HONxMzKsZiqxXck1Tc/M3MM9Ldn7My0jsj4C0dRh4GG2eVusdgnr6aL2kK/
Fz5LUKzLEXkPvO2mraLbWHXCUCBSlKIIg3WDnG1c9i/3EbgK6UUmZwyFcONy21wy
9EbcMDy7pkpGvH453apq7kZ1GFaQDVrc2LhAhD8/465C94j1suYzn8sjgt1Mn2MX
1psF5EMJBfCQZDB4adS0UfthP2V0VZVuxQ453PmxcowH8Zw3O36nYixb+rqzy9Rt
/xKV6UpcpjhOmOniH7hiBJUhXCrIGEulimxztn+fFOeI8ktlXm/Cic4lKik4qJnu
QNV6Q/h+jX3cK44bHH9F7IDw2go3c/ldBOZKkoIXOcXUOqGcJ51KpXxKOgOj0TuR
aW3egTexpraRCNd1KONkd0ukhObyNrsLZy53/3grP624UTlgXIvkEtIM+pMgPmaY
0w6YCjHKc/PDawMWO1Vl
=DTxe
-----END PGP SIGNATURE-----

#694539#10
Date:
2012-11-27 23:26:35 UTC
From:
To:
Hi,

we removed the upstart init file for Wheezy because of #679409. I'm a
bit unsure if it was the same problem or not, if the upstart file
changed before 1.4 or something.

I'm adding Steve and Roger on CC: in case they have an opinion on this,
but I'd be happy to include the patch if it fixes upstart support in
lightdm (although I can't test).

Regards,

#694539#15
Date:
2012-11-27 23:47:33 UTC
From:
To:
FWIW it works for me with the patch applied and the latest upstart in
sid.

Cheers,

Jelmer

#694539#20
Date:
2012-11-28 02:00:02 UTC
From:
To:
I'm at a loss to explain how this could be so.  Is the file below, taken
from the lightdm source, the correct one?  Because it contains no 'start on'
condition at all (nor a 'stop on'), which means the service would never be
automatically started at boot.

# lightdm - LightDM display manager
#
# The display manager service manages the X servers running on the
# system, providing login and auto-login services

description     "LightDM Display Manager"
author          "Robert Ancell <robert.ancell@gmail.com>"

emits login-session-start
emits desktop-session-start

exec /usr/bin/lightdm


For the record, the upstart job in Ubuntu has this start condition:

start on ((filesystem
           and runlevel [!06]
           and started dbus
           and (drm-device-added card0 PRIMARY_DEVICE_FOR_DISPLAY=1
                or stopped udev-fallback-graphics))
          or runlevel PREVLEVEL=S)

All of these events are now provided at boot on a Debian unstable system
with the exception of 'started dbus'.  AFAICS, lightdm can't add an upstart
job back until dbus is upstartified in Debian.

#694539#25
Date:
2012-11-28 12:35:50 UTC
From:
To:
I was manually starting lightdm ("service lightdm start"). That didn't
work without this patch but works with it.

Cheers,

Jelmer