#705721 nis: missing -r option to makedbm for netgrp targets

Package:
ypserv
Source:
ypserv
Description:
Server daemon for working with Network Information System (NIS)
Submitter:
Vincent McIntyre
Date:
2021-01-24 15:45:09 UTC
Severity:
minor
Tags:
#705721#5
Date:
2013-04-19 04:40:13 UTC
From:
To:
*** Please type your report below this line ***

Hi,

our netgroups map has a good number of comment lines,
some of which generate warnings like this:

  makedbm: warning: malformed input data (ignored)

The patch below turns on the -r option of makedbm when making
the netgroup-related maps. This avoids the warning and does not
seem to have any ill effects. Is it worth applying?

Kind regards
Vince
--- nis-3.17/ypserv-2.19/scripts/ypMakefile.in	2013-04-19 14:23:04.000000000 +1000
+++ nis-3.17/ypserv-2.19/scripts/ypMakefile.in.new	2013-04-19 14:22:16.850121981 +1000
@@ -205,21 +205,21 @@
 netgroup: $(NETGROUP) $(YPDIR)/Makefile
 	@echo "Updating $@..."
 	@$(AWK) '{ if ($$1 != "" && $$1 !~ "#" && $$1 != "+") \
-		print $$0 }' $(NETGROUP) | $(DBLOAD) -i $(NETGROUP) \
+		print $$0 }' $(NETGROUP) | $(DBLOAD) -r -i $(NETGROUP) \
 		 -o $(YPMAPDIR)/$@ - $@
 	-@$(NOPUSH) || $(YPPUSH) -d $(DOMAIN) $@


 netgroup.byhost: $(NETGROUP) $(YPDIR)/Makefile
 	@echo "Updating $@..."
-	@$(REVNETGROUP) -h < $(NETGROUP) | $(DBLOAD) -i $(NETGROUP) \
+	@$(REVNETGROUP) -h < $(NETGROUP) | $(DBLOAD) -r -i $(NETGROUP) \
 		-o $(YPMAPDIR)/$@ - $@
 	-@$(NOPUSH) || $(YPPUSH) -d $(DOMAIN) $@


 netgroup.byuser: $(NETGROUP) $(YPDIR)/Makefile
 	@echo "Updating $@..."
-	@$(REVNETGROUP) -u < $(NETGROUP) | $(DBLOAD) -i $(NETGROUP) \
+	@$(REVNETGROUP) -u < $(NETGROUP) | $(DBLOAD) -r -i $(NETGROUP) \
 		-o $(YPMAPDIR)/$@ - $@
 	-@$(NOPUSH) || $(YPPUSH) -d $(DOMAIN) $@