#714626 please check for redundant search paths

#714626#5
Date:
2013-07-01 12:39:58 UTC
From:
To:
Please check for redundant search paths for -I and -L flags, which are already
included in the search paths of the compiler.

That is, things like

  /usr/{include,lib}
  /usr/local/{include,lib}
  /usr/{include,lib}/<multiarch>
  /usr/local/{include,lib}/<multiarch>

There are some cases where these flags have unwanted effects:

 - For -I a header included with #include_next <file> is potentially
   found in the wrong location.

 - for -L (and then -Wl,--rpath flags), some systems add the rpath
   automatically, which later needs to be stripped from the
   resulting binary (via chrpath(1)), because the resulting lintian
   error is a reason for auto-reject on upload.

#714626#10
Date:
2013-08-14 04:07:37 UTC
From:
To:
forwarded 712485 Simon Ruderich <simon@ruderich.org>
forwarded 714626 Simon Ruderich <simon@ruderich.org>
forwarded 714628 Simon Ruderich <simon@ruderich.org>
forwarded 714630 Simon Ruderich <simon@ruderich.org>
forwarded 717598 Simon Ruderich <simon@ruderich.org>
forwarded 719656 Simon Ruderich <simon@ruderich.org>
thanks

Hi Simon,

Could you take a look at these bugs:

http://bugs.debian.org/blhc

Thanks,
Jari

#714626#17
Date:
2013-08-14 22:15:20 UTC
From:
To:
Hello Matthias,

Sorry for the late reply.

Implementing this should be straight-forward, but I'm not sure if
blhc is the best place to add this.

Bernhard, what do you think? Should this get implemented in blhc
or in your general buildd log scanner (btw. are the sources of
the buildd log scanner available)? If you think blhc is the right
place, what buildd-mode messages (e.g. I-foo, W-foo) should I
use?

Regards
Simon

#714626#22
Date:
2013-08-15 05:32:04 UTC
From:
To:
* Simon Ruderich <simon@ruderich.org> [130815 00:20]:

I'm also undecided which is the best place. As blhc already looks at
similar flags it might be easy to add there, but then it is quite a
different check compared to those blhc has.

If you consider it something blhc should do, I'd suggest something like
W-dangerous-search-path. Otherwise I'll add a new rule to my log
scanner.

The scanner itself is available at git://anonscm.debian.org/qa/bls.git,
the rules are embedded in their descriptions at
http://anonscm.debian.org/viewvc/qa/trunk/data/bls/descriptions/

        Bernhard R. Link