#716524 [Mayhem] Bug report on open-invaders: open-invaders crashes with exit status 139

Package:
open-invaders
Source:
open-invaders
Description:
Space Invaders clone
Submitter:
Alexandre Rebert
Date:
2021-05-21 00:24:03 UTC
Severity:
normal
#716524#5
Date:
2013-07-10 19:37:52 UTC
From:
To:
open-invaders crashes with exit status 139. We confirmed the crash by
re-running it in a fresh debian unstable installation.

The attachment [1] contains a testcase (under ./crash) crashing the
program. It ensures that you can easily reproduce the bug. Additionally,
under ./crash_info/, we include more information about the crash such as
a core dump, the dmesg generated by the crash, and its output.

Regards,
The Mayhem Team (Alexandre Rebert, Thanassis Avgerinos, Sang Kil Cha, David Brumley, Manuel Egele)
Cylab, Carnegie Mellon University

[1] http://www.forallsecure.com/bug-reports/5ee2cc15c3491d918c17d2370d304e5b3dafdd71/full_report

#716524#10
Date:
2021-05-21 00:20:10 UTC
From:
To:
Dear Debian QA Group,

Thanks for keeping this game going in Debian.

This bug report seemed partly automated and did not fully explain what the
bug was, so I thought I would clarify it. If open-invaders is started
without an X display, e.g. if DISPLAY is unset, then it segfaults instead
of exiting gracefully:

$ unset DISPLAY
$ open-invaders
/usr/share
Segmentation fault
$

This happens because the program does not check the return code of allegro_init().

The attached patch fixes the problem.

Thanks again,
John.