#726036 ksshaskpass attempts to parse prompt as markup, discards newlines

Package:
ksshaskpass
Source:
ksshaskpass
Description:
interactively prompt users for a passphrase for ssh-add
Submitter:
chrysn
Date:
2013-10-11 12:48:06 UTC
Severity:
normal
#726036#5
Date:
2013-10-11 12:44:10 UTC
From:
To:
$ ksshaskpass "f<b>oo</b> bar"

when ksshaskpass gets passed text containing '<' characters, it
interprets them as markup, contrary to what the classical ssh-askpass
(and all other askpass implementations i'm aware of, apart from
ssh-askpass-fullscreen which the same bug was reported against[1]) does.

in the same vein, newlines in the input are silently discarded, while
all other impementations show them as line breaks.

tracing this down in the code, i read the KPasswordDialog::setPrompt
function, which passes the input data to QLabel::setText without ever
calling QLabel::setTextFormat. not sure how to tell the KPasswordDialog
to consider the text plain text properly.

please bring ksshaskpass in line with the other askpass implementations.


best regards
chrysn

[1] http://bugs.debian.org/568779