#731949 /usr/bin/xdg-icon-resource: unquoted path variable in the condition statement

Package:
xdg-utils
Source:
xdg-utils
Submitter:
Marius
Date:
2013-12-11 14:48:06 UTC
Severity:
normal
#731949#5
Date:
2013-12-11 14:45:08 UTC
From:
To:
Dear Maintainer,

There is unquoted icon_icon_file variable check in the condition statement:
/usr/bin/xdg-icon-resource:900:
[ $action = "install" ] && [ -f $icon_icon_file ] && DEBUG 1 "install $icon_icon_name meta file in $xdg_dir"

the variable icon_icon_file contains user-provided file path and the script fails if the path contains spaces.

Please change the line 900 to something like this:

[ $action = "install" ] && [ -f "$icon_icon_file" ] && DEBUG 1 "install $icon_icon_name meta file in $xdg_dir"

Best regards,
Marius