Hi,

Currently burp fails to build from source due to that the lockf()
function is not yet implemented for GNU/Hurd. As a workaround until it
is available use flock() instead. The attached patch fixes this problem
by using this function. All 12 tests succeed, and they are a
prerequisite for building the package.

Thanks!

We believe that the bug you reported is fixed in the latest version of
burp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 747672@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sean Whitton <spwhitton@spwhitton.name> (supplier of updated burp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 15 Jun 2016 20:14:09 +0900
Source: burp
Binary: burp
Architecture: source
Version: 1.4.40-1
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Sean Whitton <spwhitton@spwhitton.name>
Description:
 burp       - Simple cross-platform network BackUp and Restore Program
Closes: 675761 745376 747672 774715
Changes:
 burp (1.4.40-1) unstable; urgency=medium
 .
   * QA upload.
   * Set maintainer to QA team (see #820400).
   * Package new upstream release (Closes: #774715) (LP: #1515876).
     Upstream identifies version 1.4.40 as their "stable" release.
   * Apply patch from Svante Signell to fix build on the GNU Hurd
     (Closes: #675761, #747672).
   * Add Recommends: openssl (Closes: #745376).
   * Drop dpkg buildflags export from d/rules.
     Not needed at debhelper compat 9.
   * Drop build dependency on autotools-dev & dh --with entry.
     Current debhelper has dh_update_autotools_config.
   * Drop several unneeded flags & vars in override_dh_auto_configure target.
   * Drop duplicate DH_VERBOSE setting in d/rules.
   * Add dh's --parallel flag.
   * Repair d/copyright:
     - Move 'Files: *' paragraph to the top of the file
     - Move src/win32/compat/getopt.c and src/win32/compat/sys/mtio.h
       paragraphs to end of file
     - Add myself to copyright for debian/ subdir
     - Correct invalid shortname agplv3 -> AGPL-3
     - Factor out AGPL-3 license to a License: paragraph.
     - Correct invalid shortname Troy D. Hanson License -> custom1
     - Correct copyright years for src/win32/compat/sys/mtio.h
     - Correct some indentation and trailing whitespace
   * Replace burp-dbg with automatically generated burp-dbgsym.
     - Drop obsolete rules target override_dh_strip.
     - Drop obsolete burp.install.
     - Drop obsolete burp.dirs.
     - Drop obsolete burp-dbg.maintscript.
   * Drop endian.patch.
     Merged upstream.
   * Drop wait_for_backup_to_finish.patch.
     Merged upstream.
   * Refresh a patch.
   * Bump standards version to 3.9.8 (no changes required).
   * Update Vcs-* URIs.
   * Add gbp.conf.
Checksums-Sha1:
 51e0cf069f213b6fe4db29c0b8472a2778cceabd 1918 burp_1.4.40-1.dsc
 b06dbe9d1440b9e7915d35ad0c23b9d120fec10e 712937 burp_1.4.40.orig.tar.bz2
 43208ab5ddfeb5ecb636fda6f0c25c662ae67aae 22620 burp_1.4.40-1.debian.tar.xz
Checksums-Sha256:
 d69df169ed31fefb23e8d3d2bace7470908fa452024337438c413e6eae5c43f4 1918 burp_1.4.40-1.dsc
 4108eb45e14740de990d918a2adbb661d88f90de48d6e2e3a6b54fd12b16fa5e 712937 burp_1.4.40.orig.tar.bz2
 1d829d5cdbb0d91588cf919b34bb98421cf4dedeb7a175ce734c339fd96174d5 22620 burp_1.4.40-1.debian.tar.xz
Files:
 f67ce821f5bebada0a43d9b1e42a0e67 1918 utils extra burp_1.4.40-1.dsc
 4166bcd98cfcbc40c9e8c95655ec3d2f 712937 utils extra burp_1.4.40.orig.tar.bz2
 5cee3fdabbca7f7c7a27305577b6bf5f 22620 utils extra burp_1.4.40-1.debian.tar.xz
iQIcBAEBCgAGBQJXYTolAAoJEEsEP825REVATLwP/2zmKAqxBHpjXximSdTiFn1j
MTYRsb1ZILwZiWY28edMgSXiJGLxpUBK1Bws2kWuTCINRKVIuXBdY1exoiSBlr6C
mrDRHYtGnTG9sq4PeSigAZd2l2PjGTPO0jPogpTXEw1ZUD1PAeEZBWlklkUcAW4r
Qq5Gk117gOMHIRCSoimewfy5K26riSF1Pa4J//x9yXE1IiyxZJMZK9QYa5zq+yhA
cwfM2XsCadvEyr0TxY8LW86C3ck31WFyYfxD5whU+IdG9HkguvKv7B9AXMHub6Q+
NaUHfBlYIcHl+oMWb5Z8IcA0hQb+fRUyXEY05xAzHmcUQSXmyzNyHna9EHBj8Nv2
O1rnCt2bxkSDK4aOXLoZugGoXLMSzaHpwqBlNggK5W/vUOLorjgevXQQqnHpnhwB
sk+aW0rxGPXuI6iDUfEN3up+uE+Fy57k89qbZZ8wxeZGp6nuaMNZJmPFXBbW9pA+
5/RJ+j/7O2lQTxoe4UHbyeOUCpwom1WvMSvUgNMTys3bGblJJjzegurl7k9UA9E8
gFqjZivUkw+A7NajE/mqMHv7IjFZJo7mivfY5d2Nzsqo8z8mq6WhWPR2YlFSQFl4
BY877jcWqfT/3jntHV8EvczGn7ICs8F9En+lyDssT+lRV/tlsz/QKAMhM6sq3dMq
4LMrzlvIYhTRoo7fZeRL
=kES2
-----END PGP SIGNATURE-----

control: found -1 burp/1.4.40-1

Dear Svante,

Although the burp 1.4.40 test suite passes with this patch applied,
upstream reports that the 2.0.x series test suite finds a problem.  The
patch causes this problem when applied to burp 1.4.40, even though the
older test suite passes.

Since this is an old bug, I am preparing a QA upload to drop the patch
for now.

Burp's author Graham Keeling explains:

Thanks to Graham for letting me reproduce this explanation.

Hi Sean,
...

Explanation understood and appreciated!

You did the right thing to remove that patch, and reopen the bug. GNU/Hurd will
soon have lockf support too. However, the testsuite fails, sometimes also with
the lock.patch applied, ending with:
Test 3
Third backup/restore comparison, with changes
Killing test server

Since the testsuite is run by scripts it is difficult to find out the cause
using gdb. Is there some simple way to set a breakpoint to debug this issue?

Thanks!

Hello,

I saw this on the buildds, but not when I fired up a Hurd VM locally, so
indeed, it would be good to track down the intermittent failure.

As you have probably figured out yourself, most of the tests happen in
the shell script test/test_main.  You could try modifying the arguments
it passes to burp to generate more verbose output.  Or you could have
the test suite call burp inside gdb.

Dear Maintainer and debian-hurd list,

This is an old bug report and both burp and the hurd have changed since it was
opened. Currently burp FTBFS because the PATH_MAX macro is undefined in the
hurd. I attach a patch that addresses this issue and with it burp builds.
Do let me know if you have any concerns about this patch.

Best regards,
João