- Package:
- src:pbuilder
- Source:
- pbuilder
- Submitter:
- Paul Wise
- Date:
- 2021-09-22 04:47:17 UTC
- Severity:
- minor
- Tags:
According to shellcheck there are many issues with the pbuilder code, please go through the warnings, correct the valid warnings (for example there are a lot of quoting issues in the code) and file bug reports about false positives where reasonable.
Just updated pbuilder and saw this bug via apt-listbugs. As someone who has only recently started contributing to Debian and took a while to find somewhere good to jump in, I think this is a perfect bug to label as "gift". It would be a great way to familiarize newbies with tools like quilt while keeping the difficulty level of the actual coding very low (shellcheck pretty much tells you what to do! Plus, I'd imagine the vast majority of people looking to contribute to Debian via bugs have some familiarity with shell scripting!). The workload would likely need to be spread over multiple patches. I would label it myself, but I'm not part of the pbuilder maintaining team. :\ For info about the gift tag: https://wiki.debian.org/qa.debian.org/GiftTag Thanks, Caitlin
found 753966 0.215 tags 753966 +confirmed thanks Just updated pbuilder and saw this bug via apt-listbugs. As someone who has only recently started contributing to Debian and took a while to find somewhere good to jump in, I think this is a perfect bug to label as "gift". It would be a great way to familiarize newbies with tools like quilt while keeping the difficulty level of the actual coding very low (shellcheck pretty much tells you what to do! Plus, I'd imagine the vast majority of people looking to contribute to Debian via bugs have some familiarity with shell scripting!). The workload would likely need to be spread over multiple patches. I would label it myself, but I'm not part of the pbuilder maintaining team. :\ For info about the gift tag: https://wiki.debian.org/qa.debian.org/GiftTag Thanks, Caitlin
user debian-qa@lists.debian.org usertag 753966 + gift thanks It has false positives/negatives so you have to be able to understand what is going on or at least test the changes. You don't need to be the maintainer of a package to set the gift tag on one of the bugs filed against it, feel free to do that with any bug. I'm not part of the team and I've set it with this mail.
Hi, attached patches(pbuilder_patches.tar.gz) for pbuilder (pbuilder-0.215 +nmu3 - testing) zaza@zaza-debian:~/Documentos/PKG_DEBIAN/pbuilder-0.215+nmu3$ tar -ztf pbuilder_patches.tar.gz pbuilder-apt-config.patch pbuilder-buildpackage.patch pbuilder-createbuildenv.patch pbuilder-runhooks.patch pbuilder-satisfydepends-aptitude.patch pbuilder-satisfydepends-classic.patch pbuilder-satisfydepends-experimental.patch pbuilder-satisfydepends-funcs.patch pbuilder-satisfydepends-gdebi.patch pbuilder-uml-checkparams.patch pbuilder-unshare-wrapper.patch pbuilder-updatebuildenv.patch pbuilder-user-mode-linux.patch pdebuild-internal.patch pdebuild.patch pdebuild-uml-checkparams.patch pdebuild-user-mode-linux.patch there are some alerts that i need more time to check regards
Hi, for pbuilder (pbuilder-0.215 +nmu3 - testing) pbuilder-modules.patch.gz attached regards,
Hi,
i build two packages with (with patches).
with cowbuilder everything went fine. but with
vim i got some "unformatted echos". and the
prompt doesn't return properly.
see:
make[2]: Entering directory '/tmp/buildd/vim-7.4.430/src/vim-nox/testdir'
rm -f test.log
rm -rf test1.failed test.out X* viminfo tiny.vim small.vim mbyte.vim mzscheme.vim lua.vim test.ok wrongtermsize
VIMRUNTIME=../../runtime; export VIMRUNTIME; ../vim -u unix.vim -U NONE --noplugin -s dotest.in test1.in
Vim: Warning: Input is not from a terminal
rm -rf X* viminfo
rm -rf test2.failed test.ok test.out X* viminfo
cp test2.ok test.ok
# Sleep a moment to avoid that the xterm title is messed up.
# 200 msec is sufficient, but only modern sleep supports a fraction of
# a second, fall back to a second if it fails.
VIMRUNTIME=../../runtime; export VIMRUNTIME; ../vim -u unix.vim -U NONE --noplugin -s dotest.in test2.in
i would like to know if someone has this results too.
regards,
Hi, i tested pbuilder with those patches with 7 packages: cowbuilder nano xterm dialog aptitude vim cups i got the same result with the official version. there are some extra tests to do? regards,
i am sorry about the mess. i redid the tests and now i have to redo some of the patches at the end this has been good to me though. i hope you still want to see the patches regards
ok, i remade the patches. tested with pbuilder create|update|build and pdebuild i can make further tests if someone tell me what to do regards,
control: tags -1 - patch On Mon, Oct 20, 2014 at 05:14:09PM -0200, Herbert Parentes Fortes Neto wrote: Hi, and sorry for the long waiting Thanks for this patch set!! I applied most of it, where I felt confident enough that putting quotes was not wrong. There are still a lot of warnings, if someone wants to dig further at cleaning up more of them. :)
Hi Mattia Rizzolo, Good to hear! Thanks for the replay. regards,
Hello, Good morning, We have gone through your samples from a partner and Here is our Order List. Please do bear in mind that we are very much in need of this order, quote your competitive prices. Kindly send the Order confirmation. Your early reply will be much appreciated. Best Regards, Maryanah Erwin. PT FINDORA INTERNUSA Jln Pahlawan 66 Kec. Arjawinangun 45162 CIREBON West-Java INDONESIA tel : +62 231 357334 fax: +62 231 357260 email: marketing@findora.com
Hello, Good morning, We have gone through your samples from a partner and Here is our Order List. Please do bear in mind that we are very much in need of this order, quote your competitive prices. Kindly send the Order confirmation. Your early reply will be much appreciated. Best Regards, Maryanah Erwin. PT FINDORA INTERNUSA Jln Pahlawan 66 Kec. Arjawinangun 45162 CIREBON West-Java INDONESIA tel : +62 231 357334 fax: +62 231 357260 email: marketing@findora.com