#754533 libjs-pdf: please provide a minified version of compatibility.js

Package:
libjs-pdf
Source:
pdf.js
Submitter:
Johannes Schauer
Date:
2017-12-11 17:06:03 UTC
Severity:
wishlist
#754533#5
Date:
2014-07-12 07:26:27 UTC
From:
To:
Hi,

I'm packaging pdf2htmlEX (ITP #754460) and it makes use of
compatibility.js from PDF.js. Optionally it also makes use of
compatibility.min.js. Either is embedded into the HTML files it
produces. Since it's nicer to embed the minified javascript, the
packaging currently ships a minified version of compatibility.js from
libjs-pdf. This is suboptimal since it might mean that at some point in
the feature, libjs-pdf ships a minified version of an older
compatibility.js than is provided by libjs-pdf and has to be rebuilt.

Would you consider also shipping a minified version of compatibility.js
in the libjs-pdf package?

If yes, should I create a patch implementing that functionality?

Thank you for your consideration!

cheers, josch
#754533#10
Date:
2014-07-12 17:13:38 UTC
From:
To:
Hi Johannes,

Le 12/07/2014 03:26, Johannes Schauer a écrit :

Sure.

Thanks for the offer, it would be nice to propose that patch upstream too.

Regards

David
#754533#15
Date:
2014-07-12 17:15:25 UTC
From:
To:
Hi,

Quoting David Prévot (2014-07-12 19:13:38)

awesome - would you want one only for compatibility.js or also for the others
while we're at it?

I'll look into it.

Thanks!

cheers, josch
#754533#20
Date:
2014-07-12 18:28:39 UTC
From:
To:
Hi,
minified version of something else than compatibility.js, but on the
other,  compatibility.js is really not the biggest JavaScript file
distributed in this package (might even be the smaller).

Some third parties uses run-time (with cache) minification, so don’t
really need provided minified files. It would be nice to have upstream
input on the matter actually.

Regards

David
#754533#25
Date:
2014-07-12 18:41:21 UTC
From:
To:
Hi,

Quoting David Prévot (2014-07-12 20:28:39)

if I read this correctly then this problem is already solved upstream with this
commit:

https://github.com/mozilla/pdf.js/commit/e5cd75083fabf663ce67be086e4fd7b3b99a44b2

this is part of the 1.0.277 release.

So this should just be a matter of calling `nodejs make minified` in
debian/rules and installing the result.

cheers, josch
#754533#30
Date:
2014-07-12 20:28:18 UTC
From:
To:
Hi Johannes,

Actually, this target only provides minified pdf.js and pdf.worker.js,
not compatibility.js, so that won’t help fixing this specific issue.

Regards

David
#754533#35
Date:
2014-07-12 21:27:22 UTC
From:
To:
Hi,

Quoting David Prévot (2014-07-12 22:28:18)

you seem to be correct. My javascript foo is very weak but if I read it
correctly then it seems to concatenate compatibility.js together with some
other files? This indeed does not help. I opened an issue about this upstream:

https://github.com/mozilla/pdf.js/issues/5041

I hope I formulated the problem correctly.

Thank you for your help!

cheers, josch
#754533#44
Date:
2017-01-26 13:27:26 UTC
From:
To:
Dear Customer,

Your parcel was successfully delivered January 25 to USPS Station, but our courier cound not contact you.

You can download the shipment label attached!

With sincere appreciation,
Edwin Cowan,
USPS Delivery Agent.