Dear Maintainer,

The window close button does not work.

It is not obvious that one must click the mouse to get a menu.
It is not obvious that the keyboard, not the mouse, is required
to operate the menu. Some prompt would be nice.

Thanks

Hello,


If your window manager supports window decorations, e.g. with the X
symbol, you can close the window anytime. Pressing ESC twice also closes
the game.

I understand your point. Currently one has to click the left mouse
button to open the menu but otherwise the menu is keyboard driven. I
think it would be useful if mouse and keyboard actions were both
supported. Meanwhile I believe it's not too hard to figure out how to
use the menu.

Regards,

Markus

clone 760379 -1
retitle -1 tuxpuck: window close button does not work
severity -1 normal
thanks


Hi,

please keep the bug report in CC.

On 03.09.2014 19:56, Charles Evans wrote:
[...]

Ok, confirmed. Just experienced the same issue with Openbox. However the
"X" works fine with GNOME3 and Metacity. I'm not sure what's causing
this hence I'm going to clone the bug report into another one.

Thanks for the report

Markus

On Wed, 03 Sep 2014 22:04:14 +0200 Markus Koschany <apo@gambaru.de> wrote:
[...]

After more investigation I have found out that there is no consistent
way in TuxPuck to handle SDL_QUIT events.

If one adds the following code to menu.c, it becomes possible to close
the window when the main menu is activated. But the exit_, again_ and
op_menu need to be addressed differently. It would be better if there
was a single big main loop which caught all events in one place.

Not being able to close the game window by pressing the X button does
not worry me much at the moment. It seems this is also somehow intended
and closing the game works fine if you just use the in-game menu.

---
 menu.c    |  4 ++++
 tuxpuck.c | 35 ++++++++++++++++++++++++++---------
 2 files changed, 30 insertions(+), 9 deletions(-)

diff --git a/menu.c b/menu.c
index 4b8f556..d1590cf 100644
--- a/menu.c
+++ b/menu.c
@@ -177,6 +177,10 @@ int menu_get_selected(Menu * menu)
 >--  break;
 >--}
 >--break;
+      case SDL_QUIT:
+      menu->selected = -1;
+      loop = 0;
+      break;
       }
     }
     SDL_Delay(SLEEP);