#763398#5
Date:
2014-09-29 21:19:51 UTC
From:
To:
Hi,

Currently handbrake fails to build from source due to usage of
PATH_MAX, which is not defined on GNU/Hurd. Another issue is missing
linkage with libpthread, the same as for kFreeBSD, see #730976

For the PATH_MAX issues strcmp and strlen are used instead of strncmp
and strnlen, respectively. According to the submitters knowledge there
is no big difference between these functions, and the chosen functions
avoid the on some systems undefined constant PATH_MAX. If there is a
wish to keep the old code a conditional test can easily be made, please
let me know, and I'll create a patch depending on if PATH_MAX is
defined or not.

The attached patch fixes these build problems.

Thanks!

#763398#10
Date:
2014-10-04 15:17:37 UTC
From:
To:
Since I cannot test the patch, could you please forward it upstream? See
the "Submitting a patch" section at https://handbrake.fr/contribute.php.

Cheers

#763398#15
Date:
2014-10-05 14:57:27 UTC
From:
To:

#763398#20
Date:
2014-10-08 14:05:47 UTC
From:
To:
Thank you. I think you need to press "Publish request" to make it
available.

Cheers

#763398#25
Date:
2014-10-08 14:25:04 UTC
From:
To:
There must be at least one reviewer before this review request can be
published.

#763398#30
Date:
2014-10-08 14:32:06 UTC
From:
To:
Hi!

On the right side you can select groups or persons as reviewers. Using
group "build" (it should auto complete) there always worked for me.

Cheers

#763398#35
Date:
2014-10-08 14:52:38 UTC
From:
To:
Thanks for the hint, that worked.