#765111 buildd: [PATCH] buildd no longer parses wanna-build debug lines as real output

Package:
buildd
Source:
sbuild
Submitter:
Dima Kogan
Date:
2015-12-23 22:03:04 UTC
Severity:
normal
#765111#5
Date:
2014-10-13 17:38:15 UTC
From:
To:
On my local setup of buildd/sbuild/wanna-build for whatever reason the pipe that
buildd uses to talk to wanna-build produces some debugging output. These are
lines such as

 D: Setting Session Purged=0
 D: Setting Log Stream=IO::File=GLOB(0x2293200)
 D: Setting Host=Sbuild::ChrootRoot=HASH(0x22831f8)
 D: Setting SETUP=1
 D2: Pipe (PID 2694, GLOB(0x22935c0)) created for: ssh -l buildd 127.0.0.1 wanna-build --arch=amd64 --user=wbadm --api 1 --dist=sid test1_1.0-2
 Oct 13 08:52:25 buildd[2666]: D2: Environment filter: Deleted HOME
 Oct 13 08:52:25 buildd[2666]: D2: Environment filter: Deleted SSH_CLIENT
 Oct 13 08:52:25 buildd[2666]: D2: Environment filter: Deleted LANGUAGE

The code that buildd was using to parse its output was not ignoring these lines,
and would try to use them as actual wanna-build output, which clearly would fail.
This patch skips those lines.
#765111#12
Date:
2015-12-23 06:05:30 UTC
From:
To:
Hi,

I do not have a wanna-build/buildd setup over here so I can neither reproduce
your problem nor can I verify that your patch doesn't introduce any new
problems.

Could you find somebody who has a running wanna-build/buildd setup who can
verify either or better both of these things?

Thanks!

cheers, josch
#765111#19
Date:
2015-12-23 21:30:15 UTC
From:
To:
Johannes Schauer <josch@debian.org> writes:

Oh my. This is an old bug, and I really don't remember much about it
anymore. I do have a buildd setup, but really have no time to look at it
now.

I do remember that I set up the buildd by following the directions, and
hit this problem. The attached patch fixed it. The patch ignores
debug-log lines, which shouldn't look like actual input to buildd. I
don't recall what actual input looks like, but at the time I seemed
satisfied that it'll never look like the logging lines.

There was probably a bug in something else that made this happen in the
first place, so at worst this patch should be redundant.

Sorry this wasn't more helpful. I do still have my buildd, and I can
look, but now just isn't a good time. If you want to use my buildd
instance to look at it, just ask.

dima
#765111#24
Date:
2015-12-23 21:59:47 UTC
From:
To:
Hi dima,

Quoting Dima Kogan (2015-12-23 22:30:15)

no worries, there is no rush :)

I am just trying to do a big bug cleanup and wanted to see if there is more
info you can provide on this bug. Now I'll just see when I have time to look
into it myself.

Thanks!

cheers, josch