#765933 mesa-common-dev: glx.h should not include glxext.h when GL_GLEXT_LEGACY is defined

Package:
mesa-common-dev
Source:
mesa
Description:
Developer documentation for Mesa
Submitter:
Ondřej Surý
Date:
2023-01-05 11:00:10 UTC
Severity:
important
Tags:
#765933#5
Date:
2014-10-19 11:25:03 UTC
From:
To:
Dear maintainer(s),

gl.h doesn't include glext.h when GL_GLEXT_LEGACY is defined.

glx.h doesn't include glxext.h only when GLX_GLEXT_LEGACY is defined.

GLintptr is declared in glext.h and used in glxext.h, thus
applications that has defined GL_GLEXT_LEGACY and not GLX_GLEXT_LEGACY
now fails to build due missing GLintptr declaration.

I see two solutions here:

glx.h should not include glxext.h also when GL_GLEXT_LEGACY is
defined, e.g. change

#ifndef GLX_GLEXT_LEGACY

to

#if !defined(GL_GLEXT_LEGACY) && !defined(GLX_GLEXT_LEGACY)

or at least add:

#if defined(GL_GLEXT_LEGACY) && !defined(GLX_GLEXT_LEGACY)
#error You need to #define GLX_GLEXT_LEGACY when GL_GLEXT_LEGACY is used
#endif

So the users of mesa-common-dev know exactly what to fix.

(This is probably an upstream issue, right?)

Cheers,
Ondrej

#765933#10
Date:
2014-10-19 18:13:46 UTC
From:
To:
Yes, it looks like that was introduced in 10.3 when glxext.h was synced
to a newer khronos version.

Cheers,
Julien

#765933#19
Date:
2014-11-12 15:57:45 UTC
From:
To:
Hi,

apparently bug #765933 in mesa causes a FTBFS in java3d. I think this is
a regression and easier to fix in mesa itself during the freeze instead
of patching affected packages. I am going to clone #559767 since this is
clearly a different issue and lowering the severity of the old bug to
important again. Due to the FTBFS the cloned bug is of course still serious.

Regards,

Markus

#765933#28
Date:
2014-11-22 23:34:58 UTC
From:
To:
tags 769301 patch
severity 765933 important
thanks

On Wed, 12 Nov 2014 16:57:45 +0100 Markus Koschany <apo@gambaru.de> wrote:
[...]

At a second glance fixing Java3d was easier than expected. We just
define the typedefs in Java3d. However I still think this is a bug in
mesa-common-dev but not necessarily a release-critical one. I am
downgrading #765933 to important again.

Please find the proposed patch attached to this bug report.

Markus

#765933#37
Date:
2023-01-05 10:55:29 UTC
From:
To:
The upstream bug https://bugs.freedesktop.org/show_bug.cgi?id=83631
was closed years ago.

Can the Debian bug also be closed now?