#771824 slapd: tries to reload on upgrade even with dumping disabled

Package:
slapd
Source:
openldap
Description:
OpenLDAP server (slapd)
Submitter:
Ferenc Wágner
Date:
2014-12-02 17:15:09 UTC
Severity:
normal
#771824#5
Date:
2014-11-24 13:11:19 UTC
From:
To:
Package: slapd
Version: 2.4.40-2
Severity: normal

Hi,

I wanted to manually set dumping to "never" before upgrading, because restoring
the dump breaks on partial replicas (#614569).  However, dpkg-reconfigure slapd
only asks if I want to "omit OpenLDAP server configuration", which I want, because
the replication config is hand made.  Thus I don't get to reconfigure dumping,
even though it has nothing to do with the server configuration itself.

Trying to upgrade with DEBIAN_PRIORITY=medium does not work either due to another
problem: I can switch off dumping then, and dumping is skipped all right, but the
reload is attempted regardless and fails not finding the dump.

On the other hand, I could be saved by a little additional logic.  #759597 may be
hard in general, but I use MDB, which does not need a dump/restore below 2.5,
which translates to never in Debian. :)

#771824#10
Date:
2014-11-25 00:29:13 UTC
From:
To:
Control: tags -1 confirmed

If I'm reading correctly, the value of that choice isn't actually
important here: the problem is that the question about configuring
dumping is only presented on upgrade, not when (re)configuring a new or
existing installation.

http://anonscm.debian.org/cgit/pkg-openldap/openldap.git/tree/debian/slapd.config#n174

IMO, the dumping questions could be asked outside of that guard, even on
initial installation (and certainly on reconfiguration), with a low
priority.

That's a bug, for sure. dump_databases() exits early if dumping is
disabled, but the symmetric check in load_databases() is missing. That
doesn't make a lot of sense. :)

#771824#17
Date:
2014-12-02 10:27:47 UTC
From:
To:
Ryan Tandy <ryan@nardis.ca> writes:

Agreed.

Also agreed.

Now, do you plan to do anything about these for jessie?  As I understand
it, anybody running a partial replica will necessarily hit this during
the wheezy -> jessie upgrade.  But we've still got a couple of days to
get an unblock for these fixes...

#771824#24
Date:
2014-12-02 17:03:58 UTC
From:
To:
Control: clone 770827 -2
Control: retitle -2 slapd: tries to reload on upgrade even with dumping disabled
Control: severity 614569 important

Just to be clear, we're talking about (at least) three separate bugs:

#614569 - fails to reload a partial replica
#770827 - dpkg-reconfigure doesn't ask the dumping question
#??? - attempts database reload even with dumping set to 'never'

#770827 I think is clearly not RC. #614569 would have been good to fix
for jessie, but I personally have basically no time available at the
moment. I can't provide a well-tested fix before the 5th, sorry.

Other facts about #614569 are that it has been around for two upgrade
cycles already, and that it can be worked around by editing the postinst
to add -s to the slapadd invocation and running 'dpkg --configure -a' to
retry the upgrade.

Unless someone else wants to prepare and upload a fix in the next couple
of days, I'll fix it in unstable later and then propose it for a point
release of jessie. I'm also monitoring some lmdb issues being worked on
upstream, in case some of the patches turn out to be suitable for a
point release.

I doubt this was the answer you hoped for; sorry for that.

thanks,
Ryan