#793990 libdvd-pkg: Debconf abuse

#793990#5
Date:
2015-07-29 12:53:41 UTC
From:
To:
This package seems to use a debconf note to notify users without any
special action.

This is usually identified as "debconf abuse". Debconf notes should be
kept for for important notes that the user really should see, since
debconf will go to great pains to make sure the user sees it; halting
the install for them to press a key.  It's best to use these only for
warning about very serious problems, and the error datatype is often
more suitable.

Please consider alternative ways to warn users such as entries in
NEWS.Debian, documentation in README.Debian or error template
datatype.

If you disagree with this bug report, you're suggested to tag this bug
report as "wontfix" rather than just close it.

Please notice that this text is standardized for all packages that use
debconf inappropriately (at least in the bug submitter's opinion).

#793990#10
Date:
2015-08-06 02:08:19 UTC
From:
To:
If it is about a particular note then which one?

FYI debconf prompt was introduced by request of Ansgar (on behalf of ftp-
master) as a condition for entering archive.

libdvd-pkg uses debconf dialogs to configure or schedule important actions
that may not be possible to do when dialog is displayed.

At the moment I can't quite recognise the abuse without further hints...
--- If any remedy is tested under controlled scientific conditions and proved to be effective, it will cease to be alternative and will simply become medicine. So-called alternative medicine either hasn't been tested or it has failed its tests. -- Richard Dawkins, 2007
#793990#17
Date:
2015-08-06 04:45:12 UTC
From:
To:
Quoting Dmitry Smirnov (onlyjob@debian.org):


Any note displayed at high priority is likely to be considered debconf
abuse. All Debian users with default settings will see it.

So, this is indeed, this one:

db_input high libdvd-pkg/upgrade

It's usually highly recommended to really consider whether one wants
that every install is interrupted by such a note (in the distant past,
many packages were using that system and users were complaining about
gazillion of messages popping up during installs).

#793990#22
Date:
2015-08-06 23:29:44 UTC
From:
To:
Upgrade note is fully justified and necessary. It is shown only when
automatic upgrades are disabled (as configured by user) to notify user when
manual action is required in order to avoid situation when upgrade never
installed because user did not know about it.

This package can not function properly without upgrade note (which is
essential). Upgrade note will not be seen if package configured to install
upgrades automatically. A reasonable precautions to avoid abusing debconf
were already taken.
--- If you travel the earth, you will find it is largely divided into two classes of people - people who say "I wonder why such and such is not done" and people who say "Now who is going to prevent me from doing that thing?" -- Winston Churchill
#793990#27
Date:
2015-08-07 06:27:28 UTC
From:
To:
Quoting Dmitry Smirnov (onlyjob@debian.org):


Well, if you think that's the case, feel free to close the bug, then,
or mark it wonfix.

It won't make me like debconf notes better (if Joey Hess was still
around, you might want to ask him about them, he would say that
inventing debconf nontes wsa the worst idea he probably ever
had...)....but I already had cases in the "debconf abuse" bug reports,
where maintainers disagreed with me and we finally agreed to.....just
disagreee..and bugs were either close or marked "wontfix":-)

#793990#32
Date:
2015-08-07 08:55:16 UTC
From:
To:
I understand that situation with debconf notes is not ideal...
Unfortunately I see no solution to this problem for this particular package.
FYI my original implementation did not have that note and it was introduced
on ftp-masters demand because (as everyone agreed) package should not do
unexpected things and this one is already unusual enough...
--- The Santa myth is one of the most effective means ever devised for intimidating children, eroding their self-esteem, twisting their behavior, warping their values, and slowing their development of critical thinking skills. -- Tom Flynn, "The Trouble with Christmas"