#795363 debcherry: From_ line contains noise

Package:
gitpkg
Source:
gitpkg
Submitter:
Florian Schlichting
Date:
2015-08-14 20:27:03 UTC
Severity:
minor
#795363#5
Date:
2015-08-13 10:48:17 UTC
From:
To:
The patches produced by git-debcherry start with a From_ line
referencing a commit hash from the temporary repository. While the line
itself might be needed in order to be able to feed the patch to git am,
the noise could be replaced by a helpful note like "exported by
git-debcherry" or some such.
#795363#10
Date:
2015-08-13 11:05:47 UTC
From:
To:
Hi Florian,

Yes, that got noticed while we were looking at the fix for #772626 to
remove the automatic signatures with the git version, which did much
the same thing.  It's not quite clear yet exactly what the best thing
to do about that will be, but it is on the radar for things to improve.

  Cheers,
  Ron
#795363#15
Date:
2015-08-14 20:22:40 UTC
From:
To:
While experimenting with debcherry for use in pkg-perl and discussing
things with David, I noticed two related sources of "noise" in the
generated patches:

- the Subject line contains [PATCH] with a number (like "[PATCH 2/3]"),
  which causes noise in all patches if another patch is added or
  dropped. This is simple to fix by adding --no-numbered to the two
  lower calls of git format-patch

- the diff contains an "index" line with short hashes from the temporary
  repository (meaningless, volatile). I'm currently filtering it out
  with the line

            next if /^diff --git a/../^--- a/ and /^index /;

  in a post-processing script that adds the content of git notes to the
  generated patches.

Florian