#798465 grub-installer: Please show size as well as the device id when selecting target

#798465#5
Date:
2015-09-09 17:01:28 UTC
From:
To:
Hi,

On a recent install, I had to switch to the console during the as the
/dev/sdX names and device IDs were not sufficient for me to be 100% sure
I was installing grub to the right device.

Showing the device sizes would have been enough for me to avoid this (as
the sizes were widely different), and would provide a reassurance in
other cases where I was merely slightly uncertain.

Patch attached. I've retained the double-space between the device path
and the start of the metadata. Example screenshot here:
http://i.imgur.com/JSXrJ48.png


Regards,

#798465#10
Date:
2015-09-09 17:31:10 UTC
From:
To:
Chris Lamb, le Wed 09 Sep 2015 18:01:28 +0100, a écrit :

That can be useful indeed. Perhaps rather show the size first, like in
partman, in case the name is really long?

Samuel

#798465#15
Date:
2015-09-09 17:42:24 UTC
From:
To:
Samuel Thibault wrote:

I also thought of this, but a combination of device identifiers often
only varying in their suffix and device sizes hardly being unique (!),
for safety I believe we should prioritise showing the id before any
possible truncation occurs.


Regards,