The passwordsafe package uses pugixml, but requires wchar to be enabled.  If a
wchar enabled version (see pugiconfig.hpp) was included along side the current
version, I could remove the embedded copy of pugixml from passwordsafe and
depend on the packaged version instead.

Hey William,

Very very sorry about such a delayed response.

William Blough <devel@blough.us> writes:

Is it OK to enable this in default version itself instead of creating
one more version?. Will it create any problems?.

Best Regards,

No worries.

It would be fine for my use case, but I don't know how it would affect
other users.  I'm thinking it would probably be fine, as a nonwide char
should fit in a wide char.  But I don't really work with wide charsets
that much, so my intuition may be wrong.

Hello,

isn't this an ABI breaking change?
please check if reverse-dependencies still work with the same ABI versioning and wchar enabled, and provide a patch to make a proper transition.

I can help there, but I lack the time to do proper checks.

this should be the list of actual reverse dependencies.

* darktable
* filezilla
* ismrmrd
* libkiwix
* libsavitar
* mkvtoolnix
* orthanc
* orthanc-dicomweb
* vdr-plugin-satip

thanks!

if you confirm that the ABI is still the same, then I'll fix this old bug, otherwise I'll request a transition slot
and fix it in experimental! :)

G.

I'm not sure.  This is why I suggested a separate version which could be
marked as conflicting with the existing verison.  This would at least guarantee
that existing reverse dependencies wouldn't break.  I realize now that this
probably isn't a simple as it sounds.

If it's an ABI change, that can be handled, but I'm worried about
non-ABI-related behavior changes breaking existing packages.  I can try
to test for some of those issues, but as I'm not familiar with any of the
reverse dependencies, I'm concerned I may miss edge cases.

That said, I'll look into it and see what I can figure out.

Thanks,

Bill

Hello,


we can separate the library in two binaries, as you suggested, and let current
packages choose their best flavour (so, no transition would be needed).

I did add "-DBUILD_DEFINES=PUGIXML_WCHAR_MODE" and the resulting library was using wchar,
so the change to enabled it is trivial.

Unfortunately I don't really speak cdbs, so I don't really know what to change to enable
double builds, but since the package is on salsa.debian.org/debian namespace,
everybody is free to commit and push in unstable, (Jonas even asked me on irc
to co-maintain the package), so as long as you push in experimental,
and check reverse-dependencies, I don't see troubles in fixing this bug!

thanks in advance for caring!

Gianfranco

block 801727 by 911805
thanks

I looked at this a little back when we discussed it, but it looked like
it was going to take more time than I had right then, so I put it off.

I recently had time to dig into this properly, but have hit a snag.

After several hours of testing and tweaking, and reading cdbs files,
it appears that the multiple builds work under autotools, but not under
cmake.

I've opened  #911805 against cdbs requesting that this functionality be
added for cmake.  I think that rabbit hole is a little too deep for me
to go down myself right now.

Hello William

I added a new branch on git, called experimental (git commit id: 223968b499ad5e1acdc7daf336c7e662d23a12f2), can you please have a look, build, upload if you like it? The package is on salsa, so
we can just upload if we want.

What I'm worried is that installing libpugixml1v5-wchar will force removal of libpugixml1v5 and all the reverse-dependencies using it
(e.g. poedit)

I don't know if this is what we want, but I let you choose, check/test build it and decide!

Gianfranco