#807755 check-all-the-things: binary files and VCS directories should be excluded from grep

Package:
check-all-the-things
Source:
check-all-the-things
Submitter:
David Bremner
Date:
2015-12-13 03:24:06 UTC
Severity:
normal
#807755#5
Date:
2015-12-12 13:08:58 UTC
From:
To:
,----
| $ grep -riE 'fixme|todo|hack|xxx' .
| Binary file ./.git/objects/pack/pack-0fcffb8d8c081462f453ea35973a7e961ef1fcf3.pack matches
| Binary file ./c-example.gif matches
`----

Adjust severity to taste; it happens to generate noise on the first
package I try.
#807755#10
Date:
2015-12-13 03:20:32 UTC
From:
To:
I'll have to come up with a standard way to handle exclusion of VCS
dirs, binary files and other cruft, the current method isn't
maintainable since the info is duplicated in each check.

To be honest, avoiding false positives and noise isn't really one of
the goals for check-all-the-things. I expect users to be able ignore
false positives and most noise by scrolling down in their terminal.

For more systemic noise I'll try to work out mitigation methods though.