- Package:
- dh-make-perl
- Source:
- dh-make-perl
- Submitter:
- Guillem Jover
- Date:
- 2022-06-10 16:21:03 UTC
- Severity:
- wishlist
- Tags:
[ Filing this as a bug report, to not lose track of it. ] Hi! The attached untested patch should in principle do it. In any case the available file is only ever up-to-date when using dselect, so this is probably not a very generic solution. And if it's too slow, this should be fixed in libdpkg-perl anyway as that would benefit every caller. Thanks, Guillem
Andy, Dam, what do you think about Guillem's patch? Cheers, gregor
-=| gregor herrmann, 23.03.2016 17:21:59 +0100 |=- Seems to work (tests pass), but is noticeably slower: * without the patch dh-make-perl-dev --cpan Catalyst 29,33s user 2,30s system 94% cpu 33,473 total (second try, after one dummy to fill CPAN/dh-make-perl caches) * with the patch dh-make-perl-dev --cpan Catalyst 233,96s user 3,13s system 99% cpu 3:59,17 total (both timings were on the gregoa/apt-file-3 branch)
Thanks for checking! Ouch; 4 minutes seems a bit suboptimal :/ Ok, I guess this change won't make it into 0.90 in the current form :) Cheers, gregor
A few years later … I tried again. After massaging the patch a bit to apply against git master, I get, with the same methodology: * without the patch: 169.02s user 22.11s system 112% cpu 2:49.26 total * with the patch: 638.29s user 41.14s system 101% cpu 11:06.72 total I guess that's still to slow :) For posterity, I'm attaching the refreshed patch. Cheers, gregor
Hello, Bug #808911 in dh-make-perl reported by you has been fixed in the Git repository and is awaiting an upload. You can see the commit message below and you can check the diff of the fix at: https://salsa.debian.org/perl-team/modules/packages/dh-make-perl/-/commit/241d605f317089ec309b7dcac17707d052f2197e ------------------------------------------------------------------------ replace usage of DPKG::Parse::Available with Dpkg::Index Closes: #808911 The slowdown that was observed in previous attemts was due to `if ($dpkg_available)` evaluating in string context causing stringification of the whole index (≈6s per dependency) ------------------------------------------------------------------------ (this message was generated automatically) -- Greetings https://bugs.debian.org/808911
We believe that the bug you reported is fixed in the latest version of
dh-make-perl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 808911@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Damyan Ivanov <dmn@debian.org> (supplier of updated dh-make-perl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Fri, 10 Jun 2022 15:56:16 +0000
Source: dh-make-perl
Architecture: source
Version: 0.120
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: Damyan Ivanov <dmn@debian.org>
Closes: 808911
Changes:
dh-make-perl (0.120) unstable; urgency=medium
.
[ Damyan Ivanov ]
* replace usage of DPKG::Parse::Available with Dpkg::Index.
(Closes: #808911)
* move the slow check for locally installed packages after the APT contents
check
* add automatic annotation of B-D with <!nocheck>. guarded with
--guess-nocheck
Checksums-Sha1:
f4d93fd3cb15ca3ca5e37ae9a56a7298cc82d6c1 2895 dh-make-perl_0.120.dsc
5425b6afa1954fc4f3c7ad3f5b7b9878cf6eef21 120776 dh-make-perl_0.120.tar.xz
Checksums-Sha256:
0b35edcd9094de6a836f951bb5328049c0136ddfd499f29822def5a742dc90d8 2895 dh-make-perl_0.120.dsc
02272060966a013da32a3a17a77d8c316261e65cccd40d1288697c05a75598b3 120776 dh-make-perl_0.120.tar.xz
Files:
0a03bd1bae0f378c2867a57baf1d4eb2 2895 perl optional dh-make-perl_0.120.dsc
3b9f08b4536ce7e835d6267485e396c6 120776 perl optional dh-make-perl_0.120.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEErqDETssFbpNjDZ0z276dTZnSoAQFAmKjatwACgkQ276dTZnS
oASbiA/8CVUsD77sEyAhHUAVUaOGBXFM2slvWD2Z48UfPxBX6KHsmHT1dmeRQxXJ
JcG6KmHZBs2EiR9N7OHnh90iYXQSGpO6+a4z7PRXjrVi2LvIaPltOuxnPmpQwPlB
SmrGQclkoCMUau3eG+cXbBmO6GcuUW0Hzj8i+R0aqdjIU1ivU8CoTHYf5Z7WFDI+
8KNhihXTxcsJWnLvyqy87NvO/Br2SUg83RvwZNhcplQJyc1IHreq9QGGj5LimlFF
eoRnYPq1Js4oyP0RnAgkkMhpud81nO/sUfNx32hDN/34lytpTRtQ1pB9wwHpYt5z
eJ1UlbHG74ecPKNJWNrgQQEf5JL4UOXs4Dm8R/ljIR+AJYHfbSPCMtVt/nF+fI4F
En4cB2lB5yxEa8y5YPbavUyDHYeF+3/OPJf4BA9arW3haVJySOJqURJuE1LU7DaA
aqQ5vvQa+NW2wMV7GJ6cjGHqC8b+aN2Nl2sHyfBHwjDs5nTTBODdTFc4J6TB+6ng
yct26bzfN+cl/qYRk6hH/VL5Rd4+qt3ry6nYPrrb4VwIOOtej0s9i0u+Qzs/ZX3M
XSf3fm0WR7RCf+00eC9ochOfCn4BNNjU67I3Pd2PWGlhcXtOFeUiaB2aXAIPy/yU
Z/W0eKavn3SpQyEi5GtLodRy3+VF1zHlPLeX8ft4Tm0pYSbo2Lw=
=7jBX
-----END PGP SIGNATURE-----