* Package name : asciiquarium Version : 1.1 Upstream Author : Kirk Baucom <kbaucom@schizoid.com> * URL : http://www.robobunny.com/projects/asciiquarium/html/ * License : GPL2 Programming Lang: Perl Description : Enjoy the mysteries of the sea from the safety of your own terminal! This is a simulation of an aquarium with ASCII art in a terminal. It it not very useful but I find it enjoyable - it'a a nice gimmick. KDE Plasma used to include a screensaver which looked similar. This is my first package for Debian - it would be nice if I could get a sponsor. - Niklas
yet. I heard that our Perl team have a tool to do the entirety of packaging of CPAN modules with a single command, but I don't know the details. And, this looks like an issue: "License: unknown".
Adam Borowski <kilobyte@angband.pl> wrote: In fact, I've built those packages already: https://launchpad.net/~ytvwld/+archive/ubuntu/asciiquarium/+packages Yeah, that's a big issue. Perhaps I could try contacting the author? - Niklas
Cool! If you have already done this, there are no _technical_ reasons against inclusion -- on a "slow scroll"-level review, the code seems sound. People may complain against archive bloat but this package compares favourably to, eg, nyancat (2×arch:all vs 2×arch:any). Right.
https://metacpan.org/release/Term-Animation ? That just means that metacpan failed to automatically extract the license (probably because it's not mentioned in META.yml or META.json). Looking at the tarball [0], the license is clear and free in the README [1]: #v+ COPYRIGHT AND LICENCE Copyright (C) 2003 Kirk Baucom L<kbaucom@schizoid.com> This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself. #v- So that's, as very common for Perl modules, "License: Artistic or GPL-1+". No need to double-check with the author :) (Usual sales pitch: https://wiki.debian.org/Teams/DebianPerlGroup/Welcome ) Cheers, gregor [0] https://cpan.metacpan.org/authors/id/K/KB/KBAUCOM/Term-Animation-2.6.tar.gz [1] also online: https://metacpan.org/source/KBAUCOM/Term-Animation-2.6/README
Niklas Sombert <niklas@ytvwld.de> writes: Please re-write the description to conform with Debian Policy §3.4 and Developer's Reference §6.2. In particular, the synopsis should not be a sentence. Instead it should be a noun phrase stating what the package installs, as characterised in Policy §3.4.1 and Developer's Reference §6.2.2. This bug report doesn't appear to have the proposed long description for the package; please write one (as per the above documentation) and put it in this bug report.
Ben Finney wrote: Description: displays an aquarium with ASCII art This program simulates an aquarium with fish and various other things and displays it using ASCII art on a terminal. - Niklas
The synopsis should be a noun phrase saying what the package *is*. A
package does not *do* anything; you're not describing a program,
you're describing a package. See the Developer's Reference §6.2.2.
Consider: The synopsis for ‘asciiquarium’ should be a good answer to
the question “What does the package ‘asciiquarium’ install?”.
The synopsis text should work correctly in a sentence of the form “The
package ‘asciiquarium’ installs {a,an,the} foo bar baz.”
That looks fine as a long description.
Ben Finney wrote: Oh. :-) "simulation of an aquarium using ASCII art" - Niklas
That's great! Thank you for re-wording it.
I've uploaded both packages to mentors.debian.net. - Niklas