Fabre

#829398 xcfa: Buffer overflow with more than 45 tracks #829398

Package:: xcfa

Source:: xcfa

Description:: X Convert File Audio

Submitter:: SaintGermain

Date:: 2021-03-11 15:27:03 UTC

Severity:: normal

#829398#5

Date:: 2016-07-03 00:29:32 UTC

From:

To:

Dear Maintainer,

With more than 45 tracks on a CD, xcfa crash because of a buffer overflow.
It seems that the array P_TabArgs is defined with a fixed size of 50 elements

I've done some tests with 44, 45, 46 and 47 tracks and here are the relevant logs obtained bu running xcfa with --verbose:

!-----------------------------------------------------------!
!  --Without Expert Parameters--
!  NORMALISE_EXEC Wav -> PEAK/GROUP
!-----------------------------------------------------------!
!  nice -n 0 normalize-audio --gain=-0,100000dB /tmp/xcfa_peak_album_1/0.wav /tmp/xcfa_peak_album_1/1.wav /tmp/xcfa_peak_album_1/2.wav /tmp/xcfa_peak_album_1/3.wav /tmp/xcfa_peak_album_1/4.wav /tmp/xcfa_peak_album_1/5.wav /tmp/xcfa_peak_album_1/6.wav /tmp/xcfa_peak_album_1/7.wav /tmp/xcfa_peak_album_1/8.wav /tmp/xcfa_peak_album_1/9.wav /tmp/xcfa_peak_album_1/10.wav /tmp/xcfa_peak_album_1/11.wav /tmp/xcfa_peak_album_1/12.wav /tmp/xcfa_peak_album_1/13.wav /tmp/xcfa_peak_album_1/14.wav /tmp/xcfa_peak_album_1/15.wav /tmp/xcfa_peak_album_1/16.wav /tmp/xcfa_peak_album_1/17.wav /tmp/xcfa_peak_album_1/18.wav /tmp/xcfa_peak_album_1/19.wav /tmp/xcfa_peak_album_1/20.wav /tmp/xcfa_peak_album_1/21.wav /tmp/xcfa_peak_album_1/22.wav /tmp/xcfa_peak_album_1/23.wav /tmp/xcfa_peak_album_1/24.wav /tmp/xcfa_peak_album_1/25.wav /tmp/xcfa_peak_album_1/26.wav /tmp/xcfa_peak_album_1/27.wav /tmp/xcfa_peak_album_1/28.wav /tmp/xcfa_peak_album_1/29.wav /tmp/xcfa_peak_album_1/30.wav /tmp/xcfa_peak_album_1/31.wav /tmp/xcfa_peak_album_1/32.wav /tmp/xcfa_peak_album_1/33.wav /tmp/xcfa_peak_album_1/34.wav /tmp/xcfa_peak_album_1/35.wav /tmp/xcfa_peak_album_1/36.wav /tmp/xcfa_peak_album_1/37.wav /tmp/xcfa_peak_album_1/38.wav /tmp/xcfa_peak_album_1/39.wav /tmp/xcfa_peak_album_1/40.wav /tmp/xcfa_peak_album_1/41.wav /tmp/xcfa_peak_album_1/42.wav /tmp/xcfa_peak_album_1/43.wav --
!-----------------------------------------------------------!
p_TabArgs[ 00 ] = nice
p_TabArgs[ 01 ] = -n
p_TabArgs[ 02 ] = 0
p_TabArgs[ 03 ] = normalize-audio
p_TabArgs[ 04 ] = --gain=-0,100000dB
p_TabArgs[ 05 ] = /tmp/xcfa_peak_album_1/0.wav
p_TabArgs[ 06 ] = /tmp/xcfa_peak_album_1/1.wav
p_TabArgs[ 07 ] = /tmp/xcfa_peak_album_1/2.wav
p_TabArgs[ 08 ] = /tmp/xcfa_peak_album_1/3.wav
p_TabArgs[ 09 ] = /tmp/xcfa_peak_album_1/4.wav
p_TabArgs[ 10 ] = /tmp/xcfa_peak_album_1/5.wav
p_TabArgs[ 11 ] = /tmp/xcfa_peak_album_1/6.wav
p_TabArgs[ 12 ] = /tmp/xcfa_peak_album_1/7.wav
p_TabArgs[ 13 ] = /tmp/xcfa_peak_album_1/8.wav
p_TabArgs[ 14 ] = /tmp/xcfa_peak_album_1/9.wav
p_TabArgs[ 15 ] = /tmp/xcfa_peak_album_1/10.wav
p_TabArgs[ 16 ] = /tmp/xcfa_peak_album_1/11.wav
p_TabArgs[ 17 ] = /tmp/xcfa_peak_album_1/12.wav
p_TabArgs[ 18 ] = /tmp/xcfa_peak_album_1/13.wav
p_TabArgs[ 19 ] = /tmp/xcfa_peak_album_1/14.wav
p_TabArgs[ 20 ] = /tmp/xcfa_peak_album_1/15.wav
p_TabArgs[ 21 ] = /tmp/xcfa_peak_album_1/16.wav
p_TabArgs[ 22 ] = /tmp/xcfa_peak_album_1/17.wav
p_TabArgs[ 23 ] = /tmp/xcfa_peak_album_1/18.wav
p_TabArgs[ 24 ] = /tmp/xcfa_peak_album_1/19.wav
p_TabArgs[ 25 ] = /tmp/xcfa_peak_album_1/20.wav
p_TabArgs[ 26 ] = /tmp/xcfa_peak_album_1/21.wav
p_TabArgs[ 27 ] = /tmp/xcfa_peak_album_1/22.wav
p_TabArgs[ 28 ] = /tmp/xcfa_peak_album_1/23.wav
p_TabArgs[ 29 ] = /tmp/xcfa_peak_album_1/24.wav
p_TabArgs[ 30 ] = /tmp/xcfa_peak_album_1/25.wav
p_TabArgs[ 31 ] = /tmp/xcfa_peak_album_1/26.wav
p_TabArgs[ 32 ] = /tmp/xcfa_peak_album_1/27.wav
p_TabArgs[ 33 ] = /tmp/xcfa_peak_album_1/28.wav
p_TabArgs[ 34 ] = /tmp/xcfa_peak_album_1/29.wav
p_TabArgs[ 35 ] = /tmp/xcfa_peak_album_1/30.wav
p_TabArgs[ 36 ] = /tmp/xcfa_peak_album_1/31.wav
p_TabArgs[ 37 ] = /tmp/xcfa_peak_album_1/32.wav
p_TabArgs[ 38 ] = /tmp/xcfa_peak_album_1/33.wav
p_TabArgs[ 39 ] = /tmp/xcfa_peak_album_1/34.wav
p_TabArgs[ 40 ] = /tmp/xcfa_peak_album_1/35.wav
p_TabArgs[ 41 ] = /tmp/xcfa_peak_album_1/36.wav
p_TabArgs[ 42 ] = /tmp/xcfa_peak_album_1/37.wav
p_TabArgs[ 43 ] = /tmp/xcfa_peak_album_1/38.wav
p_TabArgs[ 44 ] = /tmp/xcfa_peak_album_1/39.wav
p_TabArgs[ 45 ] = /tmp/xcfa_peak_album_1/40.wav
p_TabArgs[ 46 ] = /tmp/xcfa_peak_album_1/41.wav
p_TabArgs[ 47 ] = /tmp/xcfa_peak_album_1/42.wav
p_TabArgs[ 48 ] = /tmp/xcfa_peak_album_1/43.wav
p_TabArgs[ 49 ] = --

!-----------------------------------------------------------!
!  --Without Expert Parameters--
!  NORMALISE_EXEC Wav -> PEAK/GROUP
!-----------------------------------------------------------!
!  nice -n 0 normalize-audio --gain=-0,100000dB /tmp/xcfa_peak_album_0/0.wav /tmp/xcfa_peak_album_0/1.wav /tmp/xcfa_peak_album_0/2.wav /tmp/xcfa_peak_album_0/3.wav /tmp/xcfa_peak_album_0/4.wav /tmp/xcfa_peak_album_0/5.wav /tmp/xcfa_peak_album_0/6.wav /tmp/xcfa_peak_album_0/7.wav /tmp/xcfa_peak_album_0/8.wav /tmp/xcfa_peak_album_0/9.wav /tmp/xcfa_peak_album_0/10.wav /tmp/xcfa_peak_album_0/11.wav /tmp/xcfa_peak_album_0/12.wav /tmp/xcfa_peak_album_0/13.wav /tmp/xcfa_peak_album_0/14.wav /tmp/xcfa_peak_album_0/15.wav /tmp/xcfa_peak_album_0/16.wav /tmp/xcfa_peak_album_0/17.wav /tmp/xcfa_peak_album_0/18.wav /tmp/xcfa_peak_album_0/19.wav /tmp/xcfa_peak_album_0/20.wav /tmp/xcfa_peak_album_0/21.wav /tmp/xcfa_peak_album_0/22.wav /tmp/xcfa_peak_album_0/23.wav /tmp/xcfa_peak_album_0/24.wav /tmp/xcfa_peak_album_0/25.wav /tmp/xcfa_peak_album_0/26.wav /tmp/xcfa_peak_album_0/27.wav /tmp/xcfa_peak_album_0/28.wav /tmp/xcfa_peak_album_0/29.wav /tmp/xcfa_peak_album_0/30.wav /tmp/xcfa_peak_album_0/31.wav /tmp/xcfa_peak_album_0/32.wav /tmp/xcfa_peak_album_0/33.wav /tmp/xcfa_peak_album_0/34.wav /tmp/xcfa_peak_album_0/35.wav /tmp/xcfa_peak_album_0/36.wav /tmp/xcfa_peak_album_0/37.wav /tmp/xcfa_peak_album_0/38.wav /tmp/xcfa_peak_album_0/39.wav /tmp/xcfa_peak_album_0/40.wav /tmp/xcfa_peak_album_0/41.wav /tmp/xcfa_peak_album_0/42.wav /tmp/xcfa_peak_album_0/43.wav /tmp/xcfa_peak_album_0/44.wav --
!-----------------------------------------------------------!
p_TabArgs[ 00 ] = nice
p_TabArgs[ 01 ] = -n
p_TabArgs[ 02 ] = 0
p_TabArgs[ 03 ] = normalize-audio
p_TabArgs[ 04 ] = --gain=-0,100000dB
p_TabArgs[ 05 ] = /tmp/xcfa_peak_album_0/0.wav
p_TabArgs[ 06 ] = /tmp/xcfa_peak_album_0/1.wav
p_TabArgs[ 07 ] = /tmp/xcfa_peak_album_0/2.wav
p_TabArgs[ 08 ] = /tmp/xcfa_peak_album_0/3.wav
p_TabArgs[ 09 ] = /tmp/xcfa_peak_album_0/4.wav
p_TabArgs[ 10 ] = /tmp/xcfa_peak_album_0/5.wav
p_TabArgs[ 11 ] = /tmp/xcfa_peak_album_0/6.wav
p_TabArgs[ 12 ] = /tmp/xcfa_peak_album_0/7.wav
p_TabArgs[ 13 ] = /tmp/xcfa_peak_album_0/8.wav
p_TabArgs[ 14 ] = /tmp/xcfa_peak_album_0/9.wav
p_TabArgs[ 15 ] = /tmp/xcfa_peak_album_0/10.wav
p_TabArgs[ 16 ] = /tmp/xcfa_peak_album_0/11.wav
p_TabArgs[ 17 ] = /tmp/xcfa_peak_album_0/12.wav
p_TabArgs[ 18 ] = /tmp/xcfa_peak_album_0/13.wav
p_TabArgs[ 19 ] = /tmp/xcfa_peak_album_0/14.wav
p_TabArgs[ 20 ] = /tmp/xcfa_peak_album_0/15.wav
p_TabArgs[ 21 ] = /tmp/xcfa_peak_album_0/16.wav
p_TabArgs[ 22 ] = /tmp/xcfa_peak_album_0/17.wav
p_TabArgs[ 23 ] = /tmp/xcfa_peak_album_0/18.wav
p_TabArgs[ 24 ] = /tmp/xcfa_peak_album_0/19.wav
p_TabArgs[ 25 ] = /tmp/xcfa_peak_album_0/20.wav
p_TabArgs[ 26 ] = /tmp/xcfa_peak_album_0/21.wav
p_TabArgs[ 27 ] = /tmp/xcfa_peak_album_0/22.wav
p_TabArgs[ 28 ] = /tmp/xcfa_peak_album_0/23.wav
p_TabArgs[ 29 ] = /tmp/xcfa_peak_album_0/24.wav
p_TabArgs[ 30 ] = /tmp/xcfa_peak_album_0/25.wav
p_TabArgs[ 31 ] = /tmp/xcfa_peak_album_0/26.wav
p_TabArgs[ 32 ] = /tmp/xcfa_peak_album_0/27.wav
p_TabArgs[ 33 ] = /tmp/xcfa_peak_album_0/28.wav
p_TabArgs[ 34 ] = /tmp/xcfa_peak_album_0/29.wav
p_TabArgs[ 35 ] = /tmp/xcfa_peak_album_0/30.wav
p_TabArgs[ 36 ] = /tmp/xcfa_peak_album_0/31.wav
p_TabArgs[ 37 ] = /tmp/xcfa_peak_album_0/32.wav
p_TabArgs[ 38 ] = /tmp/xcfa_peak_album_0/33.wav
p_TabArgs[ 39 ] = /tmp/xcfa_peak_album_0/34.wav
p_TabArgs[ 40 ] = /tmp/xcfa_peak_album_0/35.wav
p_TabArgs[ 41 ] = /tmp/xcfa_peak_album_0/36.wav
p_TabArgs[ 42 ] = /tmp/xcfa_peak_album_0/37.wav
p_TabArgs[ 43 ] = /tmp/xcfa_peak_album_0/38.wav
p_TabArgs[ 44 ] = /tmp/xcfa_peak_album_0/39.wav
p_TabArgs[ 45 ] = /tmp/xcfa_peak_album_0/40.wav
p_TabArgs[ 46 ] = /tmp/xcfa_peak_album_0/41.wav
p_TabArgs[ 47 ] = /tmp/xcfa_peak_album_0/42.wav
p_TabArgs[ 48 ] = /tmp/xcfa_peak_album_0/43.wav
p_TabArgs[ 49 ] = /tmp/xcfa_peak_album_0/44.wav
p_TabArgs[ 50 ] = --

*** Error in `xcfa': free(): invalid pointer: 0x00007f2b30002240 ***
Abandon

!-----------------------------------------------------------!
!  --Without Expert Parameters--
!  NORMALISE_GET_LEVEL -> PEAK/GROUP
!-----------------------------------------------------------!
!  nice -n 0 normalize-audio -n /tmp/xcfa_peak_album_1/0.wav /tmp/xcfa_peak_album_1/1.wav /tmp/xcfa_peak_album_1/2.wav /tmp/xcfa_peak_album_1/3.wav /tmp/xcfa_peak_album_1/4.wav /tmp/xcfa_peak_album_1/5.wav /tmp/xcfa_peak_album_1/6.wav /tmp/xcfa_peak_album_1/7.wav /tmp/xcfa_peak_album_1/8.wav /tmp/xcfa_peak_album_1/9.wav /tmp/xcfa_peak_album_1/10.wav /tmp/xcfa_peak_album_1/11.wav /tmp/xcfa_peak_album_1/12.wav /tmp/xcfa_peak_album_1/13.wav /tmp/xcfa_peak_album_1/14.wav /tmp/xcfa_peak_album_1/15.wav /tmp/xcfa_peak_album_1/16.wav /tmp/xcfa_peak_album_1/17.wav /tmp/xcfa_peak_album_1/18.wav /tmp/xcfa_peak_album_1/19.wav /tmp/xcfa_peak_album_1/20.wav /tmp/xcfa_peak_album_1/21.wav /tmp/xcfa_peak_album_1/22.wav /tmp/xcfa_peak_album_1/23.wav /tmp/xcfa_peak_album_1/24.wav /tmp/xcfa_peak_album_1/25.wav /tmp/xcfa_peak_album_1/26.wav /tmp/xcfa_peak_album_1/27.wav /tmp/xcfa_peak_album_1/28.wav /tmp/xcfa_peak_album_1/29.wav /tmp/xcfa_peak_album_1/30.wav /tmp/xcfa_peak_album_1/31.wav /tmp/xcfa_peak_album_1/32.wav /tmp/xcfa_peak_album_1/33.wav /tmp/xcfa_peak_album_1/34.wav /tmp/xcfa_peak_album_1/35.wav /tmp/xcfa_peak_album_1/36.wav /tmp/xcfa_peak_album_1/37.wav /tmp/xcfa_peak_album_1/38.wav /tmp/xcfa_peak_album_1/39.wav /tmp/xcfa_peak_album_1/40.wav /tmp/xcfa_peak_album_1/41.wav /tmp/xcfa_peak_album_1/42.wav /tmp/xcfa_peak_album_1/43.wav /tmp/xcfa_peak_album_1/44.wav /tmp/xcfa_peak_album_1/45.wav
!-----------------------------------------------------------!
p_TabArgs[ 00 ] = nice
p_TabArgs[ 01 ] = -n
p_TabArgs[ 02 ] = 0
p_TabArgs[ 03 ] = normalize-audio
p_TabArgs[ 04 ] = -n
p_TabArgs[ 05 ] = /tmp/xcfa_peak_album_1/0.wav
p_TabArgs[ 06 ] = /tmp/xcfa_peak_album_1/1.wav
p_TabArgs[ 07 ] = /tmp/xcfa_peak_album_1/2.wav
p_TabArgs[ 08 ] = /tmp/xcfa_peak_album_1/3.wav
p_TabArgs[ 09 ] = /tmp/xcfa_peak_album_1/4.wav
p_TabArgs[ 10 ] = /tmp/xcfa_peak_album_1/5.wav
p_TabArgs[ 11 ] = /tmp/xcfa_peak_album_1/6.wav
p_TabArgs[ 12 ] = /tmp/xcfa_peak_album_1/7.wav
p_TabArgs[ 13 ] = /tmp/xcfa_peak_album_1/8.wav
p_TabArgs[ 14 ] = /tmp/xcfa_peak_album_1/9.wav
p_TabArgs[ 15 ] = /tmp/xcfa_peak_album_1/10.wav
p_TabArgs[ 16 ] = /tmp/xcfa_peak_album_1/11.wav
p_TabArgs[ 17 ] = /tmp/xcfa_peak_album_1/12.wav
p_TabArgs[ 18 ] = /tmp/xcfa_peak_album_1/13.wav
p_TabArgs[ 19 ] = /tmp/xcfa_peak_album_1/14.wav
p_TabArgs[ 20 ] = /tmp/xcfa_peak_album_1/15.wav
p_TabArgs[ 21 ] = /tmp/xcfa_peak_album_1/16.wav
p_TabArgs[ 22 ] = /tmp/xcfa_peak_album_1/17.wav
p_TabArgs[ 23 ] = /tmp/xcfa_peak_album_1/18.wav
p_TabArgs[ 24 ] = /tmp/xcfa_peak_album_1/19.wav
p_TabArgs[ 25 ] = /tmp/xcfa_peak_album_1/20.wav
p_TabArgs[ 26 ] = /tmp/xcfa_peak_album_1/21.wav
p_TabArgs[ 27 ] = /tmp/xcfa_peak_album_1/22.wav
p_TabArgs[ 28 ] = /tmp/xcfa_peak_album_1/23.wav
p_TabArgs[ 29 ] = /tmp/xcfa_peak_album_1/24.wav
p_TabArgs[ 30 ] = /tmp/xcfa_peak_album_1/25.wav
p_TabArgs[ 31 ] = /tmp/xcfa_peak_album_1/26.wav
p_TabArgs[ 32 ] = /tmp/xcfa_peak_album_1/27.wav
p_TabArgs[ 33 ] = /tmp/xcfa_peak_album_1/28.wav
p_TabArgs[ 34 ] = /tmp/xcfa_peak_album_1/29.wav
p_TabArgs[ 35 ] = /tmp/xcfa_peak_album_1/30.wav
p_TabArgs[ 36 ] = /tmp/xcfa_peak_album_1/31.wav
p_TabArgs[ 37 ] = /tmp/xcfa_peak_album_1/32.wav
p_TabArgs[ 38 ] = /tmp/xcfa_peak_album_1/33.wav
p_TabArgs[ 39 ] = /tmp/xcfa_peak_album_1/34.wav
p_TabArgs[ 40 ] = /tmp/xcfa_peak_album_1/35.wav
p_TabArgs[ 41 ] = /tmp/xcfa_peak_album_1/36.wav
p_TabArgs[ 42 ] = /tmp/xcfa_peak_album_1/37.wav
p_TabArgs[ 43 ] = /tmp/xcfa_peak_album_1/38.wav
p_TabArgs[ 44 ] = /tmp/xcfa_peak_album_1/39.wav
p_TabArgs[ 45 ] = /tmp/xcfa_peak_album_1/40.wav
p_TabArgs[ 46 ] = /tmp/xcfa_peak_album_1/41.wav
p_TabArgs[ 47 ] = /tmp/xcfa_peak_album_1/42.wav
p_TabArgs[ 48 ] = /tmp/xcfa_peak_album_1/43.wav
p_TabArgs[ 49 ] = /tmp/xcfa_peak_album_1/44.wav
p_TabArgs[ 50 ] = /tmp/xcfa_peak_album_1/45.wav

Computing levels...
  level        peak         gain

SUR LES TRES BONS CONSEILS DE @Dzef  ;-)
        dmin = -6,706500
        dmax = 0,000000
        0.0 - dmax(0,000000) - 0.1 = -0,100000
        conv.value_PEAK_RMS_GROUP_ARGS = -0,100000

*** Error in `xcfa': free(): invalid pointer: 0x00007f9d3c002240 ***
Abandon

!-----------------------------------------------------------!
!  --Without Expert Parameters--
!  NORMALISE_GET_LEVEL -> PEAK/GROUP
!-----------------------------------------------------------!
!  nice -n 0 normalize-audio -n /tmp/xcfa_peak_album_0/0.wav  /tmp/xcfa_peak_album_0/2.wav /tmp/xcfa_peak_album_0/3.wav /tmp/xcfa_peak_album_0/4.wav /tmp/xcfa_peak_album_0/5.wav /tmp/xcfa_peak_album_0/6.wav /tmp/xcfa_peak_album_0/7.wav /tmp/xcfa_peak_album_0/8.wav /tmp/xcfa_peak_album_0/9.wav /tmp/xcfa_peak_album_0/10.wav /tmp/xcfa_peak_album_0/11.wav /tmp/xcfa_peak_album_0/12.wav /tmp/xcfa_peak_album_0/13.wav /tmp/xcfa_peak_album_0/14.wav /tmp/xcfa_peak_album_0/15.wav /tmp/xcfa_peak_album_0/16.wav /tmp/xcfa_peak_album_0/17.wav /tmp/xcfa_peak_album_0/18.wav /tmp/xcfa_peak_album_0/19.wav /tmp/xcfa_peak_album_0/20.wav /tmp/xcfa_peak_album_0/21.wav /tmp/xcfa_peak_album_0/22.wav /tmp/xcfa_peak_album_0/23.wav /tmp/xcfa_peak_album_0/24.wav /tmp/xcfa_peak_album_0/25.wav /tmp/xcfa_peak_album_0/26.wav /tmp/xcfa_peak_album_0/27.wav /tmp/xcfa_peak_album_0/28.wav /tmp/xcfa_peak_album_0/29.wav /tmp/xcfa_peak_album_0/30.wav /tmp/xcfa_peak_album_0/31.wav /tmp/xcfa_peak_album_0/32.wav /tmp/xcfa_peak_album_0/33.wav /tmp/xcfa_peak_album_0/34.wav /tmp/xcfa_peak_album_0/35.wav /tmp/xcfa_peak_album_0/36.wav /tmp/xcfa_peak_album_0/37.wav /tmp/xcfa_peak_album_0/38.wav /tmp/xcfa_peak_album_0/39.wav /tmp/xcfa_peak_album_0/40.wav /tmp/xcfa_peak_album_0/41.wav /tmp/xcfa_peak_album_0/42.wav /tmp/xcfa_peak_album_0/43.wav /tmp/xcfa_peak_album_0/44.wav /tmp/xcfa_peak_album_0/45.wav /tmp/xcfa_peak_album_0/46.wav
!-----------------------------------------------------------!
p_TabArgs[ 00 ] = nice
p_TabArgs[ 01 ] = -n
p_TabArgs[ 02 ] = 0
p_TabArgs[ 03 ] = normalize-audio
p_TabArgs[ 04 ] = -n
p_TabArgs[ 05 ] = /tmp/xcfa_peak_album_0/0.wav
p_TabArgs[ 06 ] =
p_TabArgs[ 07 ] = /tmp/xcfa_peak_album_0/2.wav
p_TabArgs[ 08 ] = /tmp/xcfa_peak_album_0/3.wav
p_TabArgs[ 09 ] = /tmp/xcfa_peak_album_0/4.wav
p_TabArgs[ 10 ] = /tmp/xcfa_peak_album_0/5.wav
p_TabArgs[ 11 ] = /tmp/xcfa_peak_album_0/6.wav
p_TabArgs[ 12 ] = /tmp/xcfa_peak_album_0/7.wav
p_TabArgs[ 13 ] = /tmp/xcfa_peak_album_0/8.wav
p_TabArgs[ 14 ] = /tmp/xcfa_peak_album_0/9.wav
p_TabArgs[ 15 ] = /tmp/xcfa_peak_album_0/10.wav
p_TabArgs[ 16 ] = /tmp/xcfa_peak_album_0/11.wav
p_TabArgs[ 17 ] = /tmp/xcfa_peak_album_0/12.wav
p_TabArgs[ 18 ] = /tmp/xcfa_peak_album_0/13.wav
p_TabArgs[ 19 ] = /tmp/xcfa_peak_album_0/14.wav
p_TabArgs[ 20 ] = /tmp/xcfa_peak_album_0/15.wav
p_TabArgs[ 21 ] = /tmp/xcfa_peak_album_0/16.wav
p_TabArgs[ 22 ] = /tmp/xcfa_peak_album_0/17.wav
p_TabArgs[ 23 ] = /tmp/xcfa_peak_album_0/18.wav
p_TabArgs[ 24 ] = /tmp/xcfa_peak_album_0/19.wav
p_TabArgs[ 25 ] = /tmp/xcfa_peak_album_0/20.wav
p_TabArgs[ 26 ] = /tmp/xcfa_peak_album_0/21.wav
p_TabArgs[ 27 ] = /tmp/xcfa_peak_album_0/22.wav
p_TabArgs[ 28 ] = /tmp/xcfa_peak_album_0/23.wav
p_TabArgs[ 29 ] = /tmp/xcfa_peak_album_0/24.wav
p_TabArgs[ 30 ] = /tmp/xcfa_peak_album_0/25.wav
p_TabArgs[ 31 ] = /tmp/xcfa_peak_album_0/26.wav
p_TabArgs[ 32 ] = /tmp/xcfa_peak_album_0/27.wav
p_TabArgs[ 33 ] = /tmp/xcfa_peak_album_0/28.wav
p_TabArgs[ 34 ] = /tmp/xcfa_peak_album_0/29.wav
p_TabArgs[ 35 ] = /tmp/xcfa_peak_album_0/30.wav
p_TabArgs[ 36 ] = /tmp/xcfa_peak_album_0/31.wav
p_TabArgs[ 37 ] = /tmp/xcfa_peak_album_0/32.wav
p_TabArgs[ 38 ] = /tmp/xcfa_peak_album_0/33.wav
p_TabArgs[ 39 ] = /tmp/xcfa_peak_album_0/34.wav
p_TabArgs[ 40 ] = /tmp/xcfa_peak_album_0/35.wav
p_TabArgs[ 41 ] = /tmp/xcfa_peak_album_0/36.wav
p_TabArgs[ 42 ] = /tmp/xcfa_peak_album_0/37.wav
p_TabArgs[ 43 ] = /tmp/xcfa_peak_album_0/38.wav
p_TabArgs[ 44 ] = /tmp/xcfa_peak_album_0/39.wav
p_TabArgs[ 45 ] = /tmp/xcfa_peak_album_0/40.wav
p_TabArgs[ 46 ] = /tmp/xcfa_peak_album_0/41.wav
p_TabArgs[ 47 ] = /tmp/xcfa_peak_album_0/42.wav
p_TabArgs[ 48 ] = /tmp/xcfa_peak_album_0/43.wav
p_TabArgs[ 49 ] = /tmp/xcfa_peak_album_0/44.wav
p_TabArgs[ 50 ] = /tmp/xcfa_peak_album_0/45.wav
p_TabArgs[ 51 ] = /tmp/xcfa_peak_album_0/46.wav

normalize-audio: file : Aucun fichier ou dossier de ce type
Computing levels...
  level        peak         gain

SUR LES TRES BONS CONSEILS DE @Dzef  ;-)
        dmin = -6,706500
        dmax = 0,000000
        0.0 - dmax(0,000000) - 0.1 = -0,100000
        conv.value_PEAK_RMS_GROUP_ARGS = -0,100000

*** Error in `xcfa': double free or corruption (out): 0x00007f84f0002240 ***
Abandon

#829398#10

Date:: 2016-07-03 12:14:50 UTC

From:

To:

Problem is apparently in file file_lc.c in function filelc_AllocTabArgs:

gchar **filelc_AllocTabArgs( void )
{
	gchar	**PtrTab = (gchar **)g_malloc0( sizeof(gchar **) * 50 );

	PtrTab [ 0 ] = g_strdup( "nice" );
	PtrTab [ 1 ] = g_strdup( "-n" );
	PtrTab [ 2 ] = g_strdup_printf( "%d", Config.Nice );

	return( (gchar **)PtrTab );
}

There you can see the fixed size for the array.

#829398#15

Date:: 2021-03-11 15:22:45 UTC

From:

To:

tags -1 + patch
user debian-release@lists.debian.org
usertags -1 + bsp-2021-03-latinoamerica
kthxbye

So, a trivial workaround for this issue would be to increase the
amount of entries in the allocation table:


diff --git a/src/file_lc.c b/src/file_lc.c
index 4d9ce0c..ef774ee 100644
--- a/src/file_lc.c
+++ b/src/file_lc.c
@@ -57,7 +57,7 @@
 //
 gchar **filelc_AllocTabArgs( void )
 {
-	gchar	**PtrTab = (gchar **)g_malloc0( sizeof(gchar **) * 50 );
+	gchar	**PtrTab = (gchar **)g_malloc0( sizeof(gchar **) * 110 );

 	PtrTab [ 0 ] = g_strdup( "nice" );
 	PtrTab [ 1 ] = g_strdup( "-n" );


I chose 110 in order to leave space for the relevant logs mentioned by
the bug submitter. While this is not a definitive answer and does not
make the buffer overflow go away, this would allow all
standards-compliant CDDA disks to be produced -- A CD can contain up
to 99 tracks¹, so this would allow for creating all valid CDs.

Of course, this trivial patch does not take away the overflow
potential (and that should definitively be addressed!), and does not
yet properly communicate to users they requested the creation of
something that would break the standards. But it would be a first,
trivial step to fix this (old!) bug allowing for the creation of valid
images.

¹ https://en.wikipedia.org/wiki/Compact_Disc_Digital_Audio#Tracks
  The official standard is not freely available.

#829398 xcfa: Buffer overflow with more than 45 tracks #829398

Just Reply to ...

Reply to submitter ...

Send control command (Silently)

Set Architecture Tags (Silently)