#847962 rng-tools: Patch to fix the broken FIPS 140-2 runs test

Package:
rng-tools5
Source:
rng-tools5
Description:
Daemon to use a Hardware TRNG
Submitter:
Ron
Date:
2026-07-24 17:03:02 UTC
Severity:
normal
Tags:
#847962#5
Date:
2015-01-24 10:16:02 UTC
From:
To:
Hi,

So I recently wrote some code to do the FIPS 140 tests, and though test
suites are good and all that, for something like this I also wanted to
run it against an independent implementation as a cross correlation on
sanity, and found the code in rng-tools which looked like it would be a
good candidate for that ...

Except they disagreed on a small, but large enough to be disturbing,
number of blocks for the Runs and Poker tests.  At first glance we did
appear to be using the same thresholds, so clearly Something Was Wrong.

Happily (for me :), it turns out that my code was correct.
Also happily (for you, I hope ;), I've attached a patch that fixes two
bugs in the Runs test in rng-tools (which broke both tests).

You can pull it from here:
http://anonscm.debian.org/cgit/users/ron/rng-tools.git/commit/?id=27c260ae79e3b02f81062328497648b1e5f46613

And if reportbug --attach actually worked, the git-format-patch export
should be included in this mail.  There's a full description of the
bugs in the commit message of it.

This might be a good one to also push upstream, if they haven't found
and fixed it already.  I've only looked at the code in your fork so far.

  Cheers,
  Ron
#847962#22
Date:
2020-11-23 17:24:43 UTC
From:
To:
#847962#29
Date:
2020-11-23 18:59:52 UTC
From:
To:
Can you submit your patch as a PR here: https://github.com/nhorman/rng-tools/
pulls ?

I could do it, but it would make much more sense that you'd do it.

Diederik
#847962#32
Date:
2020-11-23 18:59:52 UTC
From:
To:
Can you submit your patch as a PR here: https://github.com/nhorman/rng-tools/
pulls ?

I could do it, but it would make much more sense that you'd do it.

Diederik
#847962#37
Date:
2020-11-24 12:41:02 UTC
From:
To:
Hi Diederik,

I'm not on github - but it's definitely applicable upstream, I'd sent it
there (to Jeff Garzik and HPA who were the maintainers at the time),
the same day I pushed the patch into the Debian BTS ... but I never
heard back from either of them at the time either.  If he doesn't
want to git-am the patch file, he should be able to pull it from here:

https://salsa.debian.org/ron/rng-tools/-/commit/27c260ae79e3b02f81062328497648b1e5f46613

Which is the new working repo copy since the old anonscm.d.o link died
when alioth went away ...

  Cheers,
  Ron
#847962#42
Date:
2020-11-24 13:36:50 UTC
From:
To:
Hi Ron,

I tried to git-am the patch but that failed with "Patch format detection
failed." but I couldn't see why it would fail.
So I'll submit this: https://github.com/diederikdehaas/rng-tools/commit/
53bec762f87d81c3fef40e3cc2bdd37c97ab817c
where I git-apply-d your patch and specified you as author in the commit.

Cheers,
  Diederik
#847962#47
Date:
2020-11-24 14:07:07 UTC
From:
To:
With the merge of https://github.com/nhorman/rng-tools/issues/106 this issue
is fixed upstream.
#847962#54
Date:
2026-07-24 16:31:29 UTC
From:
To:
The Debian NEW review of rng-tools 6.17-1 has been completed.

Decision: ACCEPTED
Reviewer: Mechtilde Stehmann

Review comment:

hi,

please list *all* authors with their files in d/copyright.
Please list the files separately which are GPL-2+ and which are GPL-2 (only)
Thanks

Full review details: https://dfsg-new-queue.debian.org/reviews/rng-tools
#847962#59
Date:
2026-07-24 17:00:10 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
rng-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 847962@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <bage@debian.org> (supplier of updated rng-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 21 Jul 2026 23:03:41 +0200
Source: rng-tools
Binary: rng-tools rng-tools-dbgsym
Architecture: source amd64
Version: 6.17-1
Distribution: experimental
Urgency: medium
Maintainer: Bastian Germann <bage@debian.org>
Changed-By: Bastian Germann <bage@debian.org>
Description:
 rng-tools  - Daemon to use a Hardware TRNG
Closes: 847962 922677 970388
Changes:
 rng-tools (6.17-1) experimental; urgency=medium
 .
   * Scan GitHub for new versions (Closes: #970388)
   * Update debhelper-compat to 14
   * Update to latest upstream version, reintroducing the rng-tools source
     package (Closes: #922677, #847962)
Checksums-Sha1:
 b88b8a5df7426e0075b497b07930274d67a684b6 1626 rng-tools_6.17-1.dsc
 48cccc9c79bc168545a526465ea0443081fdf6f4 70000 rng-tools_6.17.orig.tar.gz
 3933a59b2fb213e14d9b5fe99b060db168c5bded 10888 rng-tools_6.17-1.debian.tar.xz
 910778467b3afc9af0f64add5fc67de0344a2a73 133848 rng-tools-dbgsym_6.17-1_amd64.deb
 a2bc70a0eec8869350faff0139b14b5c465138f8 7729 rng-tools_6.17-1_amd64.buildinfo
 6bef037f3ac30ded6aed330c4460be94f178b921 49004 rng-tools_6.17-1_amd64.deb
Checksums-Sha256:
 592762e1a2be7cd0b221f17ae3ed3a2214ae8da3d81eddd2c35d51ce0f4a3b76 1626 rng-tools_6.17-1.dsc
 bae3740f3502c01330915aeb22b89441e9d8e14b72448f6a078d365c1c9fda29 70000 rng-tools_6.17.orig.tar.gz
 0305bde070840848e6936b2c99576fc69e00783c751c5acb159b012bfc754129 10888 rng-tools_6.17-1.debian.tar.xz
 90abaf324e4b99c344070974f19d92c4a322e8aadfc3ebeba001ccf81e4ba9d4 133848 rng-tools-dbgsym_6.17-1_amd64.deb
 11fdc76234567996baae50bf4dcdf22682b32406b93cf34b670de67299419993 7729 rng-tools_6.17-1_amd64.buildinfo
 1abcbd53815426d5235cb90c88e1857d3016f3e1281e710b70a00a63bac07278 49004 rng-tools_6.17-1_amd64.deb
Files:
 73ce3f6a6552494599eb6e0f69e90a28 1626 utils optional rng-tools_6.17-1.dsc
 54922b431f269daed906ddc42de1a516 70000 utils optional rng-tools_6.17.orig.tar.gz
 4920dab48048edd4201fa5f30ed5c1f7 10888 utils optional rng-tools_6.17-1.debian.tar.xz
 ec854710c3d4db7f7d849184b117cc72 133848 debug optional rng-tools-dbgsym_6.17-1_amd64.deb
 1d57f4702dcfae7f98e76da143e8b860 7729 utils optional rng-tools_6.17-1_amd64.buildinfo
 975dab1f40020fc62d2967c948f4d39c 49004 utils optional rng-tools_6.17-1_amd64.deb
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmpf72cQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFCuvC/sEvdb19c9lMiT+hjrHqEcgx99fpJyz4wUA
m8TzO/dqZwTqA1cH0hsSd8uzNVvC8LximY5pIYQf8rc51WrWTEyNeW3ol3mx42Va
K4N1E5Eof3OuImPGXFsscewFSDq7xtswhn9iDlVAqzeXKlR1/wdMk2JeDxw2+OWf
tw9RhGtILuRJ6Fi6JZ8VYU1QjXnf5XWfPVdmXsKI5i1c7+y0vmWaWkEek1hHPRsV
wH+VtWhAbpmTF20Bes7m2TlIG2AKmmRY2drWI24pBOqQY2Hg3bD3iQjyu2RTpNCk
v7x1RVSQyJ+8XVKsgVk5oZzjaGRs2fTkd+vBObvMtYtTzHkL8UiSE70Pcvh34zMa
yaL6H3FSS/x3Qc+3HNERwmia5hnWHO3g9CriJKJHkWph8z8nSvT/DfA6LTR5Ddkx
wv1aIRx8ukccacZacsOXrj6ziZMTDJahJtJI3GvY8oR3zqflB52PAb8HSaHb2bAV
UF6hBzj18RUp8p4bq2Sam5RTiS7rCkY=
=jT8W
-----END PGP SIGNATURE-----